From: Thierry Reding <thierry.reding@gmail.com>
To: "Philippe Rétornaz" <philippe.retornaz@gmail.com>
Cc: Denis Carikli <denis@eukrea.com>,
linux-pwm@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>,
devicetree@vger.kernel.org, Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@linaro.org>,
Shawn Guo <shawn.guo@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] pwm: Add mc13xxx pwm driver.
Date: Thu, 28 Nov 2013 16:56:07 +0100 [thread overview]
Message-ID: <20131128155606.GC23201@ulmo.nvidia.com> (raw)
In-Reply-To: <529616A9.2090909@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
On Wed, Nov 27, 2013 at 04:58:33PM +0100, Philippe Rétornaz wrote:
> Hi
>
> >+struct mc13xxx *get_mc13xxx(void)
> >+{
> >+ return mc13xxx_data;
> >+}
> >+EXPORT_SYMBOL_GPL(get_mc13xxx);
> >+
> > int mc13xxx_common_init(struct mc13xxx *mc13xxx,
> > struct mc13xxx_platform_data *pdata, int irq)
> > {
> >@@ -706,6 +714,9 @@ err_revision:
> > mc13xxx_add_subdevice(mc13xxx, "%s-pwrbutton");
> > }
> >
> >+ /* Linux will not have to handle more than one mc13xxx pmic. */
> >+ mc13xxx_data = mc13xxx;
> >+
>
> Why using a such hack instead of an MFD subdevice ?
I agree, let's not do this please.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] pwm: Add mc13xxx pwm driver.
Date: Thu, 28 Nov 2013 16:56:07 +0100 [thread overview]
Message-ID: <20131128155606.GC23201@ulmo.nvidia.com> (raw)
In-Reply-To: <529616A9.2090909@gmail.com>
On Wed, Nov 27, 2013 at 04:58:33PM +0100, Philippe R?tornaz wrote:
> Hi
>
> >+struct mc13xxx *get_mc13xxx(void)
> >+{
> >+ return mc13xxx_data;
> >+}
> >+EXPORT_SYMBOL_GPL(get_mc13xxx);
> >+
> > int mc13xxx_common_init(struct mc13xxx *mc13xxx,
> > struct mc13xxx_platform_data *pdata, int irq)
> > {
> >@@ -706,6 +714,9 @@ err_revision:
> > mc13xxx_add_subdevice(mc13xxx, "%s-pwrbutton");
> > }
> >
> >+ /* Linux will not have to handle more than one mc13xxx pmic. */
> >+ mc13xxx_data = mc13xxx;
> >+
>
> Why using a such hack instead of an MFD subdevice ?
I agree, let's not do this please.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131128/8c371438/attachment-0001.sig>
next prev parent reply other threads:[~2013-11-28 15:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 15:39 [PATCH 1/3] pwm: Add mc13xxx pwm driver Denis Carikli
2013-11-27 15:39 ` Denis Carikli
2013-11-27 15:39 ` [PATCH 2/3] ARM: dts: mbimxsd53 Add backlight and LCD regulator Denis Carikli
2013-11-27 15:39 ` Denis Carikli
2013-11-28 16:06 ` Thierry Reding
2013-11-28 16:06 ` Thierry Reding
2013-11-27 15:39 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable mc13xxx-pwm support Denis Carikli
2013-11-27 15:39 ` Denis Carikli
2013-11-28 15:58 ` Thierry Reding
2013-11-28 15:58 ` Thierry Reding
2013-11-27 15:54 ` [PATCH 1/3] pwm: Add mc13xxx pwm driver Alexander Shiyan
2013-11-27 15:54 ` Alexander Shiyan
2013-11-27 15:58 ` Philippe Rétornaz
2013-11-27 15:58 ` Philippe Rétornaz
2013-11-28 15:56 ` Thierry Reding [this message]
2013-11-28 15:56 ` Thierry Reding
2013-11-28 20:10 ` Thierry Reding
2013-11-28 20:10 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128155606.GC23201@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=denis@eukrea.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=philippe.retornaz@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.