Re: Change to vsftpd recipe

[Joe MacDonald <joe@deserted.net>]

[-- Attachment #1: Type: text/plain, Size: 2523 bytes --]

Hey Diego,

[[oe] Change to vsftpd recipe] On 13.11.28 (Thu 15:08) Diego Sueiro wrote:

> Folks,
> 
> I realized that when trying to connect via ftp to a target system (which
> has vsftpd installed) I should had to create the /var/run/vsftpd/empty
> directory before.
> 
> Bellow is the patch to create the folder on vsftpd install task:
> 
> diff --git a/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bbb/meta-networking/recipes-daemons/vsftpd/
> vsftpd_3.0.0.bb
> index 49d5d2a..82466d1 100644
> --- a/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb
> +++ b/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb
> @@ -70,6 +70,8 @@ do_install() {
>          sed -i "s:/lib/security:${base_libdir}/security:"
> ${D}${sysconfdir}/pam.d/vsftpd
>          sed -i "s:ftpusers:vsftpd.ftpusers:" ${D}${sysconfdir}/pam.d/vsftpd
>      fi
> +
> +    install -d ${D}${localstatedir}/run/vsftpd/empty
>  }
> 
>  INITSCRIPT_PACKAGES = "${PN}"

Interesting.  I just recently merge 1c4921817, which points vsftpd at
/var/run/vsftpd/empty, but I haven't actually used vstftp as a server
since then so I didn't notice this problem.  When I tried re-creating
your proposed change I got the expected QA issues:

------------------------------------------------------------------------
ERROR: QA Issue: vsftpd: Files/directories were installed but not shipped
  /run
  /run/vsftpd
  /run/vsftpd/empty
ERROR: QA run found fatal errors. Please consider fixing them.
ERROR: Function failed: do_package_qa
ERROR: Logfile of failure stored in: /home/builds/yocto-mainline/builds/meta-networking-build/tmp/work/core2-poky-linux/vsftpd/3.0.0-r0/temp/log.do_package.26442
ERROR: Task 10 (/home/builds/yocto-mainline/builds/meta-networking-build/../../meta-oe/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb, do_package) failed with exit code '1'
------------------------------------------------------------------------

Care to take a run at reverting 1c4921817 in your tree and see if that
clears things up for you?  I'd do it myself but I'm waist-deep in a
different investigation right now and it sounds like you might be able
to do a quick test.

-J.

> 
> 
> 
> Regards,
> 
> --
> *dS
> Diego Sueiro
> 
> /*long live rock 'n roll*/
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]