* Change to vsftpd recipe @ 2013-11-28 17:08 Diego Sueiro 2013-11-28 18:24 ` Joe MacDonald 0 siblings, 1 reply; 7+ messages in thread From: Diego Sueiro @ 2013-11-28 17:08 UTC (permalink / raw) To: openembedded-devel Folks, I realized that when trying to connect via ftp to a target system (which has vsftpd installed) I should had to create the /var/run/vsftpd/empty directory before. Bellow is the patch to create the folder on vsftpd install task: diff --git a/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bbb/meta-networking/recipes-daemons/vsftpd/ vsftpd_3.0.0.bb index 49d5d2a..82466d1 100644 --- a/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb +++ b/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb @@ -70,6 +70,8 @@ do_install() { sed -i "s:/lib/security:${base_libdir}/security:" ${D}${sysconfdir}/pam.d/vsftpd sed -i "s:ftpusers:vsftpd.ftpusers:" ${D}${sysconfdir}/pam.d/vsftpd fi + + install -d ${D}${localstatedir}/run/vsftpd/empty } INITSCRIPT_PACKAGES = "${PN}" Regards, -- *dS Diego Sueiro /*long live rock 'n roll*/ ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: Change to vsftpd recipe 2013-11-28 17:08 Change to vsftpd recipe Diego Sueiro @ 2013-11-28 18:24 ` Joe MacDonald 2013-11-28 18:52 ` Diego Sueiro 0 siblings, 1 reply; 7+ messages in thread From: Joe MacDonald @ 2013-11-28 18:24 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2523 bytes --] Hey Diego, [[oe] Change to vsftpd recipe] On 13.11.28 (Thu 15:08) Diego Sueiro wrote: > Folks, > > I realized that when trying to connect via ftp to a target system (which > has vsftpd installed) I should had to create the /var/run/vsftpd/empty > directory before. > > Bellow is the patch to create the folder on vsftpd install task: > > diff --git a/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bbb/meta-networking/recipes-daemons/vsftpd/ > vsftpd_3.0.0.bb > index 49d5d2a..82466d1 100644 > --- a/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb > +++ b/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb > @@ -70,6 +70,8 @@ do_install() { > sed -i "s:/lib/security:${base_libdir}/security:" > ${D}${sysconfdir}/pam.d/vsftpd > sed -i "s:ftpusers:vsftpd.ftpusers:" ${D}${sysconfdir}/pam.d/vsftpd > fi > + > + install -d ${D}${localstatedir}/run/vsftpd/empty > } > > INITSCRIPT_PACKAGES = "${PN}" Interesting. I just recently merge 1c4921817, which points vsftpd at /var/run/vsftpd/empty, but I haven't actually used vstftp as a server since then so I didn't notice this problem. When I tried re-creating your proposed change I got the expected QA issues: ------------------------------------------------------------------------ ERROR: QA Issue: vsftpd: Files/directories were installed but not shipped /run /run/vsftpd /run/vsftpd/empty ERROR: QA run found fatal errors. Please consider fixing them. ERROR: Function failed: do_package_qa ERROR: Logfile of failure stored in: /home/builds/yocto-mainline/builds/meta-networking-build/tmp/work/core2-poky-linux/vsftpd/3.0.0-r0/temp/log.do_package.26442 ERROR: Task 10 (/home/builds/yocto-mainline/builds/meta-networking-build/../../meta-oe/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb, do_package) failed with exit code '1' ------------------------------------------------------------------------ Care to take a run at reverting 1c4921817 in your tree and see if that clears things up for you? I'd do it myself but I'm waist-deep in a different investigation right now and it sounds like you might be able to do a quick test. -J. > > > > Regards, > > -- > *dS > Diego Sueiro > > /*long live rock 'n roll*/ > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- -Joe MacDonald. :wq [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Change to vsftpd recipe 2013-11-28 18:24 ` Joe MacDonald @ 2013-11-28 18:52 ` Diego Sueiro 2013-11-28 19:02 ` Joe MacDonald 0 siblings, 1 reply; 7+ messages in thread From: Diego Sueiro @ 2013-11-28 18:52 UTC (permalink / raw) To: openembedded-devel On Thu, Nov 28, 2013 at 4:24 PM, Joe MacDonald <joe@deserted.net> wrote: > Care to take a run at reverting 1c4921817 in your tree and see if that > clears things up for you? I'd do it myself but I'm waist-deep in a > different investigation right now and it sounds like you might be able > to do a quick test. > Joe, I did not get this QA error. The installed directory should be "/var/run/vsftpd/empty" and not "/run/vsftpd/empty" as pointed on error message. Did you added "install -d ${D}${localstatedir}/run/vsftpd/empty" on do_install function? Regards, -- *dS Diego Sueiro /*long live rock 'n roll*/ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Change to vsftpd recipe 2013-11-28 18:52 ` Diego Sueiro @ 2013-11-28 19:02 ` Joe MacDonald 2013-11-28 22:02 ` Diego Sueiro 0 siblings, 1 reply; 7+ messages in thread From: Joe MacDonald @ 2013-11-28 19:02 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2247 bytes --] [Re: [oe] Change to vsftpd recipe] On 13.11.28 (Thu 16:52) Diego Sueiro wrote: > On Thu, Nov 28, 2013 at 4:24 PM, Joe MacDonald <joe@deserted.net> wrote: > > > Care to take a run at reverting 1c4921817 in your tree and see if that > > clears things up for you? I'd do it myself but I'm waist-deep in a > > different investigation right now and it sounds like you might be able > > to do a quick test. > > > > Joe, > > I did not get this QA error. > The installed directory should be "/var/run/vsftpd/empty" and not > "/run/vsftpd/empty" as pointed on error message. > Did you added "install -d ${D}${localstatedir}/run/vsftpd/empty" on > do_install function? Yep, here's the modified do_install in its entirety: ------------------------------------------------------------------------ do_install() { install -d ${D}${sbindir} install -d ${D}${mandir}/man8 install -d ${D}${mandir}/man5 oe_runmake 'DESTDIR=${D}' install install -d ${D}${sysconfdir} install -m 600 ${WORKDIR}/vsftpd.conf ${D}${sysconfdir}/vsftpd.conf install -d ${D}${sysconfdir}/init.d/ install -m 755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/vsftpd install -d ${D}/${sysconfdir}/default/volatiles install -m 644 ${WORKDIR}/volatiles.99_vsftpd ${D}/${sysconfdir}/default/volatiles/99_vsftpd install -m 600 ${WORKDIR}/vsftpd.ftpusers ${D}${sysconfdir}/ install -m 600 ${WORKDIR}/vsftpd.user_list ${D}${sysconfdir}/ if ! test -z "${PAMLIB}" ; then install -d ${D}${sysconfdir}/pam.d/ cp ${S}/RedHat/vsftpd.pam ${D}${sysconfdir}/pam.d/vsftpd sed -i "s:/lib/security:${base_libdir}/security:" ${D}${sysconfdir}/pam.d/vsftpd sed -i "s:ftpusers:vsftpd.ftpusers:" ${D}${sysconfdir}/pam.d/vsftpd fi install -d ${D}${localstatedir}/run/vsftpd/empty } ------------------------------------------------------------------------ -J. > > Regards, > > -- > *dS > Diego Sueiro > > /*long live rock 'n roll*/ > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- -Joe MacDonald. :wq [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Change to vsftpd recipe 2013-11-28 19:02 ` Joe MacDonald @ 2013-11-28 22:02 ` Diego Sueiro 2013-11-29 16:06 ` Joe MacDonald 0 siblings, 1 reply; 7+ messages in thread From: Diego Sueiro @ 2013-11-28 22:02 UTC (permalink / raw) To: openembedded-devel Joe, Looking at your commit, you are populating "/var/run/vsftpd/empty" using the file "/etc/default/volatiles/99_vsftpd". This file is used in a sysVinit system. Since I'm using systemd, I believe that "/etc/default/volatiles/" is not scanned by Yocto as you can see here: http://git.yoctoproject.org/cgit.cgi/poky/plain/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh So, I think we need an universal solution. Regards, -- *dS Diego Sueiro /*long live rock 'n roll*/ On Thu, Nov 28, 2013 at 5:02 PM, Joe MacDonald <joe@deserted.net> wrote: > [Re: [oe] Change to vsftpd recipe] On 13.11.28 (Thu 16:52) Diego Sueiro > wrote: > > > On Thu, Nov 28, 2013 at 4:24 PM, Joe MacDonald <joe@deserted.net> wrote: > > > > > Care to take a run at reverting 1c4921817 in your tree and see if that > > > clears things up for you? I'd do it myself but I'm waist-deep in a > > > different investigation right now and it sounds like you might be able > > > to do a quick test. > > > > > > > Joe, > > > > I did not get this QA error. > > The installed directory should be "/var/run/vsftpd/empty" and not > > "/run/vsftpd/empty" as pointed on error message. > > Did you added "install -d ${D}${localstatedir}/run/vsftpd/empty" on > > do_install function? > > Yep, here's the modified do_install in its entirety: > > ------------------------------------------------------------------------ > do_install() { > install -d ${D}${sbindir} > install -d ${D}${mandir}/man8 > install -d ${D}${mandir}/man5 > oe_runmake 'DESTDIR=${D}' install > install -d ${D}${sysconfdir} > install -m 600 ${WORKDIR}/vsftpd.conf ${D}${sysconfdir}/vsftpd.conf > install -d ${D}${sysconfdir}/init.d/ > install -m 755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/vsftpd > install -d ${D}/${sysconfdir}/default/volatiles > install -m 644 ${WORKDIR}/volatiles.99_vsftpd > ${D}/${sysconfdir}/default/volatiles/99_vsftpd > > install -m 600 ${WORKDIR}/vsftpd.ftpusers ${D}${sysconfdir}/ > install -m 600 ${WORKDIR}/vsftpd.user_list ${D}${sysconfdir}/ > if ! test -z "${PAMLIB}" ; then > install -d ${D}${sysconfdir}/pam.d/ > cp ${S}/RedHat/vsftpd.pam ${D}${sysconfdir}/pam.d/vsftpd > sed -i "s:/lib/security:${base_libdir}/security:" > ${D}${sysconfdir}/pam.d/vsftpd > sed -i "s:ftpusers:vsftpd.ftpusers:" ${D}${sysconfdir}/pam.d/vsftpd > fi > install -d ${D}${localstatedir}/run/vsftpd/empty > } > ------------------------------------------------------------------------ > > -J. > > > > > Regards, > > > > -- > > *dS > > Diego Sueiro > > > > /*long live rock 'n roll*/ > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > -- > -Joe MacDonald. > :wq > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Change to vsftpd recipe 2013-11-28 22:02 ` Diego Sueiro @ 2013-11-29 16:06 ` Joe MacDonald 2013-11-29 18:22 ` Diego Sueiro 0 siblings, 1 reply; 7+ messages in thread From: Joe MacDonald @ 2013-11-29 16:06 UTC (permalink / raw) To: Diego Sueiro; +Cc: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 4119 bytes --] [Re: [oe] Change to vsftpd recipe] On 13.11.28 (Thu 20:02) Diego Sueiro wrote: > Joe, > > Looking at your commit, you are populating "/var/run/vsftpd/empty" using > the file "/etc/default/volatiles/99_vsftpd". This file is used in a > sysVinit system. > > Since I'm using systemd, I believe that "/etc/default/volatiles/" is not > scanned by Yocto as you can see here: > http://git.yoctoproject.org/cgit.cgi/poky/plain/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh > > So, I think we need an universal solution. Good point, and now that you mention it, I don't think this is the first time this has come up. Though last time around I think it was relating to automatically cleaning up systemd's service directories on systems that do not use systemd. I'm still engaged in a bit of other debug stuff right now, so if you've got a proposal for this one, please feel free. Otherwise I'll ping you when I get back to look at this. Thanks, -J. > > Regards, > > -- > *dS > Diego Sueiro > > /*long live rock 'n roll*/ > > > On Thu, Nov 28, 2013 at 5:02 PM, Joe MacDonald <joe@deserted.net> wrote: > > > [Re: [oe] Change to vsftpd recipe] On 13.11.28 (Thu 16:52) Diego Sueiro > > wrote: > > > > > On Thu, Nov 28, 2013 at 4:24 PM, Joe MacDonald <joe@deserted.net> wrote: > > > > > > > Care to take a run at reverting 1c4921817 in your tree and see if that > > > > clears things up for you? I'd do it myself but I'm waist-deep in a > > > > different investigation right now and it sounds like you might be able > > > > to do a quick test. > > > > > > > > > > Joe, > > > > > > I did not get this QA error. > > > The installed directory should be "/var/run/vsftpd/empty" and not > > > "/run/vsftpd/empty" as pointed on error message. > > > Did you added "install -d ${D}${localstatedir}/run/vsftpd/empty" on > > > do_install function? > > > > Yep, here's the modified do_install in its entirety: > > > > ------------------------------------------------------------------------ > > do_install() { > > install -d ${D}${sbindir} > > install -d ${D}${mandir}/man8 > > install -d ${D}${mandir}/man5 > > oe_runmake 'DESTDIR=${D}' install > > install -d ${D}${sysconfdir} > > install -m 600 ${WORKDIR}/vsftpd.conf ${D}${sysconfdir}/vsftpd.conf > > install -d ${D}${sysconfdir}/init.d/ > > install -m 755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/vsftpd > > install -d ${D}/${sysconfdir}/default/volatiles > > install -m 644 ${WORKDIR}/volatiles.99_vsftpd > > ${D}/${sysconfdir}/default/volatiles/99_vsftpd > > > > install -m 600 ${WORKDIR}/vsftpd.ftpusers ${D}${sysconfdir}/ > > install -m 600 ${WORKDIR}/vsftpd.user_list ${D}${sysconfdir}/ > > if ! test -z "${PAMLIB}" ; then > > install -d ${D}${sysconfdir}/pam.d/ > > cp ${S}/RedHat/vsftpd.pam ${D}${sysconfdir}/pam.d/vsftpd > > sed -i "s:/lib/security:${base_libdir}/security:" > > ${D}${sysconfdir}/pam.d/vsftpd > > sed -i "s:ftpusers:vsftpd.ftpusers:" ${D}${sysconfdir}/pam.d/vsftpd > > fi > > install -d ${D}${localstatedir}/run/vsftpd/empty > > } > > ------------------------------------------------------------------------ > > > > -J. > > > > > > > > Regards, > > > > > > -- > > > *dS > > > Diego Sueiro > > > > > > /*long live rock 'n roll*/ > > > _______________________________________________ > > > Openembedded-devel mailing list > > > Openembedded-devel@lists.openembedded.org > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > > -- > > -Joe MacDonald. > > :wq > > > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- -Joe MacDonald. :wq [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Change to vsftpd recipe 2013-11-29 16:06 ` Joe MacDonald @ 2013-11-29 18:22 ` Diego Sueiro 0 siblings, 0 replies; 7+ messages in thread From: Diego Sueiro @ 2013-11-29 18:22 UTC (permalink / raw) To: Joe MacDonald; +Cc: openembedded-devel On Fri, Nov 29, 2013 at 2:06 PM, Joe MacDonald <joe@deserted.net> wrote: > I'm still engaged in a bit of other debug stuff right now, so if you've > got a proposal for this one, please feel free. Otherwise I'll ping you > when I get back to look at this. > I thought my patch could fix it, but it is not working for you. Regards, -- *dS Diego Sueiro /*long live rock 'n roll*/ ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-11-29 18:22 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-11-28 17:08 Change to vsftpd recipe Diego Sueiro 2013-11-28 18:24 ` Joe MacDonald 2013-11-28 18:52 ` Diego Sueiro 2013-11-28 19:02 ` Joe MacDonald 2013-11-28 22:02 ` Diego Sueiro 2013-11-29 16:06 ` Joe MacDonald 2013-11-29 18:22 ` Diego Sueiro
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.