From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>,
David Cohen <david.a.cohen@linux.intel.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] gpio: drop users of irq_set_chip_and_handler_name()
Date: Fri, 29 Nov 2013 12:20:51 +0200 [thread overview]
Message-ID: <20131129102050.GF2281@intel.com> (raw)
In-Reply-To: <1385472771-26681-1-git-send-email-linus.walleij@linaro.org>
On Tue, Nov 26, 2013 at 02:32:51PM +0100, Linus Walleij wrote:
> Switch all users of irq_set_chip_and_handler_name() to simply
> use irq_set_chip_and_handler(), all just provide a boilerplate
> name like "demux" or "mux" - a fact which is anyway obvious
> from the hwirq number from the irqdomain now present in e.g.
> /proc/interrupts.
>
> Cc: David Cohen <david.a.cohen@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> I'm challenging all users of this function to make an argument
> for it to stay in, and suspecting that this is mostly a copy
> and paste artifact...
I think so also. To me the patch makes perfect sense and it didn't break
anything on lynxpoint.
For gpio-lynxpoint:
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2013-11-29 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 13:32 [PATCH] gpio: drop users of irq_set_chip_and_handler_name() Linus Walleij
2013-11-29 10:20 ` Mika Westerberg [this message]
2013-12-02 18:27 ` David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129102050.GF2281@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=dan.carpenter@oracle.com \
--cc=david.a.cohen@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.