[PATCH] ASoC: wm_adsp: Stop region iteration when the desired region is found

[PATCH] ASoC: wm_adsp: Stop region iteration when the desired region is found

[Charles Keepax]

When locating the memory region relating to a coefficient block written
through a bin file we keep processing the list of regions even after we
have found the region we require. This patch adds a break, so we don't
process redundant list items.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/wm_adsp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index 46ec0e9..b42f9af 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -1286,6 +1286,7 @@ static int wm_adsp_load_coeff(struct wm_adsp *dsp)
 					reg = wm_adsp_region_to_reg(mem,
 								    reg);
 					reg += offset;
+					break;
 				}
 			}
 
-- 
1.7.2.5

Re: [PATCH] ASoC: wm_adsp: Stop region iteration when the desired region is found

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 449 bytes --]

On Thu, Nov 28, 2013 at 04:37:51PM +0000, Charles Keepax wrote:
> When locating the memory region relating to a coefficient block written
> through a bin file we keep processing the list of regions even after we
> have found the region we require. This patch adds a break, so we don't
> process redundant list items.

Applied, thanks.  I didn't look but does the same issue exist in the
main firmware load, it's probably following the same pattern?

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: wm_adsp: Stop region iteration when the desired region is found

[Charles Keepax]

On Thu, Nov 28, 2013 at 06:19:43PM +0000, Mark Brown wrote:
> On Thu, Nov 28, 2013 at 04:37:51PM +0000, Charles Keepax wrote:
> > When locating the memory region relating to a coefficient block written
> > through a bin file we keep processing the list of regions even after we
> > have found the region we require. This patch adds a break, so we don't
> > process redundant list items.
> 
> Applied, thanks.  I didn't look but does the same issue exist in the
> main firmware load, it's probably following the same pattern?

I had a look, no similar issues in the main firmware load.

Thanks,
Charles