From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Michał Mirosław" <mirqus@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Brian Lilly" <brian@crystalfontz.com>,
linux-iio@vger.kernel.org, Brent-Crosby <brent@crystalfontz.com>,
"Jim Wall" <jimwall@q.com>,
"Hector Palacios" <hector.palacios@digi.com>,
"Alexandre Belloni" <alexandre.belloni@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] iio: mxs-lradc: compute temperature from channel 8 and 9
Date: Sat, 30 Nov 2013 14:37:13 +0100 [thread overview]
Message-ID: <20131130133713.GA3002@lukather> (raw)
In-Reply-To: <5299DA42.2030508@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]
On Sat, Nov 30, 2013 at 12:29:54PM +0000, Jonathan Cameron wrote:
> On 11/30/13 12:27, Jonathan Cameron wrote:
> > On 11/30/13 12:24, Michał Mirosław wrote:
> >> 2013/11/30 Jonathan Cameron <jic23@kernel.org>:
> >>> On 11/30/13 12:15, Jonathan Cameron wrote:
> >>>> On 11/19/13 10:36, Maxime Ripard wrote:
> >>>>> From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >>>>>
> >>>>> The mxs LRADC is able to read an internal die temperature sensor. The
> >>>>> temperature has to be calculated from the value read on channel 8 and channel 9.
> >>>>> To be able to expose the result to hwmon, implement iio channel 8 as
> >>>>> (channel 9 - channel 8). Then, implement IIO_CHAN_INFO_SCALE and
> >>>>> IIO_CHAN_INFO_OFFSET so that it can be processed by hwmon through the in kernel
> >>>>> provider/consumer mechanism.
> >>>>>
> >>>>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >>>>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >>>>> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
> >>>> As this is still in staging, I think we can get away with the resulting
> >>>> ABI change from this patch.
> >>>>
> >>>> Applied to the togreg branch of iio.git
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Jonathan
> >>> Having said that, there is an odd bit inline that I've just dropped whilst
> >>> applying the patch. Shout if I've done this wrong.
> Given issues below and the substantial changes that have occured in this driver, could
> your please rebase it and repost.
I will.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iio: mxs-lradc: compute temperature from channel 8 and 9
Date: Sat, 30 Nov 2013 14:37:13 +0100 [thread overview]
Message-ID: <20131130133713.GA3002@lukather> (raw)
In-Reply-To: <5299DA42.2030508@kernel.org>
On Sat, Nov 30, 2013 at 12:29:54PM +0000, Jonathan Cameron wrote:
> On 11/30/13 12:27, Jonathan Cameron wrote:
> > On 11/30/13 12:24, Micha? Miros?aw wrote:
> >> 2013/11/30 Jonathan Cameron <jic23@kernel.org>:
> >>> On 11/30/13 12:15, Jonathan Cameron wrote:
> >>>> On 11/19/13 10:36, Maxime Ripard wrote:
> >>>>> From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >>>>>
> >>>>> The mxs LRADC is able to read an internal die temperature sensor. The
> >>>>> temperature has to be calculated from the value read on channel 8 and channel 9.
> >>>>> To be able to expose the result to hwmon, implement iio channel 8 as
> >>>>> (channel 9 - channel 8). Then, implement IIO_CHAN_INFO_SCALE and
> >>>>> IIO_CHAN_INFO_OFFSET so that it can be processed by hwmon through the in kernel
> >>>>> provider/consumer mechanism.
> >>>>>
> >>>>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >>>>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >>>>> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
> >>>> As this is still in staging, I think we can get away with the resulting
> >>>> ABI change from this patch.
> >>>>
> >>>> Applied to the togreg branch of iio.git
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Jonathan
> >>> Having said that, there is an odd bit inline that I've just dropped whilst
> >>> applying the patch. Shout if I've done this wrong.
> Given issues below and the substantial changes that have occured in this driver, could
> your please rebase it and repost.
I will.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131130/8f5999b1/attachment.sig>
next prev parent reply other threads:[~2013-11-30 13:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 10:36 [PATCH] iio: mxs-lradc: compute temperature from channel 8 and 9 Maxime Ripard
2013-11-19 10:36 ` Maxime Ripard
2013-11-19 10:51 ` Peter Meerwald
2013-11-19 10:51 ` Peter Meerwald
2013-11-19 11:31 ` Lars-Peter Clausen
2013-11-19 11:31 ` Lars-Peter Clausen
2013-11-30 12:15 ` Jonathan Cameron
2013-11-30 12:15 ` Jonathan Cameron
2013-11-30 12:19 ` Jonathan Cameron
2013-11-30 12:19 ` Jonathan Cameron
2013-11-30 12:24 ` Michał Mirosław
2013-11-30 12:24 ` Michał Mirosław
2013-11-30 12:27 ` Jonathan Cameron
2013-11-30 12:27 ` Jonathan Cameron
2013-11-30 12:29 ` Jonathan Cameron
2013-11-30 12:29 ` Jonathan Cameron
2013-11-30 13:37 ` Maxime Ripard [this message]
2013-11-30 13:37 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131130133713.GA3002@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=brent@crystalfontz.com \
--cc=brian@crystalfontz.com \
--cc=hector.palacios@digi.com \
--cc=jic23@kernel.org \
--cc=jimwall@q.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=mirqus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.