From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Stephane Eranian <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"mingo@elte.hu" <mingo@elte.hu>, David Ahern <dsahern@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [BUG] perf stat: explicit grouping yields unexpected results
Date: Mon, 2 Dec 2013 07:23:29 -0800 [thread overview]
Message-ID: <20131202152329.GD22695@tassilo.jf.intel.com> (raw)
In-Reply-To: <20131129133340.GA25751@krava.brq.redhat.com>
> Something like below? user space supply buffer for error string.
That would work, although I was thinking of making it a more
generic mechanism (store it into task_struct, have a extra
syscall to retrieve)
-Andi
>
> jirka
>
>
> ---
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index e1802d6..a827870 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -331,8 +331,8 @@ struct perf_event_attr {
> */
> __u32 sample_stack_user;
>
> - /* Align to u64. */
> - __u32 __reserved_2;
> + __u32 errstr_size;
> + char *errstr;
> };
>
> #define perf_flags(attr) (*(&(attr)->read_format + 1))
>
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2013-12-02 15:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 20:50 [BUG] perf stat: explicit grouping yields unexpected results Stephane Eranian
2013-11-15 6:34 ` Ingo Molnar
2013-11-15 9:24 ` Stephane Eranian
2013-11-15 10:34 ` Ingo Molnar
2013-11-15 10:41 ` Stephane Eranian
2013-11-15 10:50 ` Peter Zijlstra
2013-11-15 11:52 ` Peter Zijlstra
2013-11-15 11:58 ` Stephane Eranian
2013-11-17 3:41 ` Andi Kleen
2013-11-29 13:33 ` Jiri Olsa
2013-11-29 13:43 ` Stephane Eranian
2013-11-29 13:52 ` Jiri Olsa
2013-11-29 14:01 ` Stephane Eranian
2013-12-02 15:23 ` Andi Kleen [this message]
2013-12-03 2:52 ` Stephane Eranian
2013-12-03 23:44 ` Andi Kleen
2013-11-15 10:05 ` Peter Zijlstra
2013-11-15 10:13 ` Stephane Eranian
2013-11-15 10:49 ` Peter Zijlstra
2013-11-15 15:08 ` Vince Weaver
2013-11-15 22:52 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202152329.GD22695@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.