From: Andi Kleen <andi@firstfloor.org>
To: Stephane Eranian <eranian@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"mingo\@elte.hu" <mingo@elte.hu>, David Ahern <dsahern@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [BUG] perf stat: explicit grouping yields unexpected results
Date: Tue, 03 Dec 2013 15:44:38 -0800 [thread overview]
Message-ID: <87r49tcxeh.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <CABPqkBQuY0VDKVhFGscAtK2vZjaSJQBCEtVCk4km-bKW85Zx-A@mail.gmail.com> (Stephane Eranian's message of "Tue, 3 Dec 2013 03:52:13 +0100")
Stephane Eranian <eranian@google.com> writes:
>>
> I don't understand why this need to be so complicated.
> Maybe just change the error code in case of group
> overcommitment? That way, the tool could distinguish
> and report the appropriate error message.
The existing errno is an ABI.
Also that would handle this case, but there are a bazillion other
failure cases in perf. And we can't invent new errnos for all of them.
A string error interface would cover it all.
Usually when something strange like this happens in perf I have to apply
this patch
https://lkml.org/lkml/2013/3/8/432
and use ftrace to trace it down.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2013-12-03 23:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 20:50 [BUG] perf stat: explicit grouping yields unexpected results Stephane Eranian
2013-11-15 6:34 ` Ingo Molnar
2013-11-15 9:24 ` Stephane Eranian
2013-11-15 10:34 ` Ingo Molnar
2013-11-15 10:41 ` Stephane Eranian
2013-11-15 10:50 ` Peter Zijlstra
2013-11-15 11:52 ` Peter Zijlstra
2013-11-15 11:58 ` Stephane Eranian
2013-11-17 3:41 ` Andi Kleen
2013-11-29 13:33 ` Jiri Olsa
2013-11-29 13:43 ` Stephane Eranian
2013-11-29 13:52 ` Jiri Olsa
2013-11-29 14:01 ` Stephane Eranian
2013-12-02 15:23 ` Andi Kleen
2013-12-03 2:52 ` Stephane Eranian
2013-12-03 23:44 ` Andi Kleen [this message]
2013-11-15 10:05 ` Peter Zijlstra
2013-11-15 10:13 ` Stephane Eranian
2013-11-15 10:49 ` Peter Zijlstra
2013-11-15 15:08 ` Vince Weaver
2013-11-15 22:52 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r49tcxeh.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor.org \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.