From: Helge Deller <deller@gmx.de>
To: linux-nfs@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-parisc@vger.kernel.org
Subject: [PATCH] nfs: fix do_div() warning by instead using sector_div()
Date: Mon, 2 Dec 2013 19:59:31 +0100 [thread overview]
Message-ID: <20131202185931.GA1992@ls3530.box> (raw)
When compiling a 32bit kernel with CONFIG_LBDAF=n the compiler complains like
shown below. Fix this warning by instead using sector_div() which is provided
by the kernel.h header file.
fs/nfs/blocklayout/extents.c: In function ‘normalize’:
include/asm-generic/div64.h:43:28: warning: comparison of distinct pointer types lacks a cast [enabled by default]
fs/nfs/blocklayout/extents.c:47:13: note: in expansion of macro ‘do_div’
nfs/blocklayout/extents.c:47:2: warning: right shift count >= width of type [enabled by default]
fs/nfs/blocklayout/extents.c:47:2: warning: passing argument 1 of ‘__div64_32’ from incompatible pointer type [enabled by default]
include/asm-generic/div64.h:35:17: note: expected ‘uint64_t *’ but argument is of type ‘sector_t *’
extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/fs/nfs/blocklayout/extents.c b/fs/nfs/blocklayout/extents.c
index 9c3e117..4d01614 100644
--- a/fs/nfs/blocklayout/extents.c
+++ b/fs/nfs/blocklayout/extents.c
@@ -44,7 +44,7 @@
static inline sector_t normalize(sector_t s, int base)
{
sector_t tmp = s; /* Since do_div modifies its argument */
- return s - do_div(tmp, base);
+ return s - sector_div(tmp, base);
}
static inline sector_t normalize_up(sector_t s, int base)
WARNING: multiple messages have this Message-ID (diff)
From: Helge Deller <deller@gmx.de>
To: linux-nfs@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-parisc@vger.kernel.org
Subject: [PATCH] nfs: fix do_div() warning by instead using sector_div()
Date: Mon, 2 Dec 2013 19:59:31 +0100 [thread overview]
Message-ID: <20131202185931.GA1992@ls3530.box> (raw)
When compiling a 32bit kernel with CONFIG_LBDAF=3Dn the compiler compla=
ins like
shown below. Fix this warning by instead using sector_div() which is p=
rovided
by the kernel.h header file.
=20
fs/nfs/blocklayout/extents.c: In function =E2=80=98normalize=E2=80=99:
include/asm-generic/div64.h:43:28: warning: comparison of distinct poin=
ter types lacks a cast [enabled by default]
fs/nfs/blocklayout/extents.c:47:13: note: in expansion of macro =E2=80=98=
do_div=E2=80=99
nfs/blocklayout/extents.c:47:2: warning: right shift count >=3D width o=
f type [enabled by default]
fs/nfs/blocklayout/extents.c:47:2: warning: passing argument 1 of =E2=80=
=98__div64_32=E2=80=99 from incompatible pointer type [enabled by defau=
lt]
include/asm-generic/div64.h:35:17: note: expected =E2=80=98uint64_t *=E2=
=80=99 but argument is of type =E2=80=98sector_t *=E2=80=99
extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/fs/nfs/blocklayout/extents.c b/fs/nfs/blocklayout/extents.=
c
index 9c3e117..4d01614 100644
--- a/fs/nfs/blocklayout/extents.c
+++ b/fs/nfs/blocklayout/extents.c
@@ -44,7 +44,7 @@
static inline sector_t normalize(sector_t s, int base)
{
sector_t tmp =3D s; /* Since do_div modifies its argument */
- return s - do_div(tmp, base);
+ return s - sector_div(tmp, base);
}
=20
static inline sector_t normalize_up(sector_t s, int base)
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc"=
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2013-12-02 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 18:59 Helge Deller [this message]
2013-12-02 18:59 ` [PATCH] nfs: fix do_div() warning by instead using sector_div() Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202185931.GA1992@ls3530.box \
--to=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.