From: Greg KH <greg@kroah.com>
To: Christoph Lameter <cl@linux.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Sasha Levin <sasha.levin@oracle.com>,
Patrick McHardy <kaber@trash.net>,
kadlec@blackhole.kfki.hu, "David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: netfilter: active obj WARN when cleaning up
Date: Mon, 2 Dec 2013 11:08:14 -0800 [thread overview]
Message-ID: <20131202190814.GA2267@kroah.com> (raw)
In-Reply-To: <00000142b4aeca89-186fc179-92b8-492f-956c-38a7c196d187-000000@email.amazonses.com>
On Mon, Dec 02, 2013 at 07:00:23PM +0000, Christoph Lameter wrote:
> On Mon, 2 Dec 2013, Greg KH wrote:
>
> > >
> > > We need our own reference count. So we just have to defer the
> > > release of the kmem_cache struct until the ->release callback is
> > > triggered. The put of the embedded kobject must be the last action on the
> > > kmem_cache structure which will then trigger release and that will
> > > trigger the kmem_cache_free().
> > >
> >
> > Ok, that sounds reasonable, or you can just create a "tiny" structure
> > for the kobject that has a pointer back to your kmem_cache structure
> > that you can then reference from the show/store functions. Either is
> > fine with me.
>
> Problem is that the release field is only available if
> CONFIG_DEBUG_KOBJECT_RELEASE is enabled. Without the callback I cannot
> tell when it is legit to release the kobject structure unless I keep
> scanning it once in awhile.
No, the release callback is in the kobj_type, not the kobject itself.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Christoph Lameter <cl@linux.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Sasha Levin <sasha.levin@oracle.com>,
Patrick McHardy <kaber@trash.net>,
kadlec@blackhole.kfki.hu, "David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: netfilter: active obj WARN when cleaning up
Date: Mon, 2 Dec 2013 11:08:14 -0800 [thread overview]
Message-ID: <20131202190814.GA2267@kroah.com> (raw)
In-Reply-To: <00000142b4aeca89-186fc179-92b8-492f-956c-38a7c196d187-000000@email.amazonses.com>
On Mon, Dec 02, 2013 at 07:00:23PM +0000, Christoph Lameter wrote:
> On Mon, 2 Dec 2013, Greg KH wrote:
>
> > >
> > > We need our own reference count. So we just have to defer the
> > > release of the kmem_cache struct until the ->release callback is
> > > triggered. The put of the embedded kobject must be the last action on the
> > > kmem_cache structure which will then trigger release and that will
> > > trigger the kmem_cache_free().
> > >
> >
> > Ok, that sounds reasonable, or you can just create a "tiny" structure
> > for the kobject that has a pointer back to your kmem_cache structure
> > that you can then reference from the show/store functions. Either is
> > fine with me.
>
> Problem is that the release field is only available if
> CONFIG_DEBUG_KOBJECT_RELEASE is enabled. Without the callback I cannot
> tell when it is legit to release the kobject structure unless I keep
> scanning it once in awhile.
No, the release callback is in the kobj_type, not the kobject itself.
next prev parent reply other threads:[~2013-12-02 19:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-07 13:10 netfilter: active obj WARN when cleaning up Sasha Levin
2013-11-26 19:11 ` Sasha Levin
2013-11-26 23:07 ` Pablo Neira Ayuso
2013-11-26 23:13 ` Sasha Levin
2013-11-27 10:45 ` Thomas Gleixner
2013-11-27 10:45 ` Thomas Gleixner
2013-11-27 11:39 ` Russell King - ARM Linux
2013-11-27 11:39 ` Russell King - ARM Linux
2013-11-27 13:29 ` Thomas Gleixner
2013-11-27 13:29 ` Thomas Gleixner
2013-11-27 13:32 ` Russell King - ARM Linux
2013-11-27 13:32 ` Russell King - ARM Linux
2013-11-27 13:40 ` Russell King - ARM Linux
2013-11-27 13:40 ` Russell King - ARM Linux
2013-11-27 13:44 ` Thomas Gleixner
2013-11-27 13:44 ` Thomas Gleixner
2013-11-27 23:34 ` Greg KH
2013-11-27 23:34 ` Greg KH
2013-12-02 16:33 ` Christoph Lameter
2013-12-02 16:33 ` Christoph Lameter
2013-12-02 16:40 ` Greg KH
2013-12-02 16:40 ` Greg KH
2013-12-02 17:18 ` Christoph Lameter
2013-12-02 17:18 ` Christoph Lameter
2013-12-02 17:26 ` Greg KH
2013-12-02 17:26 ` Greg KH
2013-12-02 19:00 ` Christoph Lameter
2013-12-02 19:00 ` Christoph Lameter
2013-12-02 19:08 ` Greg KH [this message]
2013-12-02 19:08 ` Greg KH
2013-12-02 19:41 ` Christoph Lameter
2013-12-02 19:41 ` Christoph Lameter
2013-12-02 21:22 ` Greg KH
2013-12-02 21:22 ` Greg KH
2013-12-02 21:55 ` Christoph Lameter
2013-12-02 21:55 ` Christoph Lameter
2013-12-02 22:22 ` Greg KH
2013-12-02 22:22 ` Greg KH
2013-12-03 15:22 ` Christoph Lameter
2013-12-03 15:22 ` Christoph Lameter
2013-12-17 19:53 ` Sasha Levin
2013-12-17 19:53 ` Sasha Levin
2013-12-17 20:37 ` Christoph Lameter
2013-12-17 20:37 ` Christoph Lameter
2013-12-17 22:09 ` Sasha Levin
2013-12-17 22:09 ` Sasha Levin
2013-12-17 22:09 ` Sasha Levin
2013-12-17 22:01 ` Thomas Gleixner
2013-12-17 22:01 ` Thomas Gleixner
2013-12-19 12:12 ` Bart Van Assche
2013-12-19 12:12 ` Bart Van Assche
2013-12-19 14:20 ` Bart Van Assche
2013-12-19 14:20 ` Bart Van Assche
2013-11-27 13:41 ` Thomas Gleixner
2013-11-27 13:41 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202190814.GA2267@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sasha.levin@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.