All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Wanpeng Li <liwanp@linux.vnet.ibm.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] slab: make more slab management structure off the slab
Date: Tue, 3 Dec 2013 11:13:08 +0900	[thread overview]
Message-ID: <20131203021308.GE31168@lge.com> (raw)
In-Reply-To: <00000142b3d18433-eacdc401-434f-42e1-8988-686bd15a3e20-000000@email.amazonses.com>

On Mon, Dec 02, 2013 at 02:58:41PM +0000, Christoph Lameter wrote:
> On Mon, 2 Dec 2013, Joonsoo Kim wrote:
> 
> > Now, the size of the freelist for the slab management diminish,
> > so that the on-slab management structure can waste large space
> > if the object of the slab is large.
> 
> Hmmm.. That is confusing to me. "Since the size of the freelist has shrunk
> significantly we have to adjust the heuristic for making the on/off slab
> placement decision"?
> 
> Make this clearer.

Yes. your understanding is right.
I will replace above line with yours.

Thanks.

> 
> Acked-by: Christoph Lameter <cl@linux.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Wanpeng Li <liwanp@linux.vnet.ibm.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] slab: make more slab management structure off the slab
Date: Tue, 3 Dec 2013 11:13:08 +0900	[thread overview]
Message-ID: <20131203021308.GE31168@lge.com> (raw)
In-Reply-To: <00000142b3d18433-eacdc401-434f-42e1-8988-686bd15a3e20-000000@email.amazonses.com>

On Mon, Dec 02, 2013 at 02:58:41PM +0000, Christoph Lameter wrote:
> On Mon, 2 Dec 2013, Joonsoo Kim wrote:
> 
> > Now, the size of the freelist for the slab management diminish,
> > so that the on-slab management structure can waste large space
> > if the object of the slab is large.
> 
> Hmmm.. That is confusing to me. "Since the size of the freelist has shrunk
> significantly we have to adjust the heuristic for making the on/off slab
> placement decision"?
> 
> Make this clearer.

Yes. your understanding is right.
I will replace above line with yours.

Thanks.

> 
> Acked-by: Christoph Lameter <cl@linux.com>


  reply	other threads:[~2013-12-03  2:10 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02  8:49 [PATCH v3 0/5] slab: implement byte sized indexes for the freelist of a slab Joonsoo Kim
2013-12-02  8:49 ` Joonsoo Kim
2013-12-02  8:49 ` [PATCH v3 1/5] slab: factor out calculate nr objects in cache_estimate Joonsoo Kim
2013-12-02  8:49   ` Joonsoo Kim
2014-01-15  4:54   ` David Rientjes
2014-01-15  4:54     ` David Rientjes
2013-12-02  8:49 ` [PATCH v3 2/5] slab: introduce helper functions to get/set free object Joonsoo Kim
2013-12-02  8:49   ` Joonsoo Kim
2014-01-15  4:57   ` David Rientjes
2014-01-15  4:57     ` David Rientjes
2013-12-02  8:49 ` [PATCH v3 3/5] slab: restrict the number of objects in a slab Joonsoo Kim
2013-12-02  8:49   ` Joonsoo Kim
2013-12-02 19:45   ` Christoph Lameter
2013-12-02 19:45     ` Christoph Lameter
2014-01-15  5:05   ` David Rientjes
2014-01-15  5:05     ` David Rientjes
2013-12-02  8:49 ` [PATCH v3 4/5] slab: introduce byte sized index for the freelist of " Joonsoo Kim
2013-12-02  8:49   ` Joonsoo Kim
2013-12-03  2:25   ` Joonsoo Kim
2013-12-03  2:25     ` Joonsoo Kim
2013-12-03 15:24     ` Christoph Lameter
2013-12-03 15:24       ` Christoph Lameter
2014-01-15  5:08   ` David Rientjes
2014-01-15  5:08     ` David Rientjes
2013-12-02  8:49 ` [PATCH v3 5/5] slab: make more slab management structure off the slab Joonsoo Kim
2013-12-02  8:49   ` Joonsoo Kim
2013-12-02 14:58   ` Christoph Lameter
2013-12-02 14:58     ` Christoph Lameter
2013-12-03  2:13     ` Joonsoo Kim [this message]
2013-12-03  2:13       ` Joonsoo Kim
2013-12-13  7:03       ` Joonsoo Kim
2013-12-13  7:03         ` Joonsoo Kim
2014-02-08 10:17         ` Pekka Enberg
2014-02-08 10:17           ` Pekka Enberg
2014-01-15  5:09   ` David Rientjes
2014-01-15  5:09     ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131203021308.GE31168@lge.com \
    --to=iamjoonsoo.kim@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liwanp@linux.vnet.ibm.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.