From: Christoph Hellwig <hch@infradead.org>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
xfs@oss.sgi.com,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] fs: fix iversion handling
Date: Tue, 3 Dec 2013 01:39:44 -0800 [thread overview]
Message-ID: <20131203093944.GA4906@infradead.org> (raw)
In-Reply-To: <8E57B1B6-E650-4A1A-AF78-0A9C9593A3E3@dilger.ca>
On Mon, Dec 02, 2013 at 03:05:07PM -0700, Andreas Dilger wrote:
> >> */
> >> - if (newsize != oldsize && (!(mask & (ATTR_CTIME | ATTR_MTIME))))
> >> - inode->i_ctime = inode->i_mtime = current_fs_time(inode->i_sb);
> >> + if (newsize != oldsize) {
> >> + inode_inc_iversion(inode);
>
> Should this be conditional on IS_I_VERSION(inode)?
btrfs sets MS_I_VERSION unconditionally.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
xfs@oss.sgi.com
Subject: Re: [PATCH] fs: fix iversion handling
Date: Tue, 3 Dec 2013 01:39:44 -0800 [thread overview]
Message-ID: <20131203093944.GA4906@infradead.org> (raw)
In-Reply-To: <8E57B1B6-E650-4A1A-AF78-0A9C9593A3E3@dilger.ca>
On Mon, Dec 02, 2013 at 03:05:07PM -0700, Andreas Dilger wrote:
> >> */
> >> - if (newsize != oldsize && (!(mask & (ATTR_CTIME | ATTR_MTIME))))
> >> - inode->i_ctime = inode->i_mtime = current_fs_time(inode->i_sb);
> >> + if (newsize != oldsize) {
> >> + inode_inc_iversion(inode);
>
> Should this be conditional on IS_I_VERSION(inode)?
btrfs sets MS_I_VERSION unconditionally.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-03 9:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 15:17 [PATCH] fs: fix iversion handling Christoph Hellwig
2013-11-19 15:17 ` Christoph Hellwig
2013-12-02 17:36 ` Christoph Hellwig
2013-12-02 17:36 ` Christoph Hellwig
2013-12-02 22:05 ` Andreas Dilger
2013-12-03 9:39 ` Christoph Hellwig [this message]
2013-12-03 9:39 ` Christoph Hellwig
2013-12-02 22:11 ` Jan Kara
2013-12-02 22:11 ` Jan Kara
2013-12-03 9:35 ` Boaz Harrosh
2013-12-03 9:35 ` Boaz Harrosh
2013-12-03 9:35 ` Boaz Harrosh
2013-12-03 9:45 ` Christoph Hellwig
2013-12-03 9:45 ` Christoph Hellwig
2013-12-03 10:40 ` Boaz Harrosh
2013-12-03 10:40 ` Boaz Harrosh
2013-12-03 10:40 ` Boaz Harrosh
2013-12-03 20:54 ` J. Bruce Fields
2013-12-03 20:54 ` J. Bruce Fields
2013-12-03 20:54 ` J. Bruce Fields
2013-12-02 23:25 ` Dave Chinner
2013-12-02 23:25 ` Dave Chinner
2013-12-04 21:25 ` Ben Myers
2013-12-04 22:01 ` Chris Mason
2013-12-05 22:37 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203093944.GA4906@infradead.org \
--to=hch@infradead.org \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.