From: Marek Vasut <marex@denx.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Fabio Estevam <fabio.estevam@freescale.com>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: mxs: crypto: Remove the old DCP driver
Date: Tue, 3 Dec 2013 13:28:20 +0100 [thread overview]
Message-ID: <201312031328.20860.marex@denx.de> (raw)
In-Reply-To: <20131203110731.GE13726@S2101-09.ap.freescale.net>
Dear Shawn Guo,
> On Sun, Dec 01, 2013 at 10:20:20PM +0100, Marek Vasut wrote:
> > Remove the old DCP driver as it had multiple severe issues. The driver
> > will be replaced by a more robust implementation. Here is a short list
> > of problems with this driver:
> >
> > 1) It only supports AES_CBC
> >
> > 2) The driver was apparently never ran behind anyone working with MXS. ie.:
> > -> Restarting the DCP block is not done via mxs_reset_block()
> > -> The DT name is not "fsl,dcp" or "fsl,mxs-dcp" as other MXS drivers
> >
> > 3) Introduces new ad-hoc IOCTLs
> > 4) The IRQ handler can't use usual completion() in the driver because
> > that'd
> >
> > trigger "scheduling while atomic" oops, yes?
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
>
> Please drop "ARM: mxs: " from patch subject, since it's not a patch
> touching arch/arm/mach-mxs anyhow. It's there confusing people.
>
> Shawn
Removed. Will gather more feedback and repost V2.
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ARM: mxs: crypto: Remove the old DCP driver
Date: Tue, 3 Dec 2013 13:28:20 +0100 [thread overview]
Message-ID: <201312031328.20860.marex@denx.de> (raw)
In-Reply-To: <20131203110731.GE13726@S2101-09.ap.freescale.net>
Dear Shawn Guo,
> On Sun, Dec 01, 2013 at 10:20:20PM +0100, Marek Vasut wrote:
> > Remove the old DCP driver as it had multiple severe issues. The driver
> > will be replaced by a more robust implementation. Here is a short list
> > of problems with this driver:
> >
> > 1) It only supports AES_CBC
> >
> > 2) The driver was apparently never ran behind anyone working with MXS. ie.:
> > -> Restarting the DCP block is not done via mxs_reset_block()
> > -> The DT name is not "fsl,dcp" or "fsl,mxs-dcp" as other MXS drivers
> >
> > 3) Introduces new ad-hoc IOCTLs
> > 4) The IRQ handler can't use usual completion() in the driver because
> > that'd
> >
> > trigger "scheduling while atomic" oops, yes?
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
>
> Please drop "ARM: mxs: " from patch subject, since it's not a patch
> touching arch/arm/mach-mxs anyhow. It's there confusing people.
>
> Shawn
Removed. Will gather more feedback and repost V2.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-12-03 13:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 21:20 [PATCH 1/5] crypto: Fully restore ahash request before completing Marek Vasut
2013-12-01 21:20 ` Marek Vasut
2013-12-01 21:20 ` [PATCH 2/5] ARM: mxs: crypto: Remove the old DCP driver Marek Vasut
2013-12-01 21:20 ` Marek Vasut
2013-12-03 11:07 ` Shawn Guo
2013-12-03 11:07 ` Shawn Guo
2013-12-03 12:28 ` Marek Vasut [this message]
2013-12-03 12:28 ` Marek Vasut
2013-12-01 21:20 ` [PATCH V2 3/5] ARM: mxs: crypto: Add Freescale MXS " Marek Vasut
2013-12-01 21:20 ` Marek Vasut
2013-12-03 11:10 ` Shawn Guo
2013-12-03 11:10 ` Shawn Guo
2013-12-03 11:10 ` Shawn Guo
2013-12-10 19:19 ` Marek Vasut
2013-12-10 19:19 ` Marek Vasut
2013-12-01 21:20 ` [PATCH 4/5] ARM: mxs: dts: Enable DCP for MXS Marek Vasut
2013-12-01 21:20 ` Marek Vasut
2013-12-01 21:20 ` [PATCH 5/5] crypto: Sort drivers/crypto/Makefile Marek Vasut
2013-12-01 21:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312031328.20860.marex@denx.de \
--to=marex@denx.de \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.