* [PATCH] ASoC: wm8731: fix dsp mode configuration
@ 2013-12-03 10:04 ` Bo Shen
0 siblings, 0 replies; 9+ messages in thread
From: Bo Shen @ 2013-12-03 10:04 UTC (permalink / raw)
To: broonie; +Cc: Bo Shen, alsa-devel, linux-arm-kernel, linux-sound
According to WM8731 "PD, Rev 4.9 October 2012" datasheet, when it
works in DSP mode A, LRP = 1, while works in DSP mode B, LRP = 0.
So, fix LRP for DSP mode as the datesheet specification.
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
sound/soc/codecs/wm8731.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
index 456bb8c..bc7472c 100644
--- a/sound/soc/codecs/wm8731.c
+++ b/sound/soc/codecs/wm8731.c
@@ -447,10 +447,10 @@ static int wm8731_set_dai_fmt(struct snd_soc_dai *codec_dai,
iface |= 0x0001;
break;
case SND_SOC_DAIFMT_DSP_A:
- iface |= 0x0003;
+ iface |= 0x0013;
break;
case SND_SOC_DAIFMT_DSP_B:
- iface |= 0x0013;
+ iface |= 0x0003;
break;
default:
return -EINVAL;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ASoC: wm8731: fix dsp mode configuration
@ 2013-12-03 10:04 ` Bo Shen
0 siblings, 0 replies; 9+ messages in thread
From: Bo Shen @ 2013-12-03 10:04 UTC (permalink / raw)
To: broonie; +Cc: Bo Shen, alsa-devel, linux-arm-kernel, linux-sound
According to WM8731 "PD, Rev 4.9 October 2012" datasheet, when it
works in DSP mode A, LRP = 1, while works in DSP mode B, LRP = 0.
So, fix LRP for DSP mode as the datesheet specification.
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
sound/soc/codecs/wm8731.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
index 456bb8c..bc7472c 100644
--- a/sound/soc/codecs/wm8731.c
+++ b/sound/soc/codecs/wm8731.c
@@ -447,10 +447,10 @@ static int wm8731_set_dai_fmt(struct snd_soc_dai *codec_dai,
iface |= 0x0001;
break;
case SND_SOC_DAIFMT_DSP_A:
- iface |= 0x0003;
+ iface |= 0x0013;
break;
case SND_SOC_DAIFMT_DSP_B:
- iface |= 0x0013;
+ iface |= 0x0003;
break;
default:
return -EINVAL;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ASoC: wm8731: fix dsp mode configuration
@ 2013-12-03 10:04 ` Bo Shen
0 siblings, 0 replies; 9+ messages in thread
From: Bo Shen @ 2013-12-03 10:04 UTC (permalink / raw)
To: linux-arm-kernel
According to WM8731 "PD, Rev 4.9 October 2012" datasheet, when it
works in DSP mode A, LRP = 1, while works in DSP mode B, LRP = 0.
So, fix LRP for DSP mode as the datesheet specification.
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
sound/soc/codecs/wm8731.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
index 456bb8c..bc7472c 100644
--- a/sound/soc/codecs/wm8731.c
+++ b/sound/soc/codecs/wm8731.c
@@ -447,10 +447,10 @@ static int wm8731_set_dai_fmt(struct snd_soc_dai *codec_dai,
iface |= 0x0001;
break;
case SND_SOC_DAIFMT_DSP_A:
- iface |= 0x0003;
+ iface |= 0x0013;
break;
case SND_SOC_DAIFMT_DSP_B:
- iface |= 0x0013;
+ iface |= 0x0003;
break;
default:
return -EINVAL;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] ASoC: wm8731: fix dsp mode configuration
2013-12-03 10:04 ` Bo Shen
(?)
@ 2013-12-03 15:05 ` Mark Brown
-1 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2013-12-03 15:05 UTC (permalink / raw)
To: Bo Shen; +Cc: linux-sound, alsa-devel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
On Tue, Dec 03, 2013 at 06:04:54PM +0800, Bo Shen wrote:
> According to WM8731 "PD, Rev 4.9 October 2012" datasheet, when it
> works in DSP mode A, LRP = 1, while works in DSP mode B, LRP = 0.
> So, fix LRP for DSP mode as the datesheet specification.
Applied, thanks. Please do remember to CC maintainers on things, you've
missed the Wolfson guys.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ASoC: wm8731: fix dsp mode configuration
@ 2013-12-03 15:05 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2013-12-03 15:05 UTC (permalink / raw)
To: Bo Shen; +Cc: linux-sound, alsa-devel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
On Tue, Dec 03, 2013 at 06:04:54PM +0800, Bo Shen wrote:
> According to WM8731 "PD, Rev 4.9 October 2012" datasheet, when it
> works in DSP mode A, LRP = 1, while works in DSP mode B, LRP = 0.
> So, fix LRP for DSP mode as the datesheet specification.
Applied, thanks. Please do remember to CC maintainers on things, you've
missed the Wolfson guys.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ASoC: wm8731: fix dsp mode configuration
@ 2013-12-03 15:05 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2013-12-03 15:05 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 03, 2013 at 06:04:54PM +0800, Bo Shen wrote:
> According to WM8731 "PD, Rev 4.9 October 2012" datasheet, when it
> works in DSP mode A, LRP = 1, while works in DSP mode B, LRP = 0.
> So, fix LRP for DSP mode as the datesheet specification.
Applied, thanks. Please do remember to CC maintainers on things, you've
missed the Wolfson guys.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131203/db7e6eb6/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: wm8731: fix dsp mode configuration
2013-12-03 10:04 ` Bo Shen
(?)
@ 2013-12-03 15:57 ` Charles Keepax
-1 siblings, 0 replies; 9+ messages in thread
From: Charles Keepax @ 2013-12-03 15:57 UTC (permalink / raw)
To: Bo Shen; +Cc: broonie, alsa-devel, linux-arm-kernel, linux-sound
On Tue, Dec 03, 2013 at 06:04:54PM +0800, Bo Shen wrote:
> According to WM8731 "PD, Rev 4.9 October 2012" datasheet, when it
> works in DSP mode A, LRP = 1, while works in DSP mode B, LRP = 0.
> So, fix LRP for DSP mode as the datesheet specification.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: wm8731: fix dsp mode configuration
@ 2013-12-03 15:57 ` Charles Keepax
0 siblings, 0 replies; 9+ messages in thread
From: Charles Keepax @ 2013-12-03 15:57 UTC (permalink / raw)
To: Bo Shen; +Cc: broonie, alsa-devel, linux-arm-kernel, linux-sound
On Tue, Dec 03, 2013 at 06:04:54PM +0800, Bo Shen wrote:
> According to WM8731 "PD, Rev 4.9 October 2012" datasheet, when it
> works in DSP mode A, LRP = 1, while works in DSP mode B, LRP = 0.
> So, fix LRP for DSP mode as the datesheet specification.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 9+ messages in thread
* [alsa-devel] [PATCH] ASoC: wm8731: fix dsp mode configuration
@ 2013-12-03 15:57 ` Charles Keepax
0 siblings, 0 replies; 9+ messages in thread
From: Charles Keepax @ 2013-12-03 15:57 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 03, 2013 at 06:04:54PM +0800, Bo Shen wrote:
> According to WM8731 "PD, Rev 4.9 October 2012" datasheet, when it
> works in DSP mode A, LRP = 1, while works in DSP mode B, LRP = 0.
> So, fix LRP for DSP mode as the datesheet specification.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-12-03 15:57 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-03 10:04 [PATCH] ASoC: wm8731: fix dsp mode configuration Bo Shen
2013-12-03 10:04 ` Bo Shen
2013-12-03 10:04 ` Bo Shen
2013-12-03 15:05 ` Mark Brown
2013-12-03 15:05 ` Mark Brown
2013-12-03 15:05 ` Mark Brown
2013-12-03 15:57 ` [alsa-devel] " Charles Keepax
2013-12-03 15:57 ` Charles Keepax
2013-12-03 15:57 ` Charles Keepax
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.