From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Denis CIOCCA <denis.ciocca@st.com>,
Shawn Guo <shawn.guo@linaro.org>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Brian Lilly <brian@crystalfontz.com>,
Brent-Crosby <brent@crystalfontz.com>, Jim Wall <jimwall@q.com>,
devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] DT support for ST micro accelerometers and gyroscopes
Date: Tue, 3 Dec 2013 22:29:14 +0100 [thread overview]
Message-ID: <20131203212914.GC31496@lukather> (raw)
In-Reply-To: <20131130140402.21abae28@endymion.delvare>
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
Hi Jean,
On Sat, Nov 30, 2013 at 02:04:02PM +0100, Jean Delvare wrote:
> > i2c has a generic binding that matches to the name bit of the
> > i2c_device_id array. That is then exported in sysfs. There are
> > quite a lot of instances of underscores out there in these names.
> > Thus unforutnately they can't be changed without possibly breaking
> > userspace. Typically those same names are also output by IIO
> > though obviously we could keep that the same whilst changing the
> > dt binding.
> >
> > Also the i2c binding allows binding after dropping the vendor
> > prefix which is even more 'interesting'. See of_modialias_node in
> > drivers/of/base.c
> >
> > I'd therefore argue in favour of just leaving the underscores in
> > existing drivers as a nasty bit of legacy and doing our best to
> > not introduce any new ones!
>
> I don't know what is the problem with underscores, but please note
> that hwmon i2c devices are NOT allowed to have dashes in their name
> because that would break libsensors.
As far as I remember, hwmon doesn't handle the accelerometers or
gyroscopes, does it?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/3] DT support for ST micro accelerometers and gyroscopes
Date: Tue, 3 Dec 2013 22:29:14 +0100 [thread overview]
Message-ID: <20131203212914.GC31496@lukather> (raw)
In-Reply-To: <20131130140402.21abae28@endymion.delvare>
Hi Jean,
On Sat, Nov 30, 2013 at 02:04:02PM +0100, Jean Delvare wrote:
> > i2c has a generic binding that matches to the name bit of the
> > i2c_device_id array. That is then exported in sysfs. There are
> > quite a lot of instances of underscores out there in these names.
> > Thus unforutnately they can't be changed without possibly breaking
> > userspace. Typically those same names are also output by IIO
> > though obviously we could keep that the same whilst changing the
> > dt binding.
> >
> > Also the i2c binding allows binding after dropping the vendor
> > prefix which is even more 'interesting'. See of_modialias_node in
> > drivers/of/base.c
> >
> > I'd therefore argue in favour of just leaving the underscores in
> > existing drivers as a nasty bit of legacy and doing our best to
> > not introduce any new ones!
>
> I don't know what is the problem with underscores, but please note
> that hwmon i2c devices are NOT allowed to have dashes in their name
> because that would break libsensors.
As far as I remember, hwmon doesn't handle the accelerometers or
gyroscopes, does it?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131203/f2dacea7/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Denis CIOCCA <denis.ciocca-qxv4g6HH51o@public.gmane.org>,
Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Alexandre Belloni
<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Brian Lilly <brian-ZKiFAVwZFM2FeswfMrDH8w@public.gmane.org>,
Brent-Crosby <brent-ZKiFAVwZFM2FeswfMrDH8w@public.gmane.org>,
Jim Wall <jimwall@q.com>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC PATCH 0/3] DT support for ST micro accelerometers and gyroscopes
Date: Tue, 3 Dec 2013 22:29:14 +0100 [thread overview]
Message-ID: <20131203212914.GC31496@lukather> (raw)
In-Reply-To: <20131130140402.21abae28-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
Hi Jean,
On Sat, Nov 30, 2013 at 02:04:02PM +0100, Jean Delvare wrote:
> > i2c has a generic binding that matches to the name bit of the
> > i2c_device_id array. That is then exported in sysfs. There are
> > quite a lot of instances of underscores out there in these names.
> > Thus unforutnately they can't be changed without possibly breaking
> > userspace. Typically those same names are also output by IIO
> > though obviously we could keep that the same whilst changing the
> > dt binding.
> >
> > Also the i2c binding allows binding after dropping the vendor
> > prefix which is even more 'interesting'. See of_modialias_node in
> > drivers/of/base.c
> >
> > I'd therefore argue in favour of just leaving the underscores in
> > existing drivers as a nasty bit of legacy and doing our best to
> > not introduce any new ones!
>
> I don't know what is the problem with underscores, but please note
> that hwmon i2c devices are NOT allowed to have dashes in their name
> because that would break libsensors.
As far as I remember, hwmon doesn't handle the accelerometers or
gyroscopes, does it?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-03 21:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 15:50 [RFC PATCH 0/3] DT support for ST micro accelerometers and gyroscopes Maxime Ripard
2013-11-19 15:50 ` Maxime Ripard
2013-11-19 15:50 ` [RFC PATCH 1/3] iio: accel: Add device tree probing for STMicro accelerometers Maxime Ripard
2013-11-19 15:50 ` Maxime Ripard
2013-11-30 12:04 ` Jonathan Cameron
2013-11-30 12:04 ` Jonathan Cameron
2013-11-30 13:42 ` Maxime Ripard
2013-11-30 13:42 ` Maxime Ripard
2013-11-19 15:50 ` [RFC PATCH 2/3] iio: accel: Add device tree probing for STMicro gyroscopes Maxime Ripard
2013-11-19 15:50 ` Maxime Ripard
2013-11-19 15:50 ` [RFC PATCH 3/3] ARM: cfa10057: Add the accelerometer and gyroscope to the device tree Maxime Ripard
2013-11-19 15:50 ` Maxime Ripard
2013-11-21 11:41 ` [RFC PATCH 0/3] DT support for ST micro accelerometers and gyroscopes Denis CIOCCA
2013-11-21 11:41 ` Denis CIOCCA
2013-11-21 13:14 ` Maxime Ripard
2013-11-21 13:14 ` Maxime Ripard
2013-11-24 21:00 ` Jonathan Cameron
2013-11-24 21:00 ` Jonathan Cameron
2013-11-25 8:37 ` Denis CIOCCA
2013-11-25 8:37 ` Denis CIOCCA
2013-11-25 9:40 ` Maxime Ripard
2013-11-25 9:40 ` Maxime Ripard
2013-11-30 12:02 ` Jonathan Cameron
2013-11-30 12:02 ` Jonathan Cameron
2013-11-30 12:02 ` Jonathan Cameron
2013-11-30 13:04 ` Jean Delvare
2013-11-30 13:04 ` Jean Delvare
2013-11-30 13:04 ` Jean Delvare
2013-12-03 21:29 ` Maxime Ripard [this message]
2013-12-03 21:29 ` Maxime Ripard
2013-12-03 21:29 ` Maxime Ripard
2013-12-03 21:39 ` Jean Delvare
2013-12-03 21:39 ` Jean Delvare
2013-12-03 21:39 ` Jean Delvare
2013-11-30 14:13 ` Maxime Ripard
2013-11-30 14:13 ` Maxime Ripard
2013-11-30 14:13 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203212914.GC31496@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=brent@crystalfontz.com \
--cc=brian@crystalfontz.com \
--cc=denis.ciocca@st.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=jimwall@q.com \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.