From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document
Date: Wed, 4 Dec 2013 13:41:56 +0000 [thread overview]
Message-ID: <20131204134156.GA25422@lee--X1> (raw)
In-Reply-To: <1386164272.6195.3.camel@AMDC1943>
> > > +MAXIM MAX14577 multi-function device
> >
> > Why is Maxim capitalised in such a way?
> >
> > If you're going to use the term Multi-Function Device, please
> > capitalise it.
> >
> > > +MAX14577 is a Multi-function device with Micro-USB Interface Circuit, Li+
> >
> > Same here.
>
> I'll fix this. The MAXIM capitalization came from other drivers.
No need to repeat mistakes. I believe it should be Maxim.
> > > +Example:
> > > + max14577 at 25 {
> > > + compatible = "maxim,max14577";
> > > + reg = <0x25>;
> > > + interrupt-parent = <&gpx1>;
> > > + interrupts = <5 0>;
> >
> > I'm gussing this is IRQ5 and the 0 is flags? If so, please use
> > #defines for the flags.
>
> This is a standard interrupt binding. The max14577 MFD core driver
> ignores the interrupt flags and always uses IRQF_TRIGGER_FALLING. I can
> fix this with new patch for drivers/mfd/max14577.c but still I don't see
> what should be added in documentation.
s/0/IRQ_TYPE_NONE
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Krzysztof Kozlowski
<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
Anton Vorontsov <anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kyungmin Park
<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Bartlomiej Zolnierkiewicz
<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Marek Szyprowski
<m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document
Date: Wed, 4 Dec 2013 13:41:56 +0000 [thread overview]
Message-ID: <20131204134156.GA25422@lee--X1> (raw)
In-Reply-To: <1386164272.6195.3.camel@AMDC1943>
> > > +MAXIM MAX14577 multi-function device
> >
> > Why is Maxim capitalised in such a way?
> >
> > If you're going to use the term Multi-Function Device, please
> > capitalise it.
> >
> > > +MAX14577 is a Multi-function device with Micro-USB Interface Circuit, Li+
> >
> > Same here.
>
> I'll fix this. The MAXIM capitalization came from other drivers.
No need to repeat mistakes. I believe it should be Maxim.
> > > +Example:
> > > + max14577@25 {
> > > + compatible = "maxim,max14577";
> > > + reg = <0x25>;
> > > + interrupt-parent = <&gpx1>;
> > > + interrupts = <5 0>;
> >
> > I'm gussing this is IRQ5 and the 0 is flags? If so, please use
> > #defines for the flags.
>
> This is a standard interrupt binding. The max14577 MFD core driver
> ignores the interrupt flags and always uses IRQF_TRIGGER_FALLING. I can
> fix this with new patch for drivers/mfd/max14577.c but still I don't see
> what should be added in documentation.
s/0/IRQ_TYPE_NONE
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>, Anton Vorontsov <anton@enomsg.org>,
David Woodhouse <dwmw2@infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document
Date: Wed, 4 Dec 2013 13:41:56 +0000 [thread overview]
Message-ID: <20131204134156.GA25422@lee--X1> (raw)
In-Reply-To: <1386164272.6195.3.camel@AMDC1943>
> > > +MAXIM MAX14577 multi-function device
> >
> > Why is Maxim capitalised in such a way?
> >
> > If you're going to use the term Multi-Function Device, please
> > capitalise it.
> >
> > > +MAX14577 is a Multi-function device with Micro-USB Interface Circuit, Li+
> >
> > Same here.
>
> I'll fix this. The MAXIM capitalization came from other drivers.
No need to repeat mistakes. I believe it should be Maxim.
> > > +Example:
> > > + max14577@25 {
> > > + compatible = "maxim,max14577";
> > > + reg = <0x25>;
> > > + interrupt-parent = <&gpx1>;
> > > + interrupts = <5 0>;
> >
> > I'm gussing this is IRQ5 and the 0 is flags? If so, please use
> > #defines for the flags.
>
> This is a standard interrupt binding. The max14577 MFD core driver
> ignores the interrupt flags and always uses IRQF_TRIGGER_FALLING. I can
> fix this with new patch for drivers/mfd/max14577.c but still I don't see
> what should be added in documentation.
s/0/IRQ_TYPE_NONE
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-12-04 13:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 10:40 [PATCH v6 0/3] mfd: max14577: Add max14577 MFD drivers Krzysztof Kozlowski
2013-12-04 10:40 ` Krzysztof Kozlowski
2013-12-04 10:40 ` [PATCH v6 1/3] charger: max14577: Add charger support for Maxim 14577 Krzysztof Kozlowski
2013-12-04 10:40 ` Krzysztof Kozlowski
2013-12-04 10:40 ` [PATCH v6 2/3] regulator: max14577: Add regulator driver " Krzysztof Kozlowski
2013-12-04 10:40 ` Krzysztof Kozlowski
2013-12-04 10:40 ` Krzysztof Kozlowski
2013-12-04 10:40 ` [PATCH v6 3/3] mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
2013-12-04 10:40 ` Krzysztof Kozlowski
2013-12-04 10:50 ` Chanwoo Choi
2013-12-04 10:50 ` Chanwoo Choi
2013-12-04 10:56 ` Krzysztof Kozlowski
2013-12-04 10:56 ` Krzysztof Kozlowski
2013-12-04 10:56 ` Krzysztof Kozlowski
2013-12-04 11:01 ` Chanwoo Choi
2013-12-04 11:01 ` Chanwoo Choi
2013-12-04 11:03 ` Krzysztof Kozlowski
2013-12-04 11:03 ` Krzysztof Kozlowski
2013-12-04 11:09 ` Chanwoo Choi
2013-12-04 11:09 ` Chanwoo Choi
2013-12-04 11:09 ` Chanwoo Choi
2013-12-04 11:20 ` Lee Jones
2013-12-04 11:20 ` Lee Jones
2013-12-04 11:20 ` Lee Jones
2013-12-04 12:49 ` Mark Brown
2013-12-04 12:49 ` Mark Brown
2013-12-04 13:37 ` Krzysztof Kozlowski
2013-12-04 13:37 ` Krzysztof Kozlowski
2013-12-04 13:41 ` Lee Jones [this message]
2013-12-04 13:41 ` Lee Jones
2013-12-04 13:41 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204134156.GA25422@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.