Re: How to test my patches for the (staging) android driver?

Re: How to test my patches for the (staging) android driver?

[Matthias Beyer]

[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]

Hi,

Greg-KHs email bot tells me to send this message to a ML. It suggests
to send it to this list or kernelnewbies@nl.linux.org, but the latter
results in a failure notice. So I send this email to this list.

On 03-12-2013 16:16:42, Matthias Beyer wrote:
> Hi,
> 
> First: I'm really new to the kernel in manner of submitting patches,
> testing etc. Please, if you send me guidelines or pointers on
> what to do, explain how to do things!
> 
> I'm working on some cleanup patches for code in drivers/staging/android/.
> These patches are cleanup patches as suggested in the appropriate TODO
> file, including fixes for checkpatch, but also function splitting as
> there are some really long functions (mainly in binder.c).
> 
> How to test my code beside compiling it? Do I even have a possibility
> to test it or should I just send it to you?
> 
> Besides: Which ML should I post this (and the patches) to? Main Kernel
> ML?
> 
> -- 
> Mit freundlichen Grüßen,
> Kind regards,
> Matthias Beyer
> 
> Proudly sent with mutt.
> Happily signed with gnupg.



-- 
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer

Proudly sent with mutt.
Happily signed with gnupg.

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

How to test my patches for the (staging) android driver?

[Matthias Beyer]

Hi kernelnewbies!

As I do not get any answer from the other MLs, this goes here, too.
Maybe there is just too much noise in lkml... never mind!

On 03-12-2013 16:57:08, Matthias Beyer wrote:
> Hi,
> 
> Greg-KHs email bot tells me to send this message to a ML. It suggests
> to send it to this list or kernelnewbies at nl.linux.org, but the latter
> results in a failure notice. So I send this email to this list.
> 
> On 03-12-2013 16:16:42, Matthias Beyer wrote:
> > Hi,
> > 
> > First: I'm really new to the kernel in manner of submitting patches,
> > testing etc. Please, if you send me guidelines or pointers on
> > what to do, explain how to do things!
> > 
> > I'm working on some cleanup patches for code in drivers/staging/android/.
> > These patches are cleanup patches as suggested in the appropriate TODO
> > file, including fixes for checkpatch, but also function splitting as
> > there are some really long functions (mainly in binder.c).
> > 
> > How to test my code beside compiling it? Do I even have a possibility
> > to test it or should I just send it to you?
> > 
> > Besides: Which ML should I post this (and the patches) to? Main Kernel
> > ML?
> > 
> 

-- 
Mit freundlichen Gr??en,
Kind regards,
Matthias Beyer

Proudly sent with mutt.
Happily signed with gnupg.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20131204/c647d318/attachment.bin 

How to test my patches for the (staging) android driver?

[Valdis.Kletnieks at vt.edu]

On Wed, 04 Dec 2013 16:08:52 +0100, Matthias Beyer said:

> > > How to test my code beside compiling it? Do I even have a possibility
> > > to test it or should I just send it to you?

If at all possible, you should cross-compile for an appropriate architecture
and actually boot and test the code in question.  There's lots of ways
to write code in C that compiles cleanly, looks correct, but is subtly
wrong for some reason.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 865 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20131204/6f77d06a/attachment.bin 

How to test my patches for the (staging) android driver?

[Matthias Beyer]

On 04-12-2013 10:17:23, Valdis.Kletnieks at vt.edu wrote:
> On Wed, 04 Dec 2013 16:08:52 +0100, Matthias Beyer said:
> 
> > > > How to test my code beside compiling it? Do I even have a possibility
> > > > to test it or should I just send it to you?
> 
> If at all possible, you should cross-compile for an appropriate architecture
> and actually boot and test the code in question.  There's lots of ways
> to write code in C that compiles cleanly, looks correct, but is subtly
> wrong for some reason.

Thank you for your reply!

How to cross-compile and even more important: How to test? I
do not have devices for testing! Should I try it in a VM?

What I can do is checking if the object file is the same before and
after my stylefix patches. But I think this does not work for
functions I split up into several smaller ones...

-- 
Mit freundlichen Gr??en,
Kind regards,
Matthias Beyer

Proudly sent with mutt.
Happily signed with gnupg.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20131204/7e8fbbe1/attachment-0001.bin