lvm thin_* binaries are installed in hostonly mode?

lvm thin_* binaries are installed in hostonly mode?

[WANG Chao]

Hi, Harald

I notice these thin_* binaries are installed to kdump initramfs in spite
of the fact that I don't use thinp lvm:

# ll sbin/thin_*
-rwxr-xr-x. 1 root root  384648 Dec  4 20:37 sbin/thin_check
-rwxr-xr-x. 1 root root 2184112 Dec  4 20:37 sbin/thin_dump
-rwxr-xr-x. 1 root root 2179792 Dec  4 20:37 sbin/thin_repair
-rwxr-xr-x. 1 root root 2179928 Dec  4 20:37 sbin/thin_restore

This is introduced here:

commit 5d623b1
Author: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Date:   Mon Oct 21 09:09:26 2013 +0200

    lvm: always install thin utils for lvm


These binaries are totally 6.6M in size. That's too much for a kdump
environment.

As you probably know, in kdump kernel, we only have very limited memory
(~128M) and makedumpfile (a vmcore dump tool) is more faster if there's
more available memory out there.

IMO, it's best we only install these thin_* bins when people are
actually using these ones.

Anyway, I don't know if you have any particular reason to do this..


Thanks
WANG Chao

Re: lvm thin_* binaries are installed in hostonly mode?

[Vivek Goyal]

On Wed, Dec 04, 2013 at 10:05:17PM +0800, WANG Chao wrote:
> Hi, Harald
> 
> I notice these thin_* binaries are installed to kdump initramfs in spite
> of the fact that I don't use thinp lvm:
> 
> # ll sbin/thin_*
> -rwxr-xr-x. 1 root root  384648 Dec  4 20:37 sbin/thin_check
> -rwxr-xr-x. 1 root root 2184112 Dec  4 20:37 sbin/thin_dump
> -rwxr-xr-x. 1 root root 2179792 Dec  4 20:37 sbin/thin_repair
> -rwxr-xr-x. 1 root root 2179928 Dec  4 20:37 sbin/thin_restore
> 
> This is introduced here:
> 
> commit 5d623b1
> Author: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Date:   Mon Oct 21 09:09:26 2013 +0200
> 
>     lvm: always install thin utils for lvm

I think we should install these only if thin device/volume is in the
mount path.

Thanks
Vivek

Re: lvm thin_* binaries are installed in hostonly mode?

[WANG Chao]

On 12/04/13 at 10:20am, Vivek Goyal wrote:
> On Wed, Dec 04, 2013 at 10:05:17PM +0800, WANG Chao wrote:
> > Hi, Harald
> > 
> > I notice these thin_* binaries are installed to kdump initramfs in spite
> > of the fact that I don't use thinp lvm:
> > 
> > # ll sbin/thin_*
> > -rwxr-xr-x. 1 root root  384648 Dec  4 20:37 sbin/thin_check
> > -rwxr-xr-x. 1 root root 2184112 Dec  4 20:37 sbin/thin_dump
> > -rwxr-xr-x. 1 root root 2179792 Dec  4 20:37 sbin/thin_repair
> > -rwxr-xr-x. 1 root root 2179928 Dec  4 20:37 sbin/thin_restore
> > 
> > This is introduced here:
> > 
> > commit 5d623b1
> > Author: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > Date:   Mon Oct 21 09:09:26 2013 +0200
> > 
> >     lvm: always install thin utils for lvm
> 
> I think we should install these only if thin device/volume is in the
> mount path.
> 
> Thanks
> Vivek

Thanks Harald. I see you have fixed it upstream and it's working.

commit c21c4dc
Author: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Date:   Thu Dec 5 15:57:42 2013 +0100

    lvm: install thin tools, only when needed in hostonly


Thanks,
Chao