From: Johannes Weiner <hannes@cmpxchg.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Glauber Costa <glommer@gmail.com>,
netdev@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: 2e685cad5790 build warning
Date: Wed, 4 Dec 2013 17:47:15 -0500 [thread overview]
Message-ID: <20131204224715.GD21724@cmpxchg.org> (raw)
In-Reply-To: <20131204222943.GC21724@cmpxchg.org>
[ botched linux-kernel address in the first try ]
On Wed, Dec 04, 2013 at 05:29:43PM -0500, Johannes Weiner wrote:
> Hi Eric,
>
> commit 2e685cad57906e19add7189b5ff49dfb6aaa21d3
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date: Sat Oct 19 16:26:19 2013 -0700
>
> tcp_memcontrol: Kill struct tcp_memcontrol
>
> Replace the pointers in struct cg_proto with actual data fields and kill
> struct tcp_memcontrol as it is not fully redundant.
>
> This removes a confusing, unnecessary layer of abstraction.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> triggers a build warning because it removed the only reference to a
> function but not the function itself:
>
> linux/net/ipv4/tcp_memcontrol.c:9:13: warning: a??memcg_tcp_enter_memory_pressurea?? defined but not used [-Wunused-function]
> static void memcg_tcp_enter_memory_pressure(struct sock *sk)
>
> I can not see from the changelog why this function is no longer used,
> or who is supposed to now set cg_proto->memory_pressure which you
> still initialize etc. Either way, the current state does not seem to
> make much sense. The author would be the best person to double check
> such changes, but he wasn't copied on your patch, so I copied him now.
>
> Apologies if this has been brought up before, I could not find any
> reference on LKML of either this patch or a report of this warning.
>
> Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Glauber Costa <glommer@gmail.com>,
netdev@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: 2e685cad5790 build warning
Date: Wed, 4 Dec 2013 17:47:15 -0500 [thread overview]
Message-ID: <20131204224715.GD21724@cmpxchg.org> (raw)
In-Reply-To: <20131204222943.GC21724@cmpxchg.org>
[ botched linux-kernel address in the first try ]
On Wed, Dec 04, 2013 at 05:29:43PM -0500, Johannes Weiner wrote:
> Hi Eric,
>
> commit 2e685cad57906e19add7189b5ff49dfb6aaa21d3
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date: Sat Oct 19 16:26:19 2013 -0700
>
> tcp_memcontrol: Kill struct tcp_memcontrol
>
> Replace the pointers in struct cg_proto with actual data fields and kill
> struct tcp_memcontrol as it is not fully redundant.
>
> This removes a confusing, unnecessary layer of abstraction.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> triggers a build warning because it removed the only reference to a
> function but not the function itself:
>
> linux/net/ipv4/tcp_memcontrol.c:9:13: warning: ‘memcg_tcp_enter_memory_pressure’ defined but not used [-Wunused-function]
> static void memcg_tcp_enter_memory_pressure(struct sock *sk)
>
> I can not see from the changelog why this function is no longer used,
> or who is supposed to now set cg_proto->memory_pressure which you
> still initialize etc. Either way, the current state does not seem to
> make much sense. The author would be the best person to double check
> such changes, but he wasn't copied on your patch, so I copied him now.
>
> Apologies if this has been brought up before, I could not find any
> reference on LKML of either this patch or a report of this warning.
>
> Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Glauber Costa <glommer@gmail.com>,
netdev@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: 2e685cad5790 build warning
Date: Wed, 4 Dec 2013 17:47:15 -0500 [thread overview]
Message-ID: <20131204224715.GD21724@cmpxchg.org> (raw)
In-Reply-To: <20131204222943.GC21724@cmpxchg.org>
[ botched linux-kernel address in the first try ]
On Wed, Dec 04, 2013 at 05:29:43PM -0500, Johannes Weiner wrote:
> Hi Eric,
>
> commit 2e685cad57906e19add7189b5ff49dfb6aaa21d3
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date: Sat Oct 19 16:26:19 2013 -0700
>
> tcp_memcontrol: Kill struct tcp_memcontrol
>
> Replace the pointers in struct cg_proto with actual data fields and kill
> struct tcp_memcontrol as it is not fully redundant.
>
> This removes a confusing, unnecessary layer of abstraction.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> triggers a build warning because it removed the only reference to a
> function but not the function itself:
>
> linux/net/ipv4/tcp_memcontrol.c:9:13: warning: ‘memcg_tcp_enter_memory_pressure’ defined but not used [-Wunused-function]
> static void memcg_tcp_enter_memory_pressure(struct sock *sk)
>
> I can not see from the changelog why this function is no longer used,
> or who is supposed to now set cg_proto->memory_pressure which you
> still initialize etc. Either way, the current state does not seem to
> make much sense. The author would be the best person to double check
> such changes, but he wasn't copied on your patch, so I copied him now.
>
> Apologies if this has been brought up before, I could not find any
> reference on LKML of either this patch or a report of this warning.
>
> Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-04 22:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 22:29 2e685cad5790 build warning Johannes Weiner
2013-12-04 22:29 ` Johannes Weiner
2013-12-04 22:47 ` Johannes Weiner [this message]
2013-12-04 22:47 ` Johannes Weiner
2013-12-04 22:47 ` Johannes Weiner
2013-12-04 22:50 ` David Miller
2013-12-05 4:12 ` [PATCH] tcp_memcontrol: Cleanup/fix cg_proto->memory_pressure handling Eric W. Biederman
2013-12-05 4:12 ` Eric W. Biederman
2013-12-06 2:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204224715.GD21724@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=ebiederm@xmission.com \
--cc=glommer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.