From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V3] dma: tegra: register as an OF DMA controller
Date: Thu, 5 Dec 2013 03:46:08 +0100 [thread overview]
Message-ID: <201312050346.09225.arnd@arndb.de> (raw)
In-Reply-To: <529F65E6.9050606-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Wednesday 04 December 2013, Stephen Warren wrote:
> >
> > We really need to be better at having a common set of rules regarding what
> > it actually means to set the slave_id through dma_slave_config(). IMHO
> > we should just treat it as a bug for any dmaengine driver that is configured
> > through DT, or we should get rid of this entirely.
>
> By the end of this series (for the Tegra driver) I can remove those "+"
> lines you quoted above; the slave ID will only come from DT through
> of_xlate, and any slave ID in the slave_config will simply be ignored.
Ok, that's certainly a step in the right direction. However, as I said
my comment wasn't really directed at you and I think it's more important
to have a clear policy that we can enforce across all dmaengine drivers.
It's really up to Vinod and Dan to decide how it should be handled
in general.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] dma: tegra: register as an OF DMA controller
Date: Thu, 5 Dec 2013 03:46:08 +0100 [thread overview]
Message-ID: <201312050346.09225.arnd@arndb.de> (raw)
In-Reply-To: <529F65E6.9050606@wwwdotorg.org>
On Wednesday 04 December 2013, Stephen Warren wrote:
> >
> > We really need to be better at having a common set of rules regarding what
> > it actually means to set the slave_id through dma_slave_config(). IMHO
> > we should just treat it as a bug for any dmaengine driver that is configured
> > through DT, or we should get rid of this entirely.
>
> By the end of this series (for the Tegra driver) I can remove those "+"
> lines you quoted above; the slave ID will only come from DT through
> of_xlate, and any slave ID in the slave_config will simply be ignored.
Ok, that's certainly a step in the right direction. However, as I said
my comment wasn't really directed at you and I think it's more important
to have a clear policy that we can enforce across all dmaengine drivers.
It's really up to Vinod and Dan to decide how it should be handled
in general.
Arnd
next prev parent reply other threads:[~2013-12-05 2:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 20:33 [PATCH V3] dma: tegra: register as an OF DMA controller Stephen Warren
2013-12-03 20:33 ` Stephen Warren
[not found] ` <1386102787-21839-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-04 1:34 ` Arnd Bergmann
2013-12-04 1:34 ` Arnd Bergmann
[not found] ` <201312040234.09708.arnd-r2nGTMty4D4@public.gmane.org>
2013-12-04 17:27 ` Stephen Warren
2013-12-04 17:27 ` Stephen Warren
[not found] ` <529F65E6.9050606-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-05 2:46 ` Arnd Bergmann [this message]
2013-12-05 2:46 ` Arnd Bergmann
2013-12-04 9:45 ` Thierry Reding
2013-12-04 9:45 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312050346.09225.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.