From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linaro-kernel@lists.linaro.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
patches@linaro.org, Catalin Marinas <catalin.marinas@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
linaro-acpi@lists.linaro.org, linux-acpi@vger.kernel.org,
Amit Daniel Kachhap <amit.daniel@samsung.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Olof Johansson <olof@lixom.net>,
Jon Masters <jonathan@jonmasters.org>,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [RFC part3 PATCH 1/2] clocksource / arch_timer: Use ACPI GTDT table to initialize arch timer
Date: Thu, 5 Dec 2013 04:43:21 +0100 [thread overview]
Message-ID: <201312050443.21858.arnd@arndb.de> (raw)
In-Reply-To: <1386088891-2917-2-git-send-email-hanjun.guo@linaro.org>
On Tuesday 03 December 2013, Hanjun Guo wrote:
> +#ifdef CONFIG_ACPI
> +void __init arch_timer_acpi_init(void)
> +{
...
> +}
> +#else
> +void __init arch_timer_acpi_init(void) { return; };
> +#endif
>
The #else clause is broken in combination with
> diff --git a/include/clocksource/arm_arch_timer.h b/include/clocksource/arm_arch_timer.h
> index 6d26b40..2654edf 100644
> --- a/include/clocksource/arm_arch_timer.h
> +++ b/include/clocksource/arm_arch_timer.h
> @@ -66,6 +66,11 @@ static inline struct timecounter *arch_timer_get_timecounter(void)
> return NULL;
> }
>
> +static inline void arch_timer_acpi_init(void)
> +{
> + return;
> +}
> +
> #endif
>
this inline function. Have you build-tested this with CONFIG_ACPI disabled?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC part3 PATCH 1/2] clocksource / arch_timer: Use ACPI GTDT table to initialize arch timer
Date: Thu, 5 Dec 2013 04:43:21 +0100 [thread overview]
Message-ID: <201312050443.21858.arnd@arndb.de> (raw)
In-Reply-To: <1386088891-2917-2-git-send-email-hanjun.guo@linaro.org>
On Tuesday 03 December 2013, Hanjun Guo wrote:
> +#ifdef CONFIG_ACPI
> +void __init arch_timer_acpi_init(void)
> +{
...
> +}
> +#else
> +void __init arch_timer_acpi_init(void) { return; };
> +#endif
>
The #else clause is broken in combination with
> diff --git a/include/clocksource/arm_arch_timer.h b/include/clocksource/arm_arch_timer.h
> index 6d26b40..2654edf 100644
> --- a/include/clocksource/arm_arch_timer.h
> +++ b/include/clocksource/arm_arch_timer.h
> @@ -66,6 +66,11 @@ static inline struct timecounter *arch_timer_get_timecounter(void)
> return NULL;
> }
>
> +static inline void arch_timer_acpi_init(void)
> +{
> + return;
> +}
> +
> #endif
>
this inline function. Have you build-tested this with CONFIG_ACPI disabled?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Hanjun Guo <hanjun.guo@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
linaro-kernel@lists.linaro.org, patches@linaro.org,
Linus Walleij <linus.walleij@linaro.org>,
Olof Johansson <olof@lixom.net>,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
linaro-acpi@lists.linaro.org, linux-acpi@vger.kernel.org,
Amit Daniel Kachhap <amit.daniel@samsung.com>,
Jon Masters <jonathan@jonmasters.org>,
Grant Likely <grant.likely@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [RFC part3 PATCH 1/2] clocksource / arch_timer: Use ACPI GTDT table to initialize arch timer
Date: Thu, 5 Dec 2013 04:43:21 +0100 [thread overview]
Message-ID: <201312050443.21858.arnd@arndb.de> (raw)
In-Reply-To: <1386088891-2917-2-git-send-email-hanjun.guo@linaro.org>
On Tuesday 03 December 2013, Hanjun Guo wrote:
> +#ifdef CONFIG_ACPI
> +void __init arch_timer_acpi_init(void)
> +{
...
> +}
> +#else
> +void __init arch_timer_acpi_init(void) { return; };
> +#endif
>
The #else clause is broken in combination with
> diff --git a/include/clocksource/arm_arch_timer.h b/include/clocksource/arm_arch_timer.h
> index 6d26b40..2654edf 100644
> --- a/include/clocksource/arm_arch_timer.h
> +++ b/include/clocksource/arm_arch_timer.h
> @@ -66,6 +66,11 @@ static inline struct timecounter *arch_timer_get_timecounter(void)
> return NULL;
> }
>
> +static inline void arch_timer_acpi_init(void)
> +{
> + return;
> +}
> +
> #endif
>
this inline function. Have you build-tested this with CONFIG_ACPI disabled?
Arnd
next prev parent reply other threads:[~2013-12-05 3:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 16:41 [RFC part3 PATCH 0/2] Using ACPI GTDT table to initialize arch timer Hanjun Guo
2013-12-03 16:41 ` Hanjun Guo
2013-12-03 16:41 ` [RFC part3 PATCH 1/2] clocksource / arch_timer: Use " Hanjun Guo
2013-12-03 16:41 ` Hanjun Guo
2013-12-03 17:04 ` Mark Rutland
2013-12-03 17:04 ` Mark Rutland
2013-12-03 17:04 ` Mark Rutland
2013-12-04 14:25 ` Hanjun Guo
2013-12-04 14:25 ` Hanjun Guo
2013-12-04 14:25 ` Hanjun Guo
2013-12-05 3:43 ` Arnd Bergmann [this message]
2013-12-05 3:43 ` Arnd Bergmann
2013-12-05 3:43 ` Arnd Bergmann
2013-12-05 13:52 ` Hanjun Guo
2013-12-05 13:52 ` Hanjun Guo
2013-12-05 13:52 ` Hanjun Guo
2013-12-03 16:41 ` [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init() Hanjun Guo
2013-12-03 16:41 ` Hanjun Guo
2013-12-03 17:08 ` Mark Rutland
2013-12-03 17:08 ` Mark Rutland
2013-12-03 17:08 ` Mark Rutland
2013-12-04 14:27 ` Hanjun Guo
2013-12-04 14:27 ` Hanjun Guo
2013-12-04 14:27 ` Hanjun Guo
2013-12-04 15:07 ` Mark Rutland
2013-12-04 15:07 ` Mark Rutland
2013-12-04 15:07 ` Mark Rutland
2013-12-05 13:09 ` Hanjun Guo
2013-12-05 13:09 ` Hanjun Guo
2013-12-05 13:09 ` Hanjun Guo
[not found] <1386069328-22502-1-git-send-email-hanjun.guo@linaro.org>
[not found] ` <1386069328-22502-2-git-send-email-hanjun.guo@linaro.org>
2013-12-04 15:33 ` [RFC part3 PATCH 1/2] clocksource / arch_timer: Use ACPI GTDT table to initialize arch timer Rob Herring
2013-12-04 15:33 ` Rob Herring
2013-12-05 13:26 ` Hanjun Guo
2013-12-05 13:26 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312050443.21858.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=amit.daniel@samsung.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=grant.likely@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=jonathan@jonmasters.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mjg59@srcf.ucam.org \
--cc=olof@lixom.net \
--cc=patches@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=rob.herring@calxeda.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.