All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Jason Cooper <jason@lakedaemon.net>,
	devicetree@vger.kernel.org, linux-ide@vger.kernel.org,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>
Subject: Re: [PATCH 1/5] Phy: DT binding documentation for Marvell MVEBU SATA phy.
Date: Thu, 5 Dec 2013 10:47:04 +0100	[thread overview]
Message-ID: <20131205094704.GE10498@lunn.ch> (raw)
In-Reply-To: <20131205094319.GD10498@lunn.ch>

> > > +			compatible = "marvell,mvebu-sata-phy";
> > > +			reg = <0x84000 0x0334>;
> > > +			clocks = <&gate_clk 15>;
> > > +			clock-names = "sata";
> > > +			#phy-cells = <1>;
> > 
> > Is it on purpose that your are having phy-cells value to 1?
> 
> Yes. Each instance only controls one phy.

Ah, sorry, got that wrong. As you say in a later comment, this should
be 0. Will be fixed in v2.

   Thanks
	Andrew

   

  reply	other threads:[~2013-12-05  9:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 17:15 [PATCH 0/5] MVEBU SATA PHY driver Andrew Lunn
2013-12-04 17:16 ` [PATCH 1/5] Phy: DT binding documentation for Marvell MVEBU SATA phy Andrew Lunn
2013-12-05  6:03   ` Kishon Vijay Abraham I
2013-12-05  9:43     ` Andrew Lunn
2013-12-05  9:47       ` Andrew Lunn [this message]
2013-12-05 10:35       ` Kishon Vijay Abraham I
2013-12-10 22:59       ` Andrew Lunn
2013-12-11  5:41         ` Kishon Vijay Abraham I
     [not found] ` <1386177364-10164-1-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2013-12-04 17:16   ` [PATCH 2/5] Phy: Add a PHY driver for Marvell MVEBU SATA PHY Andrew Lunn
2013-12-05  6:10     ` Kishon Vijay Abraham I
2013-12-04 17:16 ` [PATCH 3/5] SATA: MV: Add support for the optional PHYs Andrew Lunn
2013-12-05  6:15   ` Kishon Vijay Abraham I
2013-12-04 17:16 ` [PATCH 4/5] Phy: Add DT nodes on kirkwood and Dove for the SATA PHY Andrew Lunn
2013-12-04 20:01   ` Sergei Shtylyov
2013-12-04 19:18     ` Andrew Lunn
2013-12-05  6:17   ` Kishon Vijay Abraham I
2013-12-04 17:16 ` [PATCH 5/5] ARM: defconfig: Enable generic phy in dove and kirkwood Andrew Lunn
2013-12-04 20:03   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131205094704.GE10498@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=kishon@ti.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=sebastian.hesselbarth@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.