Re: [PATCH 4/5] Phy: Add DT nodes on kirkwood and Dove for the SATA PHY

[Andrew Lunn <andrew@lunn.ch>]

On Wed, Dec 04, 2013 at 11:01:20PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/04/2013 08:16 PM, Andrew Lunn wrote:
> 
> >Add nodes for the two SATA PHYs on kirkewood.
> >Add node for the one SATA PHY on Dove.
> >Add pHandles to the PHYs in the sata nodes.
> 
>    I don't think this patch should be pushed thru the libata tree.
> However, you didn't Cc linux-arm-kernel...

I've actually no idea how this will go upstream, since it is three
different subsystems, generic phy, libata, and arm/mvebu. I will leave
it up to the maintainers to decide that. I can add some more CC: for
v2.

> >+			sata_phy0: sata_phy@0 {
> 
>    The node should rather be named "sata-phy@0" to be in line with
> "ethernet-phy" found in the ePAPR spec. [1], hyphen is generally
> preferred to underscore in the device trees.

O.K, will do. kirkwood.dtsi and dove.dtsi already follow this pattern
of - in the @ part.

Thanks
	Andrew