From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>
Subject: Re: [PATCH] ARM: OMAP2+: Fix populating the hwmod data from device tree
Date: Thu, 5 Dec 2013 16:25:48 -0800 [thread overview]
Message-ID: <20131206002547.GK26766@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1312060006510.26450@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [131205 16:09]:
> On Thu, 5 Dec 2013, Tony Lindgren wrote:
>
> > * Tony Lindgren <tony@atomide.com> [131121 12:49]:
> > > * Tony Lindgren <tony@atomide.com> [131120 17:46]:
> > > > * Tony Lindgren <tony@atomide.com> [131120 16:06]:
> > > > >
> > > > > They at least had interrupts listed looking at commit 3b9b10. Probably
> > > > > the thing to do for now is to revert those changes, and see if we can
> > > > > just remove the L3 entries from the .dtsi files.
> > > >
> > > > Actually the patch I posted should be able to handle also the
> > > > ti,hwmods = "l3_main_1", "l3_main_2", "l3_main_3" property in omap4.dtsi,
> > > > but we're not currently parsing that as we only look at the children
> > > > and not the properties of the OCP bus. Should be fixable, will take a look
> > > > tomorrow if this approach makes sense to you.
> > >
> > > OK this one seems to do the right thing for me.
> >
> > No comments? I'll queue the patch below to the fixes, please yell
> > if you see any issues with that.
>
> Looks reasonable to me based on a quick glance:
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
>
> Have not tested it though.
OK thanks for looking. I've used it with my mach-omap2 DT patches for past
few weeks on various boards without issues.
> I like the warning message for the bad data.
:)
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: Fix populating the hwmod data from device tree
Date: Thu, 5 Dec 2013 16:25:48 -0800 [thread overview]
Message-ID: <20131206002547.GK26766@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1312060006510.26450@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [131205 16:09]:
> On Thu, 5 Dec 2013, Tony Lindgren wrote:
>
> > * Tony Lindgren <tony@atomide.com> [131121 12:49]:
> > > * Tony Lindgren <tony@atomide.com> [131120 17:46]:
> > > > * Tony Lindgren <tony@atomide.com> [131120 16:06]:
> > > > >
> > > > > They at least had interrupts listed looking at commit 3b9b10. Probably
> > > > > the thing to do for now is to revert those changes, and see if we can
> > > > > just remove the L3 entries from the .dtsi files.
> > > >
> > > > Actually the patch I posted should be able to handle also the
> > > > ti,hwmods = "l3_main_1", "l3_main_2", "l3_main_3" property in omap4.dtsi,
> > > > but we're not currently parsing that as we only look at the children
> > > > and not the properties of the OCP bus. Should be fixable, will take a look
> > > > tomorrow if this approach makes sense to you.
> > >
> > > OK this one seems to do the right thing for me.
> >
> > No comments? I'll queue the patch below to the fixes, please yell
> > if you see any issues with that.
>
> Looks reasonable to me based on a quick glance:
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
>
> Have not tested it though.
OK thanks for looking. I've used it with my mach-omap2 DT patches for past
few weeks on various boards without issues.
> I like the warning message for the bad data.
:)
Tony
next prev parent reply other threads:[~2013-12-06 0:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 2:56 [PATCH] ARM: OMAP2+: Fix populating the hwmod data from device tree Tony Lindgren
2013-11-20 2:56 ` Tony Lindgren
2013-11-20 18:12 ` Tony Lindgren
2013-11-20 18:12 ` Tony Lindgren
2013-11-20 19:22 ` Tony Lindgren
2013-11-20 19:22 ` Tony Lindgren
2013-11-20 21:58 ` Paul Walmsley
2013-11-20 21:58 ` Paul Walmsley
2013-11-21 0:05 ` Tony Lindgren
2013-11-21 0:05 ` Tony Lindgren
2013-11-21 1:45 ` Tony Lindgren
2013-11-21 1:45 ` Tony Lindgren
2013-11-21 20:48 ` Tony Lindgren
2013-11-21 20:48 ` Tony Lindgren
2013-12-05 17:29 ` Tony Lindgren
2013-12-05 17:29 ` Tony Lindgren
2013-12-06 0:07 ` Paul Walmsley
2013-12-06 0:07 ` Paul Walmsley
2013-12-06 0:25 ` Tony Lindgren [this message]
2013-12-06 0:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206002547.GK26766@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.