From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/4] ARM: tegra: add I2C controllers to Tegra124 DT
Date: Fri, 6 Dec 2013 15:03:34 +0100 [thread overview]
Message-ID: <20131206140333.GE30960@ulmo.nvidia.com> (raw)
In-Reply-To: <1386196016-25128-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Wed, Dec 04, 2013 at 03:26:53PM -0700, Stephen Warren wrote:
[...]
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
[...]
> @@ -176,6 +176,96 @@
> status = "disabled";
> };
>
> + i2c@7000c000 {
> + compatible = "nvidia,tegra114-i2c";
Aren't we supposed to always list the most specific compatible as well,
just in case we ever need to implement a specific quirk in the future?
So this would become:
compatible = "nvidia,tegra124-i2c", "nvidia,tegra114-i2c";
Other than that, this is identical to a local patch that I have (minus
the reset* and dma* properties).
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: tegra: add I2C controllers to Tegra124 DT
Date: Fri, 6 Dec 2013 15:03:34 +0100 [thread overview]
Message-ID: <20131206140333.GE30960@ulmo.nvidia.com> (raw)
In-Reply-To: <1386196016-25128-1-git-send-email-swarren@wwwdotorg.org>
On Wed, Dec 04, 2013 at 03:26:53PM -0700, Stephen Warren wrote:
[...]
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
[...]
> @@ -176,6 +176,96 @@
> status = "disabled";
> };
>
> + i2c at 7000c000 {
> + compatible = "nvidia,tegra114-i2c";
Aren't we supposed to always list the most specific compatible as well,
just in case we ever need to implement a specific quirk in the future?
So this would become:
compatible = "nvidia,tegra124-i2c", "nvidia,tegra114-i2c";
Other than that, this is identical to a local patch that I have (minus
the reset* and dma* properties).
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131206/2f9dd0bd/attachment.sig>
next prev parent reply other threads:[~2013-12-06 14:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 22:26 [PATCH 1/4] ARM: tegra: add I2C controllers to Tegra124 DT Stephen Warren
2013-12-04 22:26 ` Stephen Warren
[not found] ` <1386196016-25128-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-04 22:26 ` [PATCH 2/4] ARM: tegra: enable I2C controllers on Venice2 Stephen Warren
2013-12-04 22:26 ` Stephen Warren
[not found] ` <1386196016-25128-2-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-06 15:20 ` Thierry Reding
2013-12-06 15:20 ` Thierry Reding
[not found] ` <20131206152021.GE32372-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-12-06 17:42 ` Stephen Warren
2013-12-06 17:42 ` Stephen Warren
2013-12-04 22:26 ` [PATCH 3/4] ARM: tegra: add audio-related device to Tegra124 DT Stephen Warren
2013-12-04 22:26 ` Stephen Warren
2013-12-04 22:26 ` [PATCH 4/4] ARM: tegra: add sound card to Venice2 DT Stephen Warren
2013-12-04 22:26 ` Stephen Warren
2013-12-06 14:03 ` Thierry Reding [this message]
2013-12-06 14:03 ` [PATCH 1/4] ARM: tegra: add I2C controllers to Tegra124 DT Thierry Reding
[not found] ` <20131206140333.GE30960-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-12-06 17:36 ` Stephen Warren
2013-12-06 17:36 ` Stephen Warren
2013-12-12 19:44 ` Stephen Warren
2013-12-12 19:44 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206140333.GE30960@ulmo.nvidia.com \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.