From: Thierry Reding <thierry.reding@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: swarren@wwwdotorg.org, dev@lynxeye.de, lee.jones@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org,
kai.poggensee@avionic-design.de, sameo@linux.intel.com,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/3] mfd: tps6586x: add version detection
Date: Fri, 6 Dec 2013 15:26:05 +0100 [thread overview]
Message-ID: <20131206142605.GA32363@ulmo.nvidia.com> (raw)
In-Reply-To: <7812fb79beac0a6a409090f43d129893f9f93b5b.1386333697.git.stefan@agner.ch>
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
On Fri, Dec 06, 2013 at 01:51:45PM +0100, Stefan Agner wrote:
> Use the VERSIONCRC to determine the exact device version. According to
> the datasheet this register can be used as device identifier. The
> identification is needed since some tps6586x regulators use a different
> voltage table.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Changes since v4:
> - Use variable named version instead of ret
>
> Changes since v2:
> - Avoid moving devm_kzalloc
> ---
> drivers/mfd/tps6586x.c | 50 +++++++++++++++++++++++++++++++++++++-------
> include/linux/mfd/tps6586x.h | 7 +++++++
> 2 files changed, 49 insertions(+), 8 deletions(-)
I think I also already gave my Reviewed-by on both this and 2/3, neither
of which changed significantly enough to warrant that to be dropped. In
general it's fine to keep Reviewed-by and Acked-by as long as you're
only changing minor things.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/3] mfd: tps6586x: add version detection
Date: Fri, 6 Dec 2013 15:26:05 +0100 [thread overview]
Message-ID: <20131206142605.GA32363@ulmo.nvidia.com> (raw)
In-Reply-To: <7812fb79beac0a6a409090f43d129893f9f93b5b.1386333697.git.stefan@agner.ch>
On Fri, Dec 06, 2013 at 01:51:45PM +0100, Stefan Agner wrote:
> Use the VERSIONCRC to determine the exact device version. According to
> the datasheet this register can be used as device identifier. The
> identification is needed since some tps6586x regulators use a different
> voltage table.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Changes since v4:
> - Use variable named version instead of ret
>
> Changes since v2:
> - Avoid moving devm_kzalloc
> ---
> drivers/mfd/tps6586x.c | 50 +++++++++++++++++++++++++++++++++++++-------
> include/linux/mfd/tps6586x.h | 7 +++++++
> 2 files changed, 49 insertions(+), 8 deletions(-)
I think I also already gave my Reviewed-by on both this and 2/3, neither
of which changed significantly enough to warrant that to be dropped. In
general it's fine to keep Reviewed-by and Acked-by as long as you're
only changing minor things.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131206/d8a623c3/attachment.sig>
next prev parent reply other threads:[~2013-12-06 14:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 12:51 [PATCH v5 0/3] regulator: tps6586x: add version detection and voltage tables Stefan Agner
2013-12-06 12:51 ` Stefan Agner
2013-12-06 12:51 ` Stefan Agner
[not found] ` <cover.1386333697.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-06 12:51 ` [PATCH v5 1/3] mfd: tps6586x: add version detection Stefan Agner
2013-12-06 12:51 ` Stefan Agner
2013-12-06 12:51 ` Stefan Agner
2013-12-06 14:26 ` Thierry Reding [this message]
2013-12-06 14:26 ` Thierry Reding
[not found] ` <20131206142605.GA32363-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-12-06 15:00 ` Stefan Agner
2013-12-06 15:00 ` Stefan Agner
2013-12-06 15:00 ` Stefan Agner
2013-12-06 15:36 ` Lee Jones
2013-12-06 15:36 ` Lee Jones
2013-12-06 15:34 ` Lee Jones
2013-12-06 15:34 ` Lee Jones
[not found] ` <7812fb79beac0a6a409090f43d129893f9f93b5b.1386333697.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-06 15:39 ` Lee Jones
2013-12-06 15:39 ` Lee Jones
2013-12-06 15:39 ` Lee Jones
2013-12-06 17:48 ` Stephen Warren
2013-12-06 17:48 ` Stephen Warren
2013-12-06 17:48 ` Stephen Warren
[not found] ` <CAF2Aj3i95j+ZG4gmpSS9Hq6AKXj6w7mB1psYQwT6oas3QfNBrA@mail.gmail.com>
[not found] ` <CAF2Aj3i95j+ZG4gmpSS9Hq6AKXj6w7mB1psYQwT6oas3QfNBrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-06 20:31 ` Stephen Warren
2013-12-06 20:31 ` Stephen Warren
2013-12-06 20:31 ` Stephen Warren
2013-12-06 12:51 ` [PATCH v5 2/3] regulator: tps6586x: add and use correct voltage table Stefan Agner
2013-12-06 12:51 ` Stefan Agner
[not found] ` <7c948660cda4684d28fa97f82295ab84f6ef658e.1386333697.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-06 12:55 ` Mark Brown
2013-12-06 12:55 ` Mark Brown
2013-12-06 12:55 ` Mark Brown
[not found] ` <20131206125502.GF29268-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-06 14:57 ` Stefan Agner
2013-12-06 14:57 ` Stefan Agner
2013-12-06 14:57 ` Stefan Agner
2013-12-06 15:40 ` Lee Jones
2013-12-06 15:40 ` Lee Jones
2013-12-06 15:40 ` Lee Jones
2013-12-06 12:51 ` [PATCH v5 3/3] ARM: tegra: correct Colibri T20 regulator settings Stefan Agner
2013-12-06 12:51 ` Stefan Agner
[not found] ` <47b41f2de9c2651fbd2cded53c634a533d2740c1.1386333697.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-12 20:16 ` Stephen Warren
2013-12-12 20:16 ` Stephen Warren
2013-12-12 20:16 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206142605.GA32363@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=broonie@kernel.org \
--cc=dev@lynxeye.de \
--cc=kai.poggensee@avionic-design.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=stefan@agner.ch \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.