From: Benjamin LaHaise <bcrl@kvack.org>
To: Dave Jones <davej@redhat.com>, Gu Zheng <guz.fnst@cn.fujitsu.com>,
linux-aio@kvack.org, fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Kent <kmo@daterainc.com>,
Kristian Nielsen <knielsen@knielsen-hq.org>
Subject: Re: [PATCH] aio: clean up aio ring in the fail path
Date: Fri, 6 Dec 2013 10:36:03 -0500 [thread overview]
Message-ID: <20131206153603.GE13581@kvack.org> (raw)
In-Reply-To: <20131206153413.GA31613@redhat.com>
On Fri, Dec 06, 2013 at 10:34:13AM -0500, Dave Jones wrote:
> On Fri, Dec 06, 2013 at 10:26:54AM -0500, Benjamin LaHaise wrote:
> > On Wed, Dec 04, 2013 at 06:19:06PM +0800, Gu Zheng wrote:
> > > Clean up the aio ring file in the fail path of aio_setup_ring
> > > and ioctx_alloc. And maybe it can fix the GPF issue reported by
> > > Dave Jones:
> > > https://lkml.org/lkml/2013/11/25/898
> >
> > Good catch. I've applied this to my aio-next tree. It does indeed look
> > like it could be the cause of Dave's GPF -- I'll try to trigger it with
> > some other kernel debug options on and see if the EAGAIN failure case can
> > trip it up.
>
> I think I forgot to reply and let you know this seems to fix it for me.
Excellent! I'll send this out and get it queued up for -stable as well.
-ben
> Dave
--
"Thought is the essence of where you are now."
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin LaHaise <bcrl@kvack.org>
To: Dave Jones <davej@redhat.com>, Gu Zheng <guz.fnst@cn.fujitsu.com>,
linux-aio@kvack.org, fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Kent <kmo@daterainc.com>,
Kristian Nielsen <knielsen@knielsen-hq.org>
Subject: Re: [PATCH] aio: clean up aio ring in the fail path
Date: Fri, 6 Dec 2013 10:36:03 -0500 [thread overview]
Message-ID: <20131206153603.GE13581@kvack.org> (raw)
In-Reply-To: <20131206153413.GA31613@redhat.com>
On Fri, Dec 06, 2013 at 10:34:13AM -0500, Dave Jones wrote:
> On Fri, Dec 06, 2013 at 10:26:54AM -0500, Benjamin LaHaise wrote:
> > On Wed, Dec 04, 2013 at 06:19:06PM +0800, Gu Zheng wrote:
> > > Clean up the aio ring file in the fail path of aio_setup_ring
> > > and ioctx_alloc. And maybe it can fix the GPF issue reported by
> > > Dave Jones:
> > > https://lkml.org/lkml/2013/11/25/898
> >
> > Good catch. I've applied this to my aio-next tree. It does indeed look
> > like it could be the cause of Dave's GPF -- I'll try to trigger it with
> > some other kernel debug options on and see if the EAGAIN failure case can
> > trip it up.
>
> I think I forgot to reply and let you know this seems to fix it for me.
Excellent! I'll send this out and get it queued up for -stable as well.
-ben
> Dave
--
"Thought is the essence of where you are now."
next prev parent reply other threads:[~2013-12-06 15:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 10:19 [PATCH] aio: clean up aio ring in the fail path Gu Zheng
2013-12-04 14:54 ` Dave Jones
2013-12-04 14:54 ` Dave Jones
2013-12-05 1:14 ` Gu Zheng
2013-12-05 1:14 ` Gu Zheng
2013-12-05 1:22 ` Gu Zheng
2013-12-05 1:22 ` Gu Zheng
2013-12-06 15:26 ` Benjamin LaHaise
2013-12-06 15:26 ` Benjamin LaHaise
2013-12-06 15:34 ` Dave Jones
2013-12-06 15:34 ` Dave Jones
2013-12-06 15:36 ` Benjamin LaHaise [this message]
2013-12-06 15:36 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206153603.GE13581@kvack.org \
--to=bcrl@kvack.org \
--cc=davej@redhat.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=kmo@daterainc.com \
--cc=knielsen@knielsen-hq.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.