From: Arnd Bergmann <arnd@arndb.de>
To: dinguyen@altera.com
Cc: dinh.linux@gmail.com, cjb@laptop.org, jh80.chung@samsung.com,
tgih.jun@samsung.com, heiko@sntech.de, dianders@chromium.org,
alim.akhtar@samsung.com, bzhao@marvell.com,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 0/2] mmc: dw_mmc: Make the use of the hold reg generic
Date: Fri, 6 Dec 2013 18:36:26 +0100 [thread overview]
Message-ID: <201312061836.26251.arnd@arndb.de> (raw)
In-Reply-To: <1386346223-18464-1-git-send-email-dinguyen@altera.com>
On Friday 06 December 2013, dinguyen@altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> Hi,
>
> This patch series makes the setting of the SDMMC_CMD_USE_HOLD_REG bit generic
> for all platforms that requires it. According the Synopsys spec on the dw_mmc,
> setting the SDMMC_CMD_USE_HOLD_REG should be done for all speeds except for the
> following higher speed modes: SDR104, SDR50, DDR50. I am also include MMC_HS200
> speed as not needing the SDMMC_CMD_USE_HOLD_REG bit set as well.
>
> Currently, Rockchip and SOCFPGA's variant of the dw_mmc requires that the
> SDMMC_CMD_USE_HOLD_REG be set. For SOCFPGA, the dw_mmc is operating at
> MMC_TIMING_SD_HS mode. I don't know Rockchip's variant is operating at.
>
Very nice, thanks for implementing this!
Acked-by: Arnd Bergmann <arnd@arndb.de>
Obviously this needs to be tested on at least the rockchips variant, but
ideally on most others too.
Arnd
next prev parent reply other threads:[~2013-12-06 17:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 16:10 [PATCH 0/2] mmc: dw_mmc: Make the use of the hold reg generic dinguyen
2013-12-06 16:10 ` [PATCH 1/2] mmc: dw_mmc: Enable the hold reg for certain speed modes dinguyen
2013-12-06 16:10 ` [PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure dinguyen
2013-12-06 23:14 ` Heiko Stübner
2013-12-06 23:18 ` Dinh Nguyen
2013-12-06 23:22 ` Heiko Stübner
2013-12-06 23:27 ` Dinh Nguyen
2013-12-07 0:12 ` Heiko Stübner
2013-12-06 17:36 ` Arnd Bergmann [this message]
2013-12-06 21:09 ` [PATCH 0/2] mmc: dw_mmc: Make the use of the hold reg generic Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312061836.26251.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alim.akhtar@samsung.com \
--cc=bzhao@marvell.com \
--cc=cjb@laptop.org \
--cc=dianders@chromium.org \
--cc=dinguyen@altera.com \
--cc=dinh.linux@gmail.com \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.