Re: [PATCH v5 2/5] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

On Tue, Nov 12, 2013 at 01:54:28PM +0100, Michal Nazarewicz wrote:
> On Tue, Nov 12 2013, David Cohen wrote:
> > On 11/11/2013 03:55 PM, Michal Nazarewicz wrote:
> >> Come to think of it, perhaps even better helper would be:
> >>
> >> static inline size_t usb_ep_align_maybe(
> >> 	struct usb_gadget *gadget, struct usb_ep *ep, size_t len) {
> >> 	return gadget->quir_ep_out_aligned_size ?
> >> 		round_up(len, (size_t)ep->desc->wMaxPacketSize) : len;
> >> }
> >
> > The CPU time to check unsigned:1 and possibly jump is about the same as
> > round_up() itself. For readability matters, we can round_up() directly.
> 
> I was proposing to have this function and than not have functions check
> for the flag.  I.e. instead of
> 
> 	if (gadget->quirk_ep_out_aligned_size)
> 		len = usb_ep_align_maxpacketsize(ep, len);
> 
> the code would just be:
> 
> 	len = usb_ep_align_maybe(gadget, ep, len);

that looks very good to me, do we have a version with that already ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]