From: David Cohen <david.a.cohen@linux.intel.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: balbi@ti.com, gregkh@linuxfoundation.org,
stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv5.1 4/5] check quirk to pad epout buf size when not aligned to maxpacketsize
Date: Mon, 11 Nov 2013 16:12:01 -0800 [thread overview]
Message-ID: <52817251.3040509@linux.intel.com> (raw)
In-Reply-To: <xa1ttxfiwkw0.fsf@mina86.com>
Hi Michal,
On 11/11/2013 03:58 PM, Michal Nazarewicz wrote:
> Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
> to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
> to pad epout buffer to match above condition if quirk is found.
>
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> drivers/usb/gadget/f_fs.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> On Tue, Nov 12 2013, David Cohen wrote:
>> One curiosity here. This patch prints the following warning:
>>
>> In file included from (...)/drivers/usb/gadget/g_ffs.c:55:0:
>> (...)/drivers/usb/gadget/f_fs.c: In function 'ffs_epfile_io.isra.18':
>> (...)/drivers/usb/gadget/f_fs.c:837:15: warning: 'data_len' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
>
> With the below code, this should no longer be a problem.
>
> Also fixes issues pointed out by Alan.
You need to update req->length otherwise it's going to crash DWC3.
I'd rather to keep your previous version.
Br, David
next prev parent reply other threads:[~2013-11-12 0:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 20:16 [PATCH v5 0/5] add gadget quirk to adapt f_fs for DWC3 David Cohen
2013-11-11 20:16 ` [PATCH v5 1/5] usb: gadget: move bitflags to the end of usb_gadget struct David Cohen
2013-11-11 23:52 ` Michal Nazarewicz
2013-11-11 20:16 ` [PATCH v5 2/5] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget David Cohen
2013-11-11 23:55 ` Michal Nazarewicz
2013-11-12 0:03 ` David Cohen
2013-11-12 12:54 ` Michal Nazarewicz
2013-12-06 20:13 ` Felipe Balbi
2013-12-06 20:14 ` David Cohen
2013-11-11 20:16 ` [PATCH v5 3/5] usb: gadget: f_fs: remove loop from I/O function David Cohen
2013-11-11 23:21 ` David Cohen
2013-11-11 23:57 ` [PATCHv5.1 " Michal Nazarewicz
2013-12-06 20:18 ` Felipe Balbi
2013-11-11 20:16 ` [PATCH v5 4/5] usb: f_fs: check quirk to pad epout buf size when not aligned to maxpacketsize David Cohen
2013-11-11 23:58 ` [PATCHv5.1 4/5] " Michal Nazarewicz
2013-11-12 0:12 ` David Cohen [this message]
2013-11-12 12:59 ` Michal Nazarewicz
2013-11-12 18:26 ` David Cohen
2013-12-06 20:19 ` Felipe Balbi
2013-11-11 20:16 ` [PATCH v5 5/5] usb: dwc3: set gadget's quirk ep_out_align_size David Cohen
2013-12-06 20:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52817251.3040509@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.