From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: add missing break to fuse initialization code
Date: Fri, 6 Dec 2013 22:09:57 +0100 [thread overview]
Message-ID: <20131206210957.GC1685@mithrandir> (raw)
In-Reply-To: <1386362030-29187-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
On Fri, Dec 06, 2013 at 01:33:50PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Add a missing break to the switch in tegra_init_fuse() which determines
> which SoC the code is running on. This prevents the Tegra30+ fuse
> handling code from running on Tegra20.
>
> Fixes: 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> This is a fix for 3.13.
>
> arch/arm/mach-tegra/fuse.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-tegra/fuse.c b/arch/arm/mach-tegra/fuse.c
> index 9a4e910c3796..13995b0be9d9 100644
> --- a/arch/arm/mach-tegra/fuse.c
> +++ b/arch/arm/mach-tegra/fuse.c
> @@ -198,6 +198,7 @@ void __init tegra_init_fuse(void)
> switch (tegra_chip_id) {
> case TEGRA20:
> tegra20_fuse_init_randomness();
> + break;
> case TEGRA30:
> case TEGRA114:
> default:
The code that follows here also doesn't have a break. While not strictly
necessary it might be good to have one for consistency. Either way,
though:
Reviewed-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: add missing break to fuse initialization code
Date: Fri, 6 Dec 2013 22:09:57 +0100 [thread overview]
Message-ID: <20131206210957.GC1685@mithrandir> (raw)
In-Reply-To: <1386362030-29187-1-git-send-email-swarren@wwwdotorg.org>
On Fri, Dec 06, 2013 at 01:33:50PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Add a missing break to the switch in tegra_init_fuse() which determines
> which SoC the code is running on. This prevents the Tegra30+ fuse
> handling code from running on Tegra20.
>
> Fixes: 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> This is a fix for 3.13.
>
> arch/arm/mach-tegra/fuse.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-tegra/fuse.c b/arch/arm/mach-tegra/fuse.c
> index 9a4e910c3796..13995b0be9d9 100644
> --- a/arch/arm/mach-tegra/fuse.c
> +++ b/arch/arm/mach-tegra/fuse.c
> @@ -198,6 +198,7 @@ void __init tegra_init_fuse(void)
> switch (tegra_chip_id) {
> case TEGRA20:
> tegra20_fuse_init_randomness();
> + break;
> case TEGRA30:
> case TEGRA114:
> default:
The code that follows here also doesn't have a break. While not strictly
necessary it might be good to have one for consistency. Either way,
though:
Reviewed-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131206/55e25ca4/attachment.sig>
next prev parent reply other threads:[~2013-12-06 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 20:33 [PATCH] ARM: tegra: add missing break to fuse initialization code Stephen Warren
2013-12-06 20:33 ` Stephen Warren
[not found] ` <1386362030-29187-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-06 21:09 ` Thierry Reding [this message]
2013-12-06 21:09 ` Thierry Reding
2013-12-12 1:08 ` Olof Johansson
2013-12-12 1:08 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206210957.GC1685@mithrandir \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.