From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/6] ARM: at91/dt: define sama5d3 clocks
Date: Mon, 9 Dec 2013 03:09:23 +0100 [thread overview]
Message-ID: <201312090309.23723.arnd@arndb.de> (raw)
In-Reply-To: <1385650228-8906-1-git-send-email-b.brezillon@overkiz.com>
On Thursday 28 November 2013, Boris BREZILLON wrote:
> @@ -92,6 +103,8 @@
> dma-names = "tx", "rx";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_spi0>;
> + clocks = <&spi0_clk>;
> + clock-names = "spi_clk";
> status = "disabled";
> };
>
> @@ -101,6 +114,8 @@
> interrupts = <38 IRQ_TYPE_LEVEL_HIGH 4>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ssc0_tx &pinctrl_ssc0_rx>;
> + clocks = <&ssc0_clk>;
> + clock-names = "pclk";
> status = "disabled";
> };
>
You are adding "clock-names" properties in a lot of cases. Are you sure you
are using the strings that are documented in the respective device bindings
for each name? In a lot of cases, drivers just want an anonymous clock
and we don't name them.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Boris BREZILLON
<b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 3/6] ARM: at91/dt: define sama5d3 clocks
Date: Mon, 9 Dec 2013 03:09:23 +0100 [thread overview]
Message-ID: <201312090309.23723.arnd@arndb.de> (raw)
In-Reply-To: <1385650228-8906-1-git-send-email-b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>
On Thursday 28 November 2013, Boris BREZILLON wrote:
> @@ -92,6 +103,8 @@
> dma-names = "tx", "rx";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_spi0>;
> + clocks = <&spi0_clk>;
> + clock-names = "spi_clk";
> status = "disabled";
> };
>
> @@ -101,6 +114,8 @@
> interrupts = <38 IRQ_TYPE_LEVEL_HIGH 4>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ssc0_tx &pinctrl_ssc0_rx>;
> + clocks = <&ssc0_clk>;
> + clock-names = "pclk";
> status = "disabled";
> };
>
You are adding "clock-names" properties in a lot of cases. Are you sure you
are using the strings that are documented in the respective device bindings
for each name? In a lot of cases, drivers just want an anonymous clock
and we don't name them.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Boris BREZILLON <b.brezillon@overkiz.com>,
Russell King <linux@arm.linux.org.uk>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Mike Turquette <mturquette@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/6] ARM: at91/dt: define sama5d3 clocks
Date: Mon, 9 Dec 2013 03:09:23 +0100 [thread overview]
Message-ID: <201312090309.23723.arnd@arndb.de> (raw)
In-Reply-To: <1385650228-8906-1-git-send-email-b.brezillon@overkiz.com>
On Thursday 28 November 2013, Boris BREZILLON wrote:
> @@ -92,6 +103,8 @@
> dma-names = "tx", "rx";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_spi0>;
> + clocks = <&spi0_clk>;
> + clock-names = "spi_clk";
> status = "disabled";
> };
>
> @@ -101,6 +114,8 @@
> interrupts = <38 IRQ_TYPE_LEVEL_HIGH 4>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ssc0_tx &pinctrl_ssc0_rx>;
> + clocks = <&ssc0_clk>;
> + clock-names = "pclk";
> status = "disabled";
> };
>
You are adding "clock-names" properties in a lot of cases. Are you sure you
are using the strings that are documented in the respective device bindings
for each name? In a lot of cases, drivers just want an anonymous clock
and we don't name them.
Arnd
next prev parent reply other threads:[~2013-12-09 2:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 14:49 [PATCH v4 0/6] ARM: at91: use new at91 clks for samad3 SoCs Boris BREZILLON
2013-11-28 14:49 ` Boris BREZILLON
2013-11-28 14:49 ` Boris BREZILLON
2013-11-28 14:50 ` [PATCH v4 1/6] ARM: at91: prepare sama5 dt boards transition to common clk Boris BREZILLON
2013-11-28 14:50 ` Boris BREZILLON
2013-11-28 14:50 ` Boris BREZILLON
2013-11-28 14:50 ` [PATCH v4 2/6] ARM: at91: prepare common clk transition for sama5d3 SoC Boris BREZILLON
2013-11-28 14:50 ` Boris BREZILLON
2013-11-28 14:50 ` Boris BREZILLON
2013-11-28 14:50 ` [PATCH v4 3/6] ARM: at91/dt: define sama5d3 clocks Boris BREZILLON
2013-11-28 14:50 ` Boris BREZILLON
2013-11-28 14:50 ` Boris BREZILLON
2013-12-09 2:09 ` Arnd Bergmann [this message]
2013-12-09 2:09 ` Arnd Bergmann
2013-12-09 2:09 ` Arnd Bergmann
2013-12-09 8:43 ` boris brezillon
2013-12-09 8:43 ` boris brezillon
2013-12-09 8:43 ` boris brezillon
2013-12-09 15:48 ` Arnd Bergmann
2013-12-09 15:48 ` Arnd Bergmann
2013-12-09 15:48 ` Arnd Bergmann
2013-12-09 16:17 ` boris brezillon
2013-12-09 16:17 ` boris brezillon
2013-12-09 16:17 ` boris brezillon
2013-12-09 16:48 ` Arnd Bergmann
2013-12-09 16:48 ` Arnd Bergmann
2013-12-09 16:48 ` Arnd Bergmann
2013-12-09 17:02 ` boris brezillon
2013-12-09 17:02 ` boris brezillon
2013-12-09 21:05 ` Arnd Bergmann
2013-12-09 21:05 ` Arnd Bergmann
2013-12-09 21:05 ` Arnd Bergmann
2013-11-28 14:50 ` [PATCH v4 4/6] ARM: at91/dt: define sama5d3xek's main clk frequency Boris BREZILLON
2013-11-28 14:50 ` Boris BREZILLON
2013-11-28 14:51 ` [PATCH v4 5/6] ARM: at91: move sama5d3 SoC to common clk Boris BREZILLON
2013-11-28 14:51 ` Boris BREZILLON
2013-11-28 14:51 ` Boris BREZILLON
2013-11-28 14:52 ` [PATCH v4 6/6] ARM: at91/dt: remove old clk material Boris BREZILLON
2013-11-28 14:52 ` Boris BREZILLON
2013-12-02 14:35 ` [PATCH v4 0/6] ARM: at91: use new at91 clks for samad3 SoCs Nicolas Ferre
2013-12-02 14:35 ` Nicolas Ferre
2013-12-02 14:35 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312090309.23723.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.