From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jan Vcelak <jan.vcelak@nic.cz>
Cc: lenb@kernel.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: full battery charge cannot exceed current one
Date: Mon, 9 Dec 2013 17:02:14 +0000 [thread overview]
Message-ID: <20131209170214.GB30717@srcf.ucam.org> (raw)
In-Reply-To: <1386419801-10091-1-git-send-email-jan.vcelak@nic.cz>
On Sat, Dec 07, 2013 at 01:36:41PM +0100, Jan Vcelak wrote:
> Some degraded batteries report maximal capacity to be smaller than
> current charge of the battery. This can confuse some user space
> applications (like upower).
Can't we just fix upower?
> +
> + /* Some degraded batteries report lower full charge than current one. */
> + if (battery->capacity_now > battery->full_charge_capacity)
> + battery->full_charge_capacity = battery->capacity_now;
> +
Does upower read *_full on every read of the value? How do we guarantee
that it won't read energy_now without updating energy_full and still
come up with an incorrect calculation?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-12-09 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 12:36 [PATCH] ACPI: full battery charge cannot exceed current one Jan Vcelak
2013-12-09 17:02 ` Matthew Garrett [this message]
2013-12-09 22:25 ` Jan Včelák
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209170214.GB30717@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jan.vcelak@nic.cz \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.