From: Tony Lindgren <tony@atomide.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Felipe Balbi <balbi@ti.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy
Date: Mon, 9 Dec 2013 09:40:00 -0800 [thread overview]
Message-ID: <20131209174000.GA12527@atomide.com> (raw)
In-Reply-To: <CABxcv=kYAB5MKtW0O1RLZUXPxiTmoSDD0nuHB=Bjy2gy+wzvhQ@mail.gmail.com>
* Javier Martinez Canillas <javier@dowhile0.org> [131209 03:51]:
> Hi Kishon,
>
> On Mon, Dec 9, 2013 at 7:07 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> > Hi,
> >
> >
> > On Saturday 07 December 2013 02:38 AM, Felipe Balbi wrote:
> >>
> >> Hi,
> >>
> >> On Fri, Dec 06, 2013 at 01:14:38PM +0100, Javier Martinez Canillas wrote:
> >>>
> >>> On Fri, Dec 6, 2013 at 1:06 PM, Kishon Vijay Abraham I <kishon@ti.com>
> >>> wrote:
> >>>>
> >>>> Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while
> >>>> creating
> >>>> MUSB core device. So in usb_bind_phy (binds the controller with the
> >>>> PHY), the
> >>>> device name of the controller had *.auto* in it. Since with using
> >>>> PLATFORM_DEVID_AUTO, there is no way to know the exact device name in
> >>>> advance,
> >>>> the data given in usb_bind_phy became obsolete and usb_get_phy was
> >>>> failing.
> >>>> So MUSB wrapper was modified not to use PLATFORM_DEVID_AUTO.
> >>>> Corresponding
> >>>> change is done in board file here.
> >>>>
> >>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> >>>> ---
> >>>> arch/arm/mach-omap2/board-2430sdp.c | 2 +-
> >>>> arch/arm/mach-omap2/board-3430sdp.c | 2 +-
> >>>> arch/arm/mach-omap2/board-cm-t35.c | 2 +-
> >>>> arch/arm/mach-omap2/board-devkit8000.c | 2 +-
> >>>> arch/arm/mach-omap2/board-ldp.c | 2 +-
> >>>> arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
> >>>> arch/arm/mach-omap2/board-omap3logic.c | 2 +-
> >>>> arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
> >>>> arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
> >>>> arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
> >>>> arch/arm/mach-omap2/board-overo.c | 2 +-
> >>>> arch/arm/mach-omap2/board-rx51.c | 2 +-
> >>>> 12 files changed, 12 insertions(+), 12 deletions(-)
> >>>>
> >>>
> >>> You can drop this patch since boards files are being removed for v3.14
> >>
> >>
> >> if we can drop this patch, the whole series is invalid, since we'll be
> >> using DT phandles to find PHYs going forward, no ?
> >>
> > yeah. But in one of the other threads, Tony seemed ok to take a patch that
> > fixes the same issue in mach-omap2/twl-common.c. So it's better to confirm
> > with Tony.
> >
>
> Yes, I just read the other thread ("[PATCH] omap: twl-common: Fix
> musb-hdrc device name") and I see that these patches are fixing a
> v3.13 regression and are meant for the -rc cycle and not for v3.14.
Sorry guys, I'm a bit lost with these USB regression fixes.
Which regression fix do we need for v3.13-rc series?
If there's an option, I'd rather not touch all the board-*.c files as
those are about to get dropped for v3.14.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy
Date: Mon, 9 Dec 2013 09:40:00 -0800 [thread overview]
Message-ID: <20131209174000.GA12527@atomide.com> (raw)
In-Reply-To: <CABxcv=kYAB5MKtW0O1RLZUXPxiTmoSDD0nuHB=Bjy2gy+wzvhQ@mail.gmail.com>
* Javier Martinez Canillas <javier@dowhile0.org> [131209 03:51]:
> Hi Kishon,
>
> On Mon, Dec 9, 2013 at 7:07 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> > Hi,
> >
> >
> > On Saturday 07 December 2013 02:38 AM, Felipe Balbi wrote:
> >>
> >> Hi,
> >>
> >> On Fri, Dec 06, 2013 at 01:14:38PM +0100, Javier Martinez Canillas wrote:
> >>>
> >>> On Fri, Dec 6, 2013 at 1:06 PM, Kishon Vijay Abraham I <kishon@ti.com>
> >>> wrote:
> >>>>
> >>>> Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while
> >>>> creating
> >>>> MUSB core device. So in usb_bind_phy (binds the controller with the
> >>>> PHY), the
> >>>> device name of the controller had *.auto* in it. Since with using
> >>>> PLATFORM_DEVID_AUTO, there is no way to know the exact device name in
> >>>> advance,
> >>>> the data given in usb_bind_phy became obsolete and usb_get_phy was
> >>>> failing.
> >>>> So MUSB wrapper was modified not to use PLATFORM_DEVID_AUTO.
> >>>> Corresponding
> >>>> change is done in board file here.
> >>>>
> >>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> >>>> ---
> >>>> arch/arm/mach-omap2/board-2430sdp.c | 2 +-
> >>>> arch/arm/mach-omap2/board-3430sdp.c | 2 +-
> >>>> arch/arm/mach-omap2/board-cm-t35.c | 2 +-
> >>>> arch/arm/mach-omap2/board-devkit8000.c | 2 +-
> >>>> arch/arm/mach-omap2/board-ldp.c | 2 +-
> >>>> arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
> >>>> arch/arm/mach-omap2/board-omap3logic.c | 2 +-
> >>>> arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
> >>>> arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
> >>>> arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
> >>>> arch/arm/mach-omap2/board-overo.c | 2 +-
> >>>> arch/arm/mach-omap2/board-rx51.c | 2 +-
> >>>> 12 files changed, 12 insertions(+), 12 deletions(-)
> >>>>
> >>>
> >>> You can drop this patch since boards files are being removed for v3.14
> >>
> >>
> >> if we can drop this patch, the whole series is invalid, since we'll be
> >> using DT phandles to find PHYs going forward, no ?
> >>
> > yeah. But in one of the other threads, Tony seemed ok to take a patch that
> > fixes the same issue in mach-omap2/twl-common.c. So it's better to confirm
> > with Tony.
> >
>
> Yes, I just read the other thread ("[PATCH] omap: twl-common: Fix
> musb-hdrc device name") and I see that these patches are fixing a
> v3.13 regression and are meant for the -rc cycle and not for v3.14.
Sorry guys, I'm a bit lost with these USB regression fixes.
Which regression fix do we need for v3.13-rc series?
If there's an option, I'd rather not touch all the board-*.c files as
those are about to get dropped for v3.14.
Regards,
Tony
next prev parent reply other threads:[~2013-12-09 17:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 12:06 [PATCH v2 0/2] usb: fix controller-PHY binding for OMAP3 platform Kishon Vijay Abraham I
2013-12-06 12:06 ` Kishon Vijay Abraham I
2013-12-06 12:06 ` Kishon Vijay Abraham I
2013-12-06 12:06 ` [PATCH v2 1/2] usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c Kishon Vijay Abraham I
2013-12-06 12:06 ` Kishon Vijay Abraham I
2013-12-06 12:06 ` Kishon Vijay Abraham I
2013-12-06 12:06 ` [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy Kishon Vijay Abraham I
2013-12-06 12:06 ` Kishon Vijay Abraham I
2013-12-06 12:06 ` Kishon Vijay Abraham I
2013-12-06 12:14 ` Javier Martinez Canillas
2013-12-06 12:14 ` Javier Martinez Canillas
2013-12-06 21:08 ` Felipe Balbi
2013-12-06 21:08 ` Felipe Balbi
2013-12-06 21:08 ` Felipe Balbi
2013-12-09 6:07 ` Kishon Vijay Abraham I
2013-12-09 6:07 ` Kishon Vijay Abraham I
2013-12-09 6:07 ` Kishon Vijay Abraham I
[not found] ` <52A55E2C.7070500-l0cyMroinI0@public.gmane.org>
2013-12-09 11:50 ` Javier Martinez Canillas
2013-12-09 11:50 ` Javier Martinez Canillas
2013-12-09 11:50 ` Javier Martinez Canillas
2013-12-09 17:40 ` Tony Lindgren [this message]
2013-12-09 17:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209174000.GA12527@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier@dowhile0.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.