All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: "Asano, Yasushi" <yasushi.asano@jp.fujitsu.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] ipv6 addrconf:fix preferred lifetime state-changing behavior while valid_lft is infinity
Date: Tue, 10 Dec 2013 00:47:04 +0100	[thread overview]
Message-ID: <20131209234704.GF7396@order.stressinduktion.org> (raw)
In-Reply-To: <4AE7B88EC8BA74469869BB7EEB7D66671BF656D2@g01jpexmbyt23>

On Mon, Dec 09, 2013 at 05:54:37AM +0000, Asano, Yasushi wrote:
> from: Yasushi Asano  <yasushi.asano@jp.fujitsu.com>
> 
> There is a problem when setting the lifetime of an IPv6 address.
> When I set preferred_lft to a value not zero or infinity, while valid_lft is infinity(0xffffffff)
> preferred lifetime is set to forever and does not update.
> Therefore preferred lifetime never becomes deprecated.
> 
> I think valid lifetime and preferred lifetime should be set independently,
> even if valid lifetime is infinity, preferred lifetime must expire correctly (meaning it must eventually become deprecated)
> 
> I made a patch for 3.12 stable to solve the problem.

This indeed could be improved. Thanks for the patch. But you should base
it on net-next so it can be applied and please clean up the warnings
and errors if you run the patch through ./scripts/checkpatch --strict.

Thank you,

  Hannes

  reply	other threads:[~2013-12-09 23:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  5:54 [PATCH 1/1] ipv6 addrconf:fix preferred lifetime state-changing behavior while valid_lft is infinity Asano, Yasushi
2013-12-09 23:47 ` Hannes Frederic Sowa [this message]
2013-12-12  0:58   ` Asano, Yasushi
2013-12-12  1:03     ` Hannes Frederic Sowa
2013-12-12 10:01       ` yazzep
2013-12-12 17:19         ` David Miller
2013-12-12 10:15       ` yazzep
2013-12-12 14:06         ` Sergei Shtylyov
2013-12-13 17:33         ` yazzep
2013-12-14  9:19           ` Hannes Frederic Sowa
2013-12-14  9:22             ` Hannes Frederic Sowa
2013-12-29  5:57             ` Asano, Yasushi
2013-12-29  7:34             ` [PATCH] " yasushi.asano
2013-12-29  7:47             ` yazzep
2013-12-29 15:32               ` Hannes Frederic Sowa
2013-12-30  2:17               ` Hannes Frederic Sowa
2013-12-31  3:04                 ` [PATCH] ipv6 addrconf: fix " Yasushi Asano
2013-12-31 19:05                   ` Hannes Frederic Sowa
2014-01-03  0:35                   ` David Miller
2013-12-29 12:04             ` [PATCH 1/1] ipv6 addrconf:fix " Yasushi Asano
2013-12-12 10:46       ` Asano, Yasushi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131209234704.GF7396@order.stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    --cc=yasushi.asano@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.