From: "Heiko Stübner" <heiko@sntech.de>
To: Tomasz Figa <t.figa@samsung.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
mturquette@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Thomas Abraham <thomas.abraham@linaro.org>
Subject: Re: [PATCH v3 5/5] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework
Date: Tue, 10 Dec 2013 11:57:07 +0100 [thread overview]
Message-ID: <201312101157.08297.heiko@sntech.de> (raw)
In-Reply-To: <4563504.qD7ztRvaeD@amdc1227>
Hi Tomasz,
Am Montag, 9. Dezember 2013, 18:19:16 schrieb Tomasz Figa:
> > diff --git a/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
> > b/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c index f50454a..0a86953 100644
> > --- a/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
> > +++ b/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
[...]
> > @@ -86,6 +50,5 @@ DT_MACHINE_START(S3C2416_DT, "Samsung S3C2416
> > (Flattened Device Tree)")
> >
> > .map_io = s3c2416_dt_map_io,
> > .init_irq = irqchip_init,
> > .init_machine = s3c2416_dt_machine_init,
> >
> > - .init_time = clocksource_of_init,
>
> Should it really be a part of this patch?
Yes it is needed as part of the conversion, as somebody has to call
of_clk_init(), which the init_time default-handler does.
The only other option would be to introduce a new local init_time callback,
calling of_clk_init and clocksource_of_init, only to remove it again in an
additional patch.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/5] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework
Date: Tue, 10 Dec 2013 11:57:07 +0100 [thread overview]
Message-ID: <201312101157.08297.heiko@sntech.de> (raw)
In-Reply-To: <4563504.qD7ztRvaeD@amdc1227>
Hi Tomasz,
Am Montag, 9. Dezember 2013, 18:19:16 schrieb Tomasz Figa:
> > diff --git a/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
> > b/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c index f50454a..0a86953 100644
> > --- a/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
> > +++ b/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
[...]
> > @@ -86,6 +50,5 @@ DT_MACHINE_START(S3C2416_DT, "Samsung S3C2416
> > (Flattened Device Tree)")
> >
> > .map_io = s3c2416_dt_map_io,
> > .init_irq = irqchip_init,
> > .init_machine = s3c2416_dt_machine_init,
> >
> > - .init_time = clocksource_of_init,
>
> Should it really be a part of this patch?
Yes it is needed as part of the conversion, as somebody has to call
of_clk_init(), which the init_time default-handler does.
The only other option would be to introduce a new local init_time callback,
calling of_clk_init and clocksource_of_init, only to remove it again in an
additional patch.
Heiko
next prev parent reply other threads:[~2013-12-10 10:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 15:19 [PATCH v3 0/5] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework Heiko Stübner
2013-12-03 15:19 ` Heiko Stübner
2013-12-03 15:20 ` [PATCH v3 1/5] clk: samsung: add pll_6552 variant for s3c2416 Heiko Stübner
2013-12-03 15:20 ` Heiko Stübner
2013-12-03 15:21 ` [PATCH v3 2/5] clk: samsung: add plls used by the s3c2443 Heiko Stübner
2013-12-03 15:21 ` Heiko Stübner
2013-12-03 15:23 ` [PATCH v3 3/5] dt-bindings: add binding for clock-controller of s3c2443 and following Heiko Stübner
2013-12-03 15:23 ` Heiko Stübner
2013-12-09 17:03 ` Tomasz Figa
2013-12-09 17:03 ` Tomasz Figa
2013-12-03 15:23 ` [PATCH v3 4/5] clk: samsung: add clock-driver for s3c2416, s3c2443 and s3c2450 Heiko Stübner
2013-12-03 15:23 ` Heiko Stübner
2013-12-03 15:24 ` [PATCH v3 5/5] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework Heiko Stübner
2013-12-03 15:24 ` Heiko Stübner
2013-12-09 17:19 ` Tomasz Figa
2013-12-09 17:19 ` Tomasz Figa
2013-12-10 10:57 ` Heiko Stübner [this message]
2013-12-10 10:57 ` Heiko Stübner
2013-12-09 17:20 ` [PATCH v3 0/5] " Tomasz Figa
2013-12-09 17:20 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312101157.08297.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.