All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Peter Chubb <peter.chubb@nicta.com.au>
Cc: alexander.deucher@amd.com, dri-devel@lists.freedesktop.org
Subject: Re: Can no longer shutdown after  drm/radeon: Implement radeon_pci_shutdown
Date: Wed, 11 Dec 2013 08:26:58 +0100	[thread overview]
Message-ID: <20131211072658.GA273@x4> (raw)
In-Reply-To: <84mwk86x5a.wl%peter.chubb@nicta.com.au>

On 2013.12.11 at 11:37 +1100, Peter Chubb wrote:
> On my HP Elitebook 8740w qith a Mobility Radeon HD 5870
> commit 846ae41ae99d314bf2a02784152208a6ddf7eddc
> breaks shutdown.  The machine hangs when trying to shutdown, kexec or
> hibernate, before seeing the usual `machine halted' (or whatever) message.
> 
> If I comment out thus:
> 
> index 9f5ff28..40bff3c 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -514,7 +514,7 @@ radeon_pci_shutdown(struct pci_dev *pdev)
>  {
>  	struct drm_device *dev = pci_get_drvdata(pdev);
>  
> -	radeon_driver_unload_kms(dev);
> +	/*radeon_driver_unload_kms(dev);*/
>  }
>  
> then everything works again.  Thsi is obviously not the proper fix.

It would be interesting to know where exactly it hangs.
Could you comment out the *_fini(rdev) calls in radeon_driver_unload_kms
(drivers/gpu/drm/radeon/radeon_kms.c) one after the other to find out
which one is responsible? 

-- 
Markus

  reply	other threads:[~2013-12-11  7:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11  0:37 Can no longer shutdown after drm/radeon: Implement radeon_pci_shutdown Peter Chubb
2013-12-11  7:26 ` Markus Trippelsdorf [this message]
2013-12-11 22:11   ` Peter Chubb
2013-12-11 23:46     ` Deucher, Alexander
2013-12-12  0:04       ` Peter Chubb
2013-12-12  2:58       ` Markus Trippelsdorf
2013-12-12  3:10         ` Peter Chubb
2013-12-12  3:27         ` Deucher, Alexander
2013-12-12 13:56           ` Markus Trippelsdorf
2013-12-12 14:11             ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131211072658.GA273@x4 \
    --to=markus@trippelsdorf.de \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=peter.chubb@nicta.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.