From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Paul Walmsley <pwalmsley-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "Mikko Perttunen"
<mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Arto Merilainen"
<amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Thierry Reding"
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Terje Bergström"
<tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] gpu: host1x: clk_round_rate() can return a zero upon error
Date: Wed, 11 Dec 2013 08:51:17 +0100 [thread overview]
Message-ID: <20131211075117.GA24559@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1312091746400.4127@tamien>
On Mon, Dec 09, 2013 at 06:00:12PM -0800, Paul Walmsley wrote:
>
> Treat both negative and zero return values from clk_round_rate() as
> errors. This is needed since subsequent patches will convert
> clk_round_rate()'s return value to be an unsigned type, rather than a
> signed type, since some clock sources can generate rates higher than
> (2^31)-1 Hz.
>
> Eventually, when calling clk_round_rate(), only a return value of zero
> will be considered a error. All other values will be considered valid
> rates. The comparison against values less than 0 is kept to preserve
> the correct behavior in the meantime.
Shouldn't it be an error when the result is not within sensible limits
instead? What do you do with a rate of 1Hz?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Paul Walmsley <pwalmsley@nvidia.com>
Cc: "Mikko Perttunen" <mperttunen@nvidia.com>,
"Arto Merilainen" <amerilainen@nvidia.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Terje Bergström" <tbergstrom@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] gpu: host1x: clk_round_rate() can return a zero upon error
Date: Wed, 11 Dec 2013 08:51:17 +0100 [thread overview]
Message-ID: <20131211075117.GA24559@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1312091746400.4127@tamien>
On Mon, Dec 09, 2013 at 06:00:12PM -0800, Paul Walmsley wrote:
>
> Treat both negative and zero return values from clk_round_rate() as
> errors. This is needed since subsequent patches will convert
> clk_round_rate()'s return value to be an unsigned type, rather than a
> signed type, since some clock sources can generate rates higher than
> (2^31)-1 Hz.
>
> Eventually, when calling clk_round_rate(), only a return value of zero
> will be considered a error. All other values will be considered valid
> rates. The comparison against values less than 0 is kept to preserve
> the correct behavior in the meantime.
Shouldn't it be an error when the result is not within sensible limits
instead? What do you do with a rate of 1Hz?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-12-11 7:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 2:00 [PATCH] gpu: host1x: clk_round_rate() can return a zero upon error Paul Walmsley
2013-12-10 2:00 ` Paul Walmsley
2013-12-11 7:51 ` Sascha Hauer [this message]
2013-12-11 7:51 ` Sascha Hauer
[not found] ` <20131211075117.GA24559-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-12-11 7:55 ` Paul Walmsley
2013-12-11 7:55 ` Paul Walmsley
2013-12-11 15:19 ` Thierry Reding
2013-12-11 15:19 ` Thierry Reding
2013-12-11 19:15 ` Paul Walmsley
2013-12-12 11:03 ` Thierry Reding
2013-12-12 11:03 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211075117.GA24559@pengutronix.de \
--to=s.hauer-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=pwalmsley-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.