From: Mel Gorman <mgorman@suse.de>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v5 4/8] sched/numa: fix set cpupid on page migration twice against normal page
Date: Wed, 11 Dec 2013 09:01:24 +0000 [thread overview]
Message-ID: <20131211090124.GR11295@suse.de> (raw)
In-Reply-To: <1386723001-25408-5-git-send-email-liwanp@linux.vnet.ibm.com>
On Wed, Dec 11, 2013 at 08:49:57AM +0800, Wanpeng Li wrote:
> commit 7851a45cd3 (mm: numa: Copy cpupid on page migration) copy over
> the cpupid at page migration time, there is unnecessary to set it again
> in function alloc_misplaced_dst_page, this patch fix it.
>
> Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
migratepages aops is not necessarily required to go through migrate_page_copy
but in practice all of them do and it's hard to imagine one that didn't
so.
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v5 4/8] sched/numa: fix set cpupid on page migration twice against normal page
Date: Wed, 11 Dec 2013 09:01:24 +0000 [thread overview]
Message-ID: <20131211090124.GR11295@suse.de> (raw)
In-Reply-To: <1386723001-25408-5-git-send-email-liwanp@linux.vnet.ibm.com>
On Wed, Dec 11, 2013 at 08:49:57AM +0800, Wanpeng Li wrote:
> commit 7851a45cd3 (mm: numa: Copy cpupid on page migration) copy over
> the cpupid at page migration time, there is unnecessary to set it again
> in function alloc_misplaced_dst_page, this patch fix it.
>
> Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
migratepages aops is not necessarily required to go through migrate_page_copy
but in practice all of them do and it's hard to imagine one that didn't
so.
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2013-12-11 9:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 0:49 [PATCH v5 0/8] mm: sched: numa: several fixups Wanpeng Li
2013-12-11 0:49 ` Wanpeng Li
2013-12-11 0:49 ` [PATCH v5 1/8] sched/numa: fix set cpupid on page migration twice against thp Wanpeng Li
2013-12-11 0:49 ` Wanpeng Li
2013-12-11 0:49 ` [PATCH v5 2/8] sched/numa: drop sysctl_numa_balancing_settle_count sysctl Wanpeng Li
2013-12-11 0:49 ` Wanpeng Li
2013-12-11 0:49 ` [PATCH v5 3/8] sched/numa: use wrapper function task_node to get node which task is on Wanpeng Li
2013-12-11 0:49 ` Wanpeng Li
2013-12-11 0:49 ` [PATCH v5 4/8] sched/numa: fix set cpupid on page migration twice against normal page Wanpeng Li
2013-12-11 0:49 ` Wanpeng Li
2013-12-11 9:01 ` Mel Gorman [this message]
2013-12-11 9:01 ` Mel Gorman
2013-12-11 0:49 ` [PATCH v5 5/8] sched/numa: use wrapper function task_faults_idx to calculate index in group_faults Wanpeng Li
2013-12-11 0:49 ` Wanpeng Li
2013-12-11 9:02 ` Mel Gorman
2013-12-11 9:02 ` Mel Gorman
2013-12-11 0:49 ` [PATCH v5 6/8] sched/numa: fix period_slot recalculation Wanpeng Li
2013-12-11 0:49 ` Wanpeng Li
2013-12-11 9:02 ` Mel Gorman
2013-12-11 9:02 ` Mel Gorman
2013-12-11 0:50 ` [PATCH v5 7/8] sched/numa: fix record hinting faults check Wanpeng Li
2013-12-11 0:50 ` Wanpeng Li
2013-12-11 9:14 ` Mel Gorman
2013-12-11 9:14 ` Mel Gorman
2013-12-11 9:41 ` Wanpeng Li
[not found] ` <20131211094156.GB26093@hacker.(null)>
2013-12-11 10:15 ` Mel Gorman
2013-12-11 10:15 ` Mel Gorman
2013-12-11 0:50 ` [PATCH v5 8/8] sched/numa: drop unnecessary variable in task_weight Wanpeng Li
2013-12-11 0:50 ` Wanpeng Li
2013-12-11 9:21 ` Mel Gorman
2013-12-11 9:21 ` Mel Gorman
2013-12-11 9:34 ` Wanpeng Li
2013-12-11 14:50 ` Naoya Horiguchi
2013-12-11 14:50 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211090124.GR11295@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mingo@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.