From: Olof Johansson <olof@lixom.net>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, khilman@linaro.org, arnd@arndb.de,
linux-sh@vger.kernel.org, daniel.lezcano@linaro.org,
horms@verge.net.au, john.stultz@linaro.org, tglx@linutronix.de
Subject: Re: [PATCH v4 01/03] clocksource: Add Kconfig entries for CMT, MTU2, TMU and STI
Date: Thu, 12 Dec 2013 01:05:03 +0000 [thread overview]
Message-ID: <20131212010503.GI21531@quad.lixom.net> (raw)
In-Reply-To: <20131211235626.12661.8865.sendpatchset@w520>
Hi,
A couple of small comments below.
On Thu, Dec 12, 2013 at 08:56:26AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Add Kconfig entries for CMT, MTU2, TMU and STI to
> drivers/clocksource/Kconfig. This will allow us to
> get rid of duplicated entires in architecture code
> such as arch/sh and arch/arm/mach-shmobile.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> drivers/clocksource/Kconfig | 44 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> --- 0001/drivers/clocksource/Kconfig
> +++ work/drivers/clocksource/Kconfig 2013-12-12 08:41:55.000000000 +0900
> @@ -134,3 +134,47 @@ config VF_PIT_TIMER
> bool
> help
> Support for Period Interrupt Timer on Freescale Vybrid Family SoCs.
> +
> +config SYS_SUPPORTS_CMT
> + bool
> +
> +config SYS_SUPPORTS_TMU
> + bool
> +
> +config SYS_SUPPORTS_MTU2
> + bool
> +
> +config SYS_SUPPORTS_STI
> + bool
Maybe a prefix to avoid namespace collissions here?
> +
> +config SH_TIMER_CMT
> + bool "Renesas CMT timer driver" if COMPILE_TEST
> + default SYS_SUPPORTS_CMT
It might be useful to have an explicit depends on ARCH_SH || ARCH_SHMOBILE
|| COMPILE_TEST on these, just to make it easier for someone reading
the code later on.
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, khilman@linaro.org, arnd@arndb.de,
linux-sh@vger.kernel.org, daniel.lezcano@linaro.org,
horms@verge.net.au, john.stultz@linaro.org, tglx@linutronix.de
Subject: Re: [PATCH v4 01/03] clocksource: Add Kconfig entries for CMT, MTU2, TMU and STI
Date: Wed, 11 Dec 2013 17:05:03 -0800 [thread overview]
Message-ID: <20131212010503.GI21531@quad.lixom.net> (raw)
In-Reply-To: <20131211235626.12661.8865.sendpatchset@w520>
Hi,
A couple of small comments below.
On Thu, Dec 12, 2013 at 08:56:26AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Add Kconfig entries for CMT, MTU2, TMU and STI to
> drivers/clocksource/Kconfig. This will allow us to
> get rid of duplicated entires in architecture code
> such as arch/sh and arch/arm/mach-shmobile.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> drivers/clocksource/Kconfig | 44 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> --- 0001/drivers/clocksource/Kconfig
> +++ work/drivers/clocksource/Kconfig 2013-12-12 08:41:55.000000000 +0900
> @@ -134,3 +134,47 @@ config VF_PIT_TIMER
> bool
> help
> Support for Period Interrupt Timer on Freescale Vybrid Family SoCs.
> +
> +config SYS_SUPPORTS_CMT
> + bool
> +
> +config SYS_SUPPORTS_TMU
> + bool
> +
> +config SYS_SUPPORTS_MTU2
> + bool
> +
> +config SYS_SUPPORTS_STI
> + bool
Maybe a prefix to avoid namespace collissions here?
> +
> +config SH_TIMER_CMT
> + bool "Renesas CMT timer driver" if COMPILE_TEST
> + default SYS_SUPPORTS_CMT
It might be useful to have an explicit depends on ARCH_SH || ARCH_SHMOBILE
|| COMPILE_TEST on these, just to make it easier for someone reading
the code later on.
-Olof
next prev parent reply other threads:[~2013-12-12 1:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 23:56 [PATCH v4 00/03] clocksource: Consolidate SH and ARM mach-shmobile Kconfig bits Magnus Damm
2013-12-11 23:56 ` Magnus Damm
2013-12-11 23:56 ` [PATCH v4 01/03] clocksource: Add Kconfig entries for CMT, MTU2, TMU and STI Magnus Damm
2013-12-11 23:56 ` Magnus Damm
2013-12-12 1:05 ` Olof Johansson [this message]
2013-12-12 1:05 ` Olof Johansson
2013-12-13 10:12 ` Magnus Damm
2013-12-13 10:12 ` Magnus Damm
2013-12-16 5:39 ` Olof Johansson
2013-12-16 5:39 ` Olof Johansson
2013-12-17 5:28 ` Magnus Damm
2013-12-17 5:28 ` Magnus Damm
2013-12-17 5:32 ` Olof Johansson
2013-12-17 5:32 ` Olof Johansson
2013-12-11 23:56 ` [PATCH v4 02/03] ARM: shmobile: Remove CMT, TMU and STI Kconfig entries Magnus Damm
2013-12-11 23:56 ` Magnus Damm
2013-12-11 23:56 ` [PATCH v2 03/03] sh: Remove Kconfig entries for TMU, CMT and MTU2 Magnus Damm
2013-12-11 23:56 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212010503.GI21531@quad.lixom.net \
--to=olof@lixom.net \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=horms@verge.net.au \
--cc=john.stultz@linaro.org \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.