From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Rohit Vaswani <rvaswani@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/2] gpio: msm: Fix irq mask/unmask by writing bits instead of numbers
Date: Thu, 12 Dec 2013 19:58:46 -0800 [thread overview]
Message-ID: <20131213035845.GK11990@sonymobile.com> (raw)
In-Reply-To: <CACRpkdY8W8tGVH-Os5neeFfHWjojdB5fBbjgWcsWkiMyJj=YAA@mail.gmail.com>
On Thu 12 Dec 11:02 PST 2013, Linus Walleij wrote:
> On Wed, Dec 11, 2013 at 12:19 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>
> > We should be writing bits here but instead we're writing the
> > numbers that correspond to the bits we want to write. Fix it by
> > wrapping the numbers in the BIT() macro. This fixes gpios acting
> > as interrupts.
> >
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>
> I've applied this for fixes and tagged for stable.
> Björn, Rohit: OK?
This looks good.
JFYI; the pinctrl-msm is written with gpio-msm-v2 in mind as well, so replacing
it with pinctrl is on my todo list...
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@sonymobile.com (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] gpio: msm: Fix irq mask/unmask by writing bits instead of numbers
Date: Thu, 12 Dec 2013 19:58:46 -0800 [thread overview]
Message-ID: <20131213035845.GK11990@sonymobile.com> (raw)
In-Reply-To: <CACRpkdY8W8tGVH-Os5neeFfHWjojdB5fBbjgWcsWkiMyJj=YAA@mail.gmail.com>
On Thu 12 Dec 11:02 PST 2013, Linus Walleij wrote:
> On Wed, Dec 11, 2013 at 12:19 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>
> > We should be writing bits here but instead we're writing the
> > numbers that correspond to the bits we want to write. Fix it by
> > wrapping the numbers in the BIT() macro. This fixes gpios acting
> > as interrupts.
> >
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>
> I've applied this for fixes and tagged for stable.
> Bj?rn, Rohit: OK?
This looks good.
JFYI; the pinctrl-msm is written with gpio-msm-v2 in mind as well, so replacing
it with pinctrl is on my todo list...
Regards,
Bjorn
next prev parent reply other threads:[~2013-12-13 3:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 23:19 [PATCH 1/2] gpio: msm: Fix irq mask/unmask by writing bits instead of numbers Stephen Boyd
2013-12-10 23:19 ` Stephen Boyd
2013-12-10 23:19 ` [PATCH 2/2] gpio: msm: Add module device table and mark table const Stephen Boyd
2013-12-10 23:19 ` Stephen Boyd
2013-12-12 19:04 ` Linus Walleij
2013-12-12 19:04 ` Linus Walleij
2013-12-12 19:02 ` [PATCH 1/2] gpio: msm: Fix irq mask/unmask by writing bits instead of numbers Linus Walleij
2013-12-12 19:02 ` Linus Walleij
2013-12-13 3:58 ` Bjorn Andersson [this message]
2013-12-13 3:58 ` Bjorn Andersson
2013-12-19 1:27 ` Rohit Vaswani
2013-12-19 1:27 ` Rohit Vaswani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213035845.GK11990@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rvaswani@codeaurora.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.