All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Caizhiyong <caizhiyong@hisilicon.com>
Cc: David Woodhouse <David.Woodhouse@intel.com>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Quyaxin <quyaxin@hisilicon.com>,
	"Wanglin \(Albert\)" <albert.wanglin@hisilicon.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: increase max page/OOB size to support 16K pagesize NAND
Date: Fri, 13 Dec 2013 15:27:12 +0800	[thread overview]
Message-ID: <20131213072705.GA28525@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <C3050A4DBA34F345975765E43127F10F25E47455@SZXEMA512-MBX.china.huawei.com>

On Fri, Dec 13, 2013 at 05:03:49AM +0000, Caizhiyong wrote:
> From: Cai Zhiyong <caizhiyong@huawei.com>
> Date: Fri, 13 Dec 2013 12:52:46 +0800
> Subject: [PATCH] mtd: increase max page/OOB size to support 16K pagesize NAND.
> 
> The Toshiba's TC58TEG5DCJTA pagesize is 16K, oob size is 1280 bytes.
> So increase the NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE.
> 
> Signed-off-by: Cai Zhiyong <caizhiyong@huawei.com>
> ---
>  include/linux/mtd/nand.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index f3ea8da..2f0a7f2 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -56,8 +56,8 @@ extern int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len);
>   * is supported now. If you add a chip with bigger oobsize/page
>   * adjust this accordingly.
>   */
> -#define NAND_MAX_OOBSIZE	744
> -#define NAND_MAX_PAGESIZE	8192
> +#define NAND_MAX_OOBSIZE	1280
> +#define NAND_MAX_PAGESIZE	16384
maybe it is time to remove these two macros.

thanks
Huang Shijie

WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Caizhiyong <caizhiyong@hisilicon.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	David Woodhouse <David.Woodhouse@intel.com>,
	Quyaxin <quyaxin@hisilicon.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	"Wanglin (Albert)" <albert.wanglin@hisilicon.com>
Subject: Re: [PATCH] mtd: increase max page/OOB size to support 16K pagesize NAND
Date: Fri, 13 Dec 2013 15:27:12 +0800	[thread overview]
Message-ID: <20131213072705.GA28525@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <C3050A4DBA34F345975765E43127F10F25E47455@SZXEMA512-MBX.china.huawei.com>

On Fri, Dec 13, 2013 at 05:03:49AM +0000, Caizhiyong wrote:
> From: Cai Zhiyong <caizhiyong@huawei.com>
> Date: Fri, 13 Dec 2013 12:52:46 +0800
> Subject: [PATCH] mtd: increase max page/OOB size to support 16K pagesize NAND.
> 
> The Toshiba's TC58TEG5DCJTA pagesize is 16K, oob size is 1280 bytes.
> So increase the NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE.
> 
> Signed-off-by: Cai Zhiyong <caizhiyong@huawei.com>
> ---
>  include/linux/mtd/nand.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index f3ea8da..2f0a7f2 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -56,8 +56,8 @@ extern int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len);
>   * is supported now. If you add a chip with bigger oobsize/page
>   * adjust this accordingly.
>   */
> -#define NAND_MAX_OOBSIZE	744
> -#define NAND_MAX_PAGESIZE	8192
> +#define NAND_MAX_OOBSIZE	1280
> +#define NAND_MAX_PAGESIZE	16384
maybe it is time to remove these two macros.

thanks
Huang Shijie


  reply	other threads:[~2013-12-13  7:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13  5:03 [PATCH] mtd: increase max page/OOB size to support 16K pagesize NAND Caizhiyong
2013-12-13  5:03 ` Caizhiyong
2013-12-13  7:27 ` Huang Shijie [this message]
2013-12-13  7:27   ` Huang Shijie
2013-12-13  8:04   ` Brian Norris
2013-12-13  8:04     ` Brian Norris
2013-12-13  8:01 ` Brian Norris
2013-12-13  8:01   ` Brian Norris
2013-12-13 11:10   ` Caizhiyong
2013-12-13 11:10     ` Caizhiyong
2013-12-13 15:11     ` Huang Shijie
2013-12-13 15:11       ` Huang Shijie
2013-12-16  2:03       ` Caizhiyong
2013-12-16  2:03         ` Caizhiyong
2013-12-16  3:06         ` Huang Shijie
2013-12-16  3:06           ` Huang Shijie
2013-12-16  4:08           ` Caizhiyong
2013-12-16  4:08             ` Caizhiyong
  -- strict thread matches above, loose matches on Subject: below --
2013-12-13  5:01 Caizhiyong
2013-12-13  5:01 ` Caizhiyong
2013-12-13  7:49 ` Brian Norris
2013-12-13  7:49   ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131213072705.GA28525@shlinux2.ap.freescale.net \
    --to=b32955@freescale.com \
    --cc=David.Woodhouse@intel.com \
    --cc=albert.wanglin@hisilicon.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=caizhiyong@hisilicon.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=quyaxin@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.