Re: [PATCH 1/5] drivers: misc: Mark functions as static in grukservices.c

[Josh Triplett <josh@joshtriplett.org>]

On Fri, Dec 13, 2013 at 12:12:34PM +0530, Rashika Kheria wrote:
> This patch marks the function gru_get_cb_exception_detail_str() and
> gru_abort() as static in sgi-gru/grukservices.c because they are not
> used outside this file.
> 
> Thus, it also eliminates the following warnings in
> sgi-gru/grukservices.c:
> drivers/misc/sgi-gru/grukservices.c:432:7: warning: no previous prototype for ‘gru_get_cb_exception_detail_str’ [-Wmissing-prototypes]
> drivers/misc/sgi-gru/grukservices.c:508:6: warning: no previous prototype for ‘gru_abort’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/misc/sgi-gru/grukservices.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 913de07..29d1582 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -429,7 +429,7 @@ int gru_get_cb_exception_detail(void *cb,
>  	return 0;
>  }
>  
> -char *gru_get_cb_exception_detail_str(int ret, void *cb,
> +static char *gru_get_cb_exception_detail_str(int ret, void *cb,
>  				      char *buf, int size)
>  {
>  	struct gru_control_block_status *gen = (void *)cb;
> @@ -505,7 +505,7 @@ int gru_wait_proc(void *cb)
>  	return ret;
>  }
>  
> -void gru_abort(int ret, void *cb, char *str)
> +static void gru_abort(int ret, void *cb, char *str)
>  {
>  	char buf[GRU_EXC_STR_SIZE];
>  
> -- 
> 1.7.9.5
>