From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 5/5] drivers: misc: Mark function jp_generic_ide_ioctl() as static in lkdtm.c
Date: Fri, 13 Dec 2013 00:58:11 -0800 [thread overview]
Message-ID: <20131213085811.GE4386@leaf> (raw)
In-Reply-To: <9100647978d5025b699bfec244f35bbc8ef0f7d7.1386915618.git.rashika.kheria@gmail.com>
On Fri, Dec 13, 2013 at 12:29:42PM +0530, Rashika Kheria wrote:
> This patch marks the function jp_generic_ide_ioctl() as static in
> lkdtm.c because it is not used outside this file.
>
> Thus, it also eliminates the following warnings in lkdtm.c:
> drivers/misc/lkdtm.c:227:5: warning: no previous prototype for ‘jp_generic_ide_ioctl’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/misc/lkdtm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
> index a2edb2e..79b677e 100644
> --- a/drivers/misc/lkdtm.c
> +++ b/drivers/misc/lkdtm.c
> @@ -224,7 +224,7 @@ static int jp_scsi_dispatch_cmd(struct scsi_cmnd *cmd)
> }
>
> #ifdef CONFIG_IDE
> -int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file,
> +static int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file,
> struct block_device *bdev, unsigned int cmd,
> unsigned long arg)
> {
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-12-13 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 6:42 [PATCH 1/5] drivers: misc: Mark functions as static in grukservices.c Rashika Kheria
2013-12-13 6:51 ` [PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c Rashika Kheria
2013-12-13 8:56 ` Josh Triplett
2013-12-13 17:14 ` Robin Holt
2013-12-13 6:54 ` [PATCH 3/5] drivers: misc: Mark functions as static in xpc_main.c Rashika Kheria
2013-12-13 8:57 ` Josh Triplett
2013-12-13 17:14 ` Robin Holt
2013-12-13 6:57 ` [PATCH 4/5] drivers: misc: Mark functions as static in ad525x_dpot.c Rashika Kheria
2013-12-13 8:19 ` Michael Hennerich
2013-12-13 8:57 ` Josh Triplett
2013-12-13 6:59 ` [PATCH 5/5] drivers: misc: Mark function jp_generic_ide_ioctl() as static in lkdtm.c Rashika Kheria
2013-12-13 8:58 ` Josh Triplett [this message]
2013-12-13 8:56 ` [PATCH 1/5] drivers: misc: Mark functions as static in grukservices.c Josh Triplett
2013-12-13 14:44 ` Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213085811.GE4386@leaf \
--to=josh@joshtriplett.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.