* [PATCH 2/3] drivers: message: Mark function mptscsih_quiesce_raid() as static in mptspi.c
2013-12-13 6:03 [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c Rashika Kheria
@ 2013-12-13 6:06 ` Rashika Kheria
2013-12-13 9:00 ` Josh Triplett
2013-12-13 6:10 ` [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c Rashika Kheria
2013-12-13 8:59 ` [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c Josh Triplett
2 siblings, 1 reply; 6+ messages in thread
From: Rashika Kheria @ 2013-12-13 6:06 UTC (permalink / raw)
To: linux-kernel
Cc: Nagalakshmi Nandigama, Sreekanth Reddy, support,
DL-MPTFusionLinux, linux-scsi, josh
This patch marks the function mptscsih_quiesce_raid() as static in
fusion/mptspi.c because it is not used outside this function.
Thus, it also eliminates the following warning in fusion/mptspi.c:
drivers/message/fusion/mptspi.c:624:1: warning: no previous prototype for ‘mptscsih_quiesce_raid’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/message/fusion/mptspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/message/fusion/mptspi.c b/drivers/message/fusion/mptspi.c
index 5653e50..ed8de0a 100644
--- a/drivers/message/fusion/mptspi.c
+++ b/drivers/message/fusion/mptspi.c
@@ -620,7 +620,7 @@ static void mptspi_read_parameters(struct scsi_target *starget)
spi_width(starget) = (nego & MPI_SCSIDEVPAGE0_NP_WIDE) ? 1 : 0;
}
-int
+static int
mptscsih_quiesce_raid(MPT_SCSI_HOST *hd, int quiesce, u8 channel, u8 id)
{
MPT_ADAPTER *ioc = hd->ioc;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/3] drivers: message: Mark function mptscsih_quiesce_raid() as static in mptspi.c
2013-12-13 6:06 ` [PATCH 2/3] drivers: message: Mark function mptscsih_quiesce_raid() as static in mptspi.c Rashika Kheria
@ 2013-12-13 9:00 ` Josh Triplett
0 siblings, 0 replies; 6+ messages in thread
From: Josh Triplett @ 2013-12-13 9:00 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Nagalakshmi Nandigama, Sreekanth Reddy, support,
DL-MPTFusionLinux, linux-scsi
On Fri, Dec 13, 2013 at 11:36:54AM +0530, Rashika Kheria wrote:
> This patch marks the function mptscsih_quiesce_raid() as static in
> fusion/mptspi.c because it is not used outside this function.
>
> Thus, it also eliminates the following warning in fusion/mptspi.c:
> drivers/message/fusion/mptspi.c:624:1: warning: no previous prototype for ‘mptscsih_quiesce_raid’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/message/fusion/mptspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/message/fusion/mptspi.c b/drivers/message/fusion/mptspi.c
> index 5653e50..ed8de0a 100644
> --- a/drivers/message/fusion/mptspi.c
> +++ b/drivers/message/fusion/mptspi.c
> @@ -620,7 +620,7 @@ static void mptspi_read_parameters(struct scsi_target *starget)
> spi_width(starget) = (nego & MPI_SCSIDEVPAGE0_NP_WIDE) ? 1 : 0;
> }
>
> -int
> +static int
> mptscsih_quiesce_raid(MPT_SCSI_HOST *hd, int quiesce, u8 channel, u8 id)
> {
> MPT_ADAPTER *ioc = hd->ioc;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c
2013-12-13 6:03 [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c Rashika Kheria
2013-12-13 6:06 ` [PATCH 2/3] drivers: message: Mark function mptscsih_quiesce_raid() as static in mptspi.c Rashika Kheria
@ 2013-12-13 6:10 ` Rashika Kheria
2013-12-13 9:01 ` Josh Triplett
2013-12-13 8:59 ` [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c Josh Triplett
2 siblings, 1 reply; 6+ messages in thread
From: Rashika Kheria @ 2013-12-13 6:10 UTC (permalink / raw)
To: linux-kernel
Cc: Nagalakshmi Nandigama, Sreekanth Reddy, support,
DL-MPTFusionLinux, linux-scsi, josh
This patch marks the function mptsas_refreshing_device_handles(),
mptsas_expander_add() and mptsas_shutdown() as static in fusion/mptsas.c
because they are not used outside this file.
Thus, it also eliminates the following warnings in fusion/mptsas.c:
drivers/message/fusion/mptsas.c:1579:1: warning: no previous prototype for ‘mptsas_refreshing_device_handles’ [-Wmissing-prototypes]
drivers/message/fusion/mptsas.c:3654:1: warning: no previous prototype for ‘mptsas_expander_add’ [-Wmissing-prototypes]
drivers/message/fusion/mptsas.c:5327:1: warning: no previous prototype for ‘mptsas_shutdown’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/message/fusion/mptsas.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
index dd239bd..906f448 100644
--- a/drivers/message/fusion/mptsas.c
+++ b/drivers/message/fusion/mptsas.c
@@ -1575,7 +1575,7 @@ mptsas_del_end_device(MPT_ADAPTER *ioc, struct mptsas_phyinfo *phy_info)
mptsas_port_delete(ioc, phy_info->port_details);
}
-struct mptsas_phyinfo *
+static struct mptsas_phyinfo *
mptsas_refreshing_device_handles(MPT_ADAPTER *ioc,
struct mptsas_devinfo *sas_device)
{
@@ -3650,7 +3650,7 @@ mptsas_send_expander_event(struct fw_event_work *fw_event)
* @handle:
*
*/
-struct mptsas_portinfo *
+static struct mptsas_portinfo *
mptsas_expander_add(MPT_ADAPTER *ioc, u16 handle)
{
struct mptsas_portinfo buffer, *port_info;
@@ -5323,7 +5323,7 @@ mptsas_probe(struct pci_dev *pdev, const struct pci_device_id *id)
return error;
}
-void
+static void
mptsas_shutdown(struct pci_dev *pdev)
{
MPT_ADAPTER *ioc = pci_get_drvdata(pdev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c
2013-12-13 6:10 ` [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c Rashika Kheria
@ 2013-12-13 9:01 ` Josh Triplett
0 siblings, 0 replies; 6+ messages in thread
From: Josh Triplett @ 2013-12-13 9:01 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Nagalakshmi Nandigama, Sreekanth Reddy, support,
DL-MPTFusionLinux, linux-scsi
On Fri, Dec 13, 2013 at 11:40:35AM +0530, Rashika Kheria wrote:
> This patch marks the function mptsas_refreshing_device_handles(),
> mptsas_expander_add() and mptsas_shutdown() as static in fusion/mptsas.c
> because they are not used outside this file.
>
> Thus, it also eliminates the following warnings in fusion/mptsas.c:
> drivers/message/fusion/mptsas.c:1579:1: warning: no previous prototype for ‘mptsas_refreshing_device_handles’ [-Wmissing-prototypes]
> drivers/message/fusion/mptsas.c:3654:1: warning: no previous prototype for ‘mptsas_expander_add’ [-Wmissing-prototypes]
> drivers/message/fusion/mptsas.c:5327:1: warning: no previous prototype for ‘mptsas_shutdown’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/message/fusion/mptsas.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
> index dd239bd..906f448 100644
> --- a/drivers/message/fusion/mptsas.c
> +++ b/drivers/message/fusion/mptsas.c
> @@ -1575,7 +1575,7 @@ mptsas_del_end_device(MPT_ADAPTER *ioc, struct mptsas_phyinfo *phy_info)
> mptsas_port_delete(ioc, phy_info->port_details);
> }
>
> -struct mptsas_phyinfo *
> +static struct mptsas_phyinfo *
> mptsas_refreshing_device_handles(MPT_ADAPTER *ioc,
> struct mptsas_devinfo *sas_device)
> {
> @@ -3650,7 +3650,7 @@ mptsas_send_expander_event(struct fw_event_work *fw_event)
> * @handle:
> *
> */
> -struct mptsas_portinfo *
> +static struct mptsas_portinfo *
> mptsas_expander_add(MPT_ADAPTER *ioc, u16 handle)
> {
> struct mptsas_portinfo buffer, *port_info;
> @@ -5323,7 +5323,7 @@ mptsas_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> return error;
> }
>
> -void
> +static void
> mptsas_shutdown(struct pci_dev *pdev)
> {
> MPT_ADAPTER *ioc = pci_get_drvdata(pdev);
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c
2013-12-13 6:03 [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c Rashika Kheria
2013-12-13 6:06 ` [PATCH 2/3] drivers: message: Mark function mptscsih_quiesce_raid() as static in mptspi.c Rashika Kheria
2013-12-13 6:10 ` [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c Rashika Kheria
@ 2013-12-13 8:59 ` Josh Triplett
2 siblings, 0 replies; 6+ messages in thread
From: Josh Triplett @ 2013-12-13 8:59 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Nagalakshmi Nandigama, Sreekanth Reddy, support,
DL-MPTFusionLinux, linux-scsi
On Fri, Dec 13, 2013 at 11:33:11AM +0530, Rashika Kheria wrote:
> This patch marks the function mpt_SoftResetHandler() as static in mptbase.c
> because it is not used outside this file.
>
> Thus, it also eliminates the following warning in fusion/mptbase.c:
> drivers/message/fusion/mptbase.c:7011:1: warning: no previous prototype for ‘mpt_SoftResetHandler’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/message/fusion/mptbase.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
> index 767ff4d..c783a42 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -7007,7 +7007,7 @@ EXPORT_SYMBOL(mpt_halt_firmware);
> * IOC doesn't reply to any outstanding request. This will transfer IOC
> * to READY state.
> **/
> -int
> +static int
> mpt_SoftResetHandler(MPT_ADAPTER *ioc, int sleepFlag)
> {
> int rc;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread