All of lore.kernel.org
 help / color / mirror / Atom feed
From: mporter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs
Date: Fri, 13 Dec 2013 09:10:52 -0500	[thread overview]
Message-ID: <20131213141052.GA23499@beef> (raw)
In-Reply-To: <1385511748-27869-2-git-send-email-marc.ceeeee@gmail.com>

On Tue, Nov 26, 2013 at 04:22:23PM -0800, Marc Carino wrote:
> The BCM7xxx series of Broadcom SoCs are used primarily in set-top boxes.
> 
> This patch adds machine support for the ARM-based Broadcom SoCs.
> 
> Signed-off-by: Marc Carino <marc.ceeeee@gmail.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>

<snip>

> diff --git a/arch/arm/mach-bcm/brcmstb.h b/arch/arm/mach-bcm/brcmstb.h
> new file mode 100644
> index 0000000..d08dffc
> --- /dev/null
> +++ b/arch/arm/mach-bcm/brcmstb.h
> @@ -0,0 +1,70 @@
> +/*
> + * Copyright (C) 2013 Broadcom Corporation
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __BRCMSTB_H__
> +#define __BRCMSTB_H__
> +
> +#if !defined(__ASSEMBLY__)
> +#include <linux/smp.h>
> +#endif
> +
> +#define BRCMSTB_PERIPH_VIRT				0xfc000000
> +#define BRCMSTB_PERIPH_PHYS				0xf0000000
> +#define BRCMSTB_PERIPH_LENGTH				0x02000000
> +
> +#define BVIRTADDR(x)	(BRCMSTB_PERIPH_VIRT + ((x) & 0x0fffffff))
> +#define BPHYSADDR(x)	((x) + BRCMSTB_PERIPH_PHYS)
> +
> +#define BCHP_UARTA_REG_START				0x00406b00
> +
> +#define BCHP_IRQ0_IRQEN					0x00406780
> +#define BCHP_IRQ0_IRQEN_uarta_irqen_MASK		0x00010000
> +#define BCHP_IRQ0_IRQEN_uartb_irqen_MASK		0x00020000
> +#define BCHP_IRQ0_IRQEN_uartc_irqen_MASK		0x00040000

These need to be all uppercase. Using bitops might be nice too.

-Matt

WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <mporter@linaro.org>
To: Marc Carino <marc.ceeeee@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
	Christian Daudt <bcm@fixthebug.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Florian Fainelli <f.fainelli@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs
Date: Fri, 13 Dec 2013 09:10:52 -0500	[thread overview]
Message-ID: <20131213141052.GA23499@beef> (raw)
In-Reply-To: <1385511748-27869-2-git-send-email-marc.ceeeee@gmail.com>

On Tue, Nov 26, 2013 at 04:22:23PM -0800, Marc Carino wrote:
> The BCM7xxx series of Broadcom SoCs are used primarily in set-top boxes.
> 
> This patch adds machine support for the ARM-based Broadcom SoCs.
> 
> Signed-off-by: Marc Carino <marc.ceeeee@gmail.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>

<snip>

> diff --git a/arch/arm/mach-bcm/brcmstb.h b/arch/arm/mach-bcm/brcmstb.h
> new file mode 100644
> index 0000000..d08dffc
> --- /dev/null
> +++ b/arch/arm/mach-bcm/brcmstb.h
> @@ -0,0 +1,70 @@
> +/*
> + * Copyright (C) 2013 Broadcom Corporation
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __BRCMSTB_H__
> +#define __BRCMSTB_H__
> +
> +#if !defined(__ASSEMBLY__)
> +#include <linux/smp.h>
> +#endif
> +
> +#define BRCMSTB_PERIPH_VIRT				0xfc000000
> +#define BRCMSTB_PERIPH_PHYS				0xf0000000
> +#define BRCMSTB_PERIPH_LENGTH				0x02000000
> +
> +#define BVIRTADDR(x)	(BRCMSTB_PERIPH_VIRT + ((x) & 0x0fffffff))
> +#define BPHYSADDR(x)	((x) + BRCMSTB_PERIPH_PHYS)
> +
> +#define BCHP_UARTA_REG_START				0x00406b00
> +
> +#define BCHP_IRQ0_IRQEN					0x00406780
> +#define BCHP_IRQ0_IRQEN_uarta_irqen_MASK		0x00010000
> +#define BCHP_IRQ0_IRQEN_uartb_irqen_MASK		0x00020000
> +#define BCHP_IRQ0_IRQEN_uartc_irqen_MASK		0x00040000

These need to be all uppercase. Using bitops might be nice too.

-Matt

  parent reply	other threads:[~2013-12-13 14:10 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  0:22 [PATCH v2 0/6] ARM: brcmstb: Add Broadcom STB SoC support Marc Carino
2013-11-27  0:22 ` Marc Carino
2013-11-27  0:22 ` [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs Marc Carino
2013-11-27  0:22   ` Marc Carino
2013-12-03 15:01   ` Arnd Bergmann
2013-12-03 15:01     ` Arnd Bergmann
2013-12-05 18:48     ` Florian Fainelli
2013-12-05 18:48       ` Florian Fainelli
2013-12-05 20:07       ` Arnd Bergmann
2013-12-05 20:07         ` Arnd Bergmann
2013-12-06 22:12         ` Florian Fainelli
2013-12-06 22:12           ` Florian Fainelli
2013-12-06 22:50           ` Arnd Bergmann
2013-12-06 22:50             ` Arnd Bergmann
2013-12-06  6:41     ` Marc C
2013-12-06  6:41       ` Marc C
2013-12-06 17:00       ` Arnd Bergmann
2013-12-06 17:00         ` Arnd Bergmann
2013-12-13 14:10   ` Matt Porter [this message]
2013-12-13 14:10     ` Matt Porter
2013-11-27  0:22 ` [PATCH v2 2/6] ARM: do CPU-specific init for Broadcom Brahma15 cores Marc Carino
2013-11-27  0:22   ` Marc Carino
2013-11-27  0:22 ` [PATCH v2 3/6] ARM: brcmstb: add CPU binding for Broadcom Brahma15 Marc Carino
2013-11-27  0:22   ` Marc Carino
2013-11-27  0:22 ` [PATCH v2 4/6] ARM: brcmstb: add misc. DT bindings for brcm,brcmstb Marc Carino
2013-11-27  0:22   ` Marc Carino
2013-12-13 14:23   ` Matt Porter
2013-12-13 14:23     ` Matt Porter
2013-11-27  0:22 ` [PATCH v2 5/6] ARM: brcmstb: gic: add compatible string for Broadcom Brahma15 Marc Carino
2013-11-27  0:22   ` Marc Carino
2013-11-27  0:22 ` [PATCH v2 6/6] ARM: brcmstb: dts: add a reference DTS for Broadcom 7445 Marc Carino
2013-11-27  0:22   ` Marc Carino
2013-12-13 14:40   ` Matt Porter
2013-12-13 14:40     ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131213141052.GA23499@beef \
    --to=mporter@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.