From: Christoph Hellwig <hch@infradead.org>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid()
Date: Fri, 13 Dec 2013 08:32:11 -0800 [thread overview]
Message-ID: <20131213163211.GD20803@infradead.org> (raw)
In-Reply-To: <1386944873-16796-2-git-send-email-zwu.kernel@gmail.com>
> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp)
> +{
> + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
> + return xfs_get_projid(dp);
> + else
> + return XFS_PROJID_DEFAULT;
> +}
You could skip the else here.
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid()
Date: Fri, 13 Dec 2013 08:32:11 -0800 [thread overview]
Message-ID: <20131213163211.GD20803@infradead.org> (raw)
In-Reply-To: <1386944873-16796-2-git-send-email-zwu.kernel@gmail.com>
> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp)
> +{
> + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
> + return xfs_get_projid(dp);
> + else
> + return XFS_PROJID_DEFAULT;
> +}
You could skip the else here.
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2013-12-13 16:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 14:27 [PATCH 0/5] xfs: add O_TMPFILE support Zhi Yong Wu
2013-12-13 14:27 ` Zhi Yong Wu
2013-12-13 14:27 ` [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid() Zhi Yong Wu
2013-12-13 14:27 ` Zhi Yong Wu
2013-12-13 16:32 ` Christoph Hellwig [this message]
2013-12-13 16:32 ` Christoph Hellwig
2013-12-14 11:20 ` Jeff Liu
2013-12-14 11:20 ` Jeff Liu
2013-12-14 11:43 ` Zhi Yong Wu
2013-12-14 11:43 ` Zhi Yong Wu
2013-12-13 14:27 ` [PATCH 2/5] xfs: adjust the interface of xfs_qm_vop_dqalloc() Zhi Yong Wu
2013-12-13 14:27 ` Zhi Yong Wu
2013-12-13 16:32 ` Christoph Hellwig
2013-12-13 16:32 ` Christoph Hellwig
2013-12-13 17:29 ` Zhi Yong Wu
2013-12-13 17:29 ` Zhi Yong Wu
2013-12-13 14:27 ` [PATCH 3/5] xfs: add xfs_create_tmpfile() for O_TMPFILE support Zhi Yong Wu
2013-12-13 14:27 ` Zhi Yong Wu
2013-12-13 16:37 ` Christoph Hellwig
2013-12-13 16:37 ` Christoph Hellwig
2013-12-13 17:29 ` Zhi Yong Wu
2013-12-13 17:29 ` Zhi Yong Wu
2013-12-13 14:27 ` [PATCH 4/5] xfs: add a new method xfs_vn_tmpfile() Zhi Yong Wu
2013-12-13 14:27 ` Zhi Yong Wu
2013-12-13 16:39 ` Christoph Hellwig
2013-12-13 16:39 ` Christoph Hellwig
2013-12-13 17:32 ` Zhi Yong Wu
2013-12-13 17:32 ` Zhi Yong Wu
2013-12-13 14:27 ` [PATCH 5/5] xfs: allow linkat() on O_TMPFILE files Zhi Yong Wu
2013-12-13 14:27 ` Zhi Yong Wu
2013-12-13 16:41 ` Christoph Hellwig
2013-12-13 16:41 ` Christoph Hellwig
2013-12-13 17:36 ` Zhi Yong Wu
2013-12-13 17:36 ` Zhi Yong Wu
2013-12-14 8:19 ` Dave Chinner
2013-12-14 8:19 ` Dave Chinner
2013-12-14 9:58 ` Zhi Yong Wu
2013-12-14 9:58 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213163211.GD20803@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=xfs@oss.sgi.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.