All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: nm@ti.com, mark.rutland@arm.com, paul@pwsan.com,
	mturquette@linaro.org, bcousson@baylibre.com,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/3] OMAP2+: hwmod: Add support to parse clock info from DT
Date: Fri, 13 Dec 2013 09:31:10 -0800	[thread overview]
Message-ID: <20131213173110.GF28184@atomide.com> (raw)
In-Reply-To: <1386848309-14076-1-git-send-email-rnayak@ti.com>

* Rajendra Nayak <rnayak@ti.com> [131212 03:40]:
> v1 of this series was posted a while back [1] but there wasn't much that
> was concluded if the approach used in the series was acceptable or if there
> are better alternatives. So I am just doing a repost of these to see if we
> can conclude this time around.
> 
> Needless to say, patches are based off Teros omap-clocks-to-dt v10 series [2]
> and I also pulled in Tonys fix to handle DT nodes with multiple 'ti,hwmod'
> values [3]. The approach taken in the series *does not* work for cases with
> multiple 'ti,hwmod' values and hence [3] helps me skip those instances
> for now. But based on some of the recent discussions on multiple 'ti-hwmod'
> values [4] it looks like its generally agreed upon that having DT nodes with
> multiple 'ti-hwmod' property is wrong and that those instances need to be
> fixed up anyway.

Yeah we need to have 1-to-1 mapping of device entries in the .dtsi files
to the device entries in the omap_hwmod_*_data.c files. And then we can
just deprecate "ti,hwmods" property and start parsing the standard compatible
flag instead.

Regards,

Tony
 
> [1] http://www.spinics.net/lists/linux-omap/msg95746.html
> [2] http://www.spinics.net/lists/devicetree/msg13455.html
> [3] http://www.spinics.net/lists/arm-kernel/msg288036.html
> [4] http://www.spinics.net/lists/arm-kernel/msg288023.html
> 
> Rajendra Nayak (3):
>   ARM: OMAP2+: Add support to parse 'main_clk' info from DT
>   ARM: OMAP2+: Add support to parse optional clk info from DT
>   ARM: OMAP4: dts: Add main and optional clock data into DT
> 
>  arch/arm/boot/dts/omap4.dtsi               |  100 +++++++++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod.c           |   88 ++++++++++++++++++--
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  122 ----------------------------
>  3 files changed, 180 insertions(+), 130 deletions(-)
> 
> -- 
> 1.7.9.5
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] OMAP2+: hwmod: Add support to parse clock info from DT
Date: Fri, 13 Dec 2013 09:31:10 -0800	[thread overview]
Message-ID: <20131213173110.GF28184@atomide.com> (raw)
In-Reply-To: <1386848309-14076-1-git-send-email-rnayak@ti.com>

* Rajendra Nayak <rnayak@ti.com> [131212 03:40]:
> v1 of this series was posted a while back [1] but there wasn't much that
> was concluded if the approach used in the series was acceptable or if there
> are better alternatives. So I am just doing a repost of these to see if we
> can conclude this time around.
> 
> Needless to say, patches are based off Teros omap-clocks-to-dt v10 series [2]
> and I also pulled in Tonys fix to handle DT nodes with multiple 'ti,hwmod'
> values [3]. The approach taken in the series *does not* work for cases with
> multiple 'ti,hwmod' values and hence [3] helps me skip those instances
> for now. But based on some of the recent discussions on multiple 'ti-hwmod'
> values [4] it looks like its generally agreed upon that having DT nodes with
> multiple 'ti-hwmod' property is wrong and that those instances need to be
> fixed up anyway.

Yeah we need to have 1-to-1 mapping of device entries in the .dtsi files
to the device entries in the omap_hwmod_*_data.c files. And then we can
just deprecate "ti,hwmods" property and start parsing the standard compatible
flag instead.

Regards,

Tony
 
> [1] http://www.spinics.net/lists/linux-omap/msg95746.html
> [2] http://www.spinics.net/lists/devicetree/msg13455.html
> [3] http://www.spinics.net/lists/arm-kernel/msg288036.html
> [4] http://www.spinics.net/lists/arm-kernel/msg288023.html
> 
> Rajendra Nayak (3):
>   ARM: OMAP2+: Add support to parse 'main_clk' info from DT
>   ARM: OMAP2+: Add support to parse optional clk info from DT
>   ARM: OMAP4: dts: Add main and optional clock data into DT
> 
>  arch/arm/boot/dts/omap4.dtsi               |  100 +++++++++++++++++++++++
>  arch/arm/mach-omap2/omap_hwmod.c           |   88 ++++++++++++++++++--
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  122 ----------------------------
>  3 files changed, 180 insertions(+), 130 deletions(-)
> 
> -- 
> 1.7.9.5
> 

  parent reply	other threads:[~2013-12-13 17:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12 11:38 [PATCH v2 0/3] OMAP2+: hwmod: Add support to parse clock info from DT Rajendra Nayak
2013-12-12 11:38 ` Rajendra Nayak
2013-12-12 11:38 ` [PATCH v2 1/3] ARM: OMAP2+: Add support to parse 'main_clk' " Rajendra Nayak
2013-12-12 11:38   ` Rajendra Nayak
2013-12-12 11:38 ` [PATCH v2 2/3] ARM: OMAP2+: Add support to parse optional clk " Rajendra Nayak
2013-12-12 11:38   ` Rajendra Nayak
2014-01-09 15:19   ` Nishanth Menon
2014-01-09 15:19     ` Nishanth Menon
2013-12-12 11:38 ` [PATCH v2 3/3] ARM: OMAP4: dts: Add main and optional clock data into DT Rajendra Nayak
2013-12-12 11:38   ` Rajendra Nayak
2013-12-15  3:40   ` Mike Turquette
2013-12-15  3:40     ` Mike Turquette
2013-12-13 17:31 ` Tony Lindgren [this message]
2013-12-13 17:31   ` [PATCH v2 0/3] OMAP2+: hwmod: Add support to parse clock info from DT Tony Lindgren
2014-02-28 21:56   ` Tony Lindgren
2014-02-28 21:56     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131213173110.GF28184@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@linaro.org \
    --cc=nm@ti.com \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.