All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x
Date: Sat, 14 Dec 2013 13:30:30 +0100	[thread overview]
Message-ID: <201312141330.30990.marex@denx.de> (raw)
In-Reply-To: <1386999720-23460-3-git-send-email-ynvich@gmail.com>

On Saturday, December 14, 2013 at 06:41:58 AM, Sergei Ianovich wrote:
> I always used tftp in my test, so the first dm9000 on LP-8x4x was
> always properly initialized. However, if the boot doesn't include
> network related commands, linux will not find a valid MAC and will
> complain.
> 
> No longer.
> 
> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
> ---
>  board/icpdas/lp8x4x/lp8x4x.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/board/icpdas/lp8x4x/lp8x4x.c b/board/icpdas/lp8x4x/lp8x4x.c
> index 1b68ef3..8396caa 100644
> --- a/board/icpdas/lp8x4x/lp8x4x.c
> +++ b/board/icpdas/lp8x4x/lp8x4x.c
> @@ -112,10 +112,18 @@ void usb_board_stop(void)
>  #ifdef CONFIG_DRIVER_DM9000
>  void lp8x4x_eth1_mac_init(void)
>  {
> +	u8 ethaddr[8];
>  	u8 eth1addr[8];
>  	int i;
>  	u8 reg;
> 
> +	eth_getenv_enetaddr_by_index("eth", 0, ethaddr);
> +	if (is_valid_ether_addr(ethaddr)) {
> +		for (i = 0, reg = 0x10; i < 6; i++, reg++) {
> +			writeb(reg, (u8 *)(DM9000_IO));
> +			writeb(ethaddr[i], (u8 *)(DM9000_DATA));
> +		}
> +	}
>  	eth_getenv_enetaddr_by_index("eth", 1, eth1addr);
>  	if (!is_valid_ether_addr(eth1addr))
>  		return;

Please pass the ethernet address via DT, will that not work for you ?

Best regards,
Marek Vasut

  reply	other threads:[~2013-12-14 12:30 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-14  5:41 [U-Boot] [PATCH 0/4] fix and update LP-8x4x to boot DTS kernel Sergei Ianovich
2013-12-14  5:41 ` [U-Boot] [PATCH 1/4] ARM: pxa: prevent PXA270 occasional reboot freezes Sergei Ianovich
2013-12-14 12:29   ` Marek Vasut
2013-12-14 15:31     ` Sergei Ianovich
2013-12-14 17:14       ` Marek Vasut
2013-12-14 23:51         ` Sergei Ianovich
2013-12-15  5:17           ` Marek Vasut
2013-12-15  9:48             ` Sergei Ianovich
2013-12-15 15:04               ` Marek Vasut
2013-12-14  5:41 ` [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x Sergei Ianovich
2013-12-14 12:30   ` Marek Vasut [this message]
2013-12-14 15:39     ` Sergei Ianovich
2013-12-14 17:12       ` Marek Vasut
2013-12-14 20:53         ` Sergei Ianovich
2013-12-14 20:57           ` Marek Vasut
2013-12-14 23:53             ` Sergei Ianovich
2013-12-15  5:17               ` Marek Vasut
2013-12-15  9:44                 ` Sergei Ianovich
2013-12-15 15:05                   ` Marek Vasut
2013-12-15 18:43                     ` Sergei Ianovich
2013-12-14  5:41 ` [U-Boot] [PATCH 3/4] arm: pxa: fix 2nd flash chip address on LP-8x4x Sergei Ianovich
2013-12-14  5:42 ` [U-Boot] [PATCH 4/4] arm: pxa: update LP-8x4x to boot DTS kernel Sergei Ianovich
2013-12-14 12:32   ` Marek Vasut
2013-12-14 15:41     ` Sergei Ianovich
2013-12-14 17:05       ` Marek Vasut
2013-12-15  9:57         ` Sergei Ianovich
2013-12-15 15:06           ` Marek Vasut
2013-12-15 18:56             ` Sergei Ianovich
2013-12-15 19:22               ` Marek Vasut
2013-12-17  1:07                 ` Sergei Ianovich
2013-12-17  1:03 ` [U-Boot] [PATCH v2 0/5] fix and update LP-8x4x to boot DT kernel Sergei Ianovich
2013-12-17  1:03   ` [U-Boot] [PATCH v2 1/5] ARM: pxa: prevent PXA270 occasional reboot freezes Sergei Ianovich
2013-12-17  1:03   ` [U-Boot] [PATCH v2 2/5] arm: pxa: fix LP-8x4x USB support Sergei Ianovich
2013-12-18 15:01     ` Marek Vasut
2013-12-18 16:19     ` [U-Boot] [PATCH v3] " Sergei Ianovich
2013-12-18 17:15       ` Marek Vasut
2013-12-17  1:03   ` [U-Boot] [PATCH v2 3/5] arm: pxa: fix 2nd flash chip address on LP-8x4x Sergei Ianovich
2013-12-17  1:03   ` [U-Boot] [PATCH v2 4/5] arm: pxa: update LP-8x4x to boot DT kernel Sergei Ianovich
2013-12-17  1:03   ` [U-Boot] [PATCH v2 5/5] arm: pxa: init ethaddr for LP-8x4x using DT Sergei Ianovich
2013-12-18 15:01   ` [U-Boot] [PATCH v2 0/5] fix and update LP-8x4x to boot DT kernel Marek Vasut
2013-12-18 16:21     ` Sergei Ianovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201312141330.30990.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.