All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 00/12] i8k patch series
Date: Sat, 14 Dec 2013 18:45:19 +0000	[thread overview]
Message-ID: <201312141945.20348.arnd@arndb.de> (raw)
In-Reply-To: <1387042221-3671-1-git-send-email-linux@roeck-us.net>

On Saturday 14 December 2013, Guenter Roeck wrote:
> Clean up and simplify the driver, add support for additional temperature
> sensors, fix a problem seen with multi-core CPU, and add support
> for additional systems.
> 
> ----------------------------------------------------------------
> Guenter Roeck (14):
>       i8k: Convert to use pr_ functions instead of printk
>       i8k: Fix various checkpatch warnings and errors
>       i8k: Convert to use to hwmon_device_register_with_groups hwmon API
>       i8k: Support additional temperature sensors
>       MAINTAINERS: Add myself as i8k maintainer
>       i8k: Remove obsolete link to out-of-tree driver
>       i8k: Drop driver version number and info message at startup
>       i8k: Force SMM to run on CPU 0
>       i8k: Add copyright
>       i8k: Add support for Dell Studio laptops
>       i8k: Add support for Dell XPS M140
>       i8k: Use driver_data field of dmi_system_id to override fan multiplier
>       i8k: Stop reading SMM BIOS version during driver probe
>       i8k: Implement hwmon based fan speed control
> 
>  MAINTAINERS        |    2 +-
>  drivers/char/i8k.c |  358 +++++++++++++++++++++++++++++-----------------------
>  2 files changed, 201 insertions(+), 159 deletions(-)
> 

All changes in this patch set look good to me.

Acked-by: Arnd Bergmann <arnd@arndb.de>

I wonder if it makes sense to move the driver to drivers/platform/x86/, which
has a bunch of similar ones already.

	Arnd

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/12] i8k patch series
Date: Sat, 14 Dec 2013 19:45:19 +0100	[thread overview]
Message-ID: <201312141945.20348.arnd@arndb.de> (raw)
In-Reply-To: <1387042221-3671-1-git-send-email-linux@roeck-us.net>

On Saturday 14 December 2013, Guenter Roeck wrote:
> Clean up and simplify the driver, add support for additional temperature
> sensors, fix a problem seen with multi-core CPU, and add support
> for additional systems.
> 
> ----------------------------------------------------------------
> Guenter Roeck (14):
>       i8k: Convert to use pr_ functions instead of printk
>       i8k: Fix various checkpatch warnings and errors
>       i8k: Convert to use to hwmon_device_register_with_groups hwmon API
>       i8k: Support additional temperature sensors
>       MAINTAINERS: Add myself as i8k maintainer
>       i8k: Remove obsolete link to out-of-tree driver
>       i8k: Drop driver version number and info message at startup
>       i8k: Force SMM to run on CPU 0
>       i8k: Add copyright
>       i8k: Add support for Dell Studio laptops
>       i8k: Add support for Dell XPS M140
>       i8k: Use driver_data field of dmi_system_id to override fan multiplier
>       i8k: Stop reading SMM BIOS version during driver probe
>       i8k: Implement hwmon based fan speed control
> 
>  MAINTAINERS        |    2 +-
>  drivers/char/i8k.c |  358 +++++++++++++++++++++++++++++-----------------------
>  2 files changed, 201 insertions(+), 159 deletions(-)
> 

All changes in this patch set look good to me.

Acked-by: Arnd Bergmann <arnd@arndb.de>

I wonder if it makes sense to move the driver to drivers/platform/x86/, which
has a bunch of similar ones already.

	Arnd

  parent reply	other threads:[~2013-12-14 18:45 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-14 17:30 [lm-sensors] [PATCH 00/12] i8k patch series Guenter Roeck
2013-12-14 17:30 ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 01/14] i8k: Convert to use pr_ functions instead of printk Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 02/14] i8k: Fix various checkpatch warnings and errors Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 03/14] i8k: Convert to use to hwmon_device_register_with_groups hwmon API Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 04/14] i8k: Support additional temperature sensors Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 05/14] MAINTAINERS: Add myself as i8k maintainer Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 06/14] i8k: Remove obsolete link to out-of-tree driver Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 07/14] i8k: Drop driver version number and info message at startup Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 08/14] i8k: Force SMM to run on CPU 0 Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 09/14] i8k: Add copyright Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 10/14] i8k: Add support for Dell Studio laptops Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 11/14] i8k: Add support for Dell XPS M140 Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 12/14] i8k: Use driver_data field of dmi_system_id to override fan multiplier Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 13/14] i8k: Stop reading SMM BIOS version during driver probe Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:30 ` [lm-sensors] [PATCH 14/14] i8k: Implement hwmon based fan speed control Guenter Roeck
2013-12-14 17:30   ` Guenter Roeck
2013-12-14 17:38 ` [lm-sensors] [PATCH 00/12] i8k patch series Guenter Roeck
2013-12-14 17:38   ` Guenter Roeck
2013-12-14 18:45 ` Arnd Bergmann [this message]
2013-12-14 18:45   ` Arnd Bergmann
2013-12-14 19:03   ` [lm-sensors] " Jean Delvare
2013-12-14 19:03     ` Jean Delvare
2013-12-14 19:50     ` Guenter Roeck
2013-12-14 19:50       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201312141945.20348.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.